* [PATCH] python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
@ 2019-09-09 3:16 Khem Raj
2019-09-09 3:32 ` ✗ patchtest: failure for " Patchwork
2019-09-09 7:44 ` [PATCH] " Richard Purdie
0 siblings, 2 replies; 4+ messages in thread
From: Khem Raj @ 2019-09-09 3:16 UTC (permalink / raw)
To: openembedded-core
This helps recipes where they need to explicitly pass the variable and
does not entertain the ones from environment
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/classes/python3native.bbclass | 6 ++++--
meta/classes/pythonnative.bbclass | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/meta/classes/python3native.bbclass b/meta/classes/python3native.bbclass
index d98fb4c758..bed04bd941 100644
--- a/meta/classes/python3native.bbclass
+++ b/meta/classes/python3native.bbclass
@@ -14,8 +14,8 @@ export STAGING_LIBDIR
# find_package(PythonLibs REQUIRED)
# which ends up using libs/includes from build host
# Therefore pre-empt that effort
-export PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
-export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
+PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
+PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
export _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata"
@@ -24,3 +24,5 @@ export PYTHONNOUSERSITE = "1"
# autoconf macros will use their internal default preference otherwise
export PYTHON
+export PYTHON_LIBRARY
+export PYTHON_INCLUDE_DIR
diff --git a/meta/classes/pythonnative.bbclass b/meta/classes/pythonnative.bbclass
index 0e9019d1e2..5fa42aaeff 100644
--- a/meta/classes/pythonnative.bbclass
+++ b/meta/classes/pythonnative.bbclass
@@ -17,11 +17,13 @@ export STAGING_LIBDIR
# find_package(PythonLibs REQUIRED)
# which ends up using libs/includes from build host
# Therefore pre-empt that effort
-export PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
-export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
+PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
+PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
# suppress host user's site-packages dirs.
export PYTHONNOUSERSITE = "1"
# autoconf macros will use their internal default preference otherwise
export PYTHON
+export PYTHON_LIBRARY
+export PYTHON_INCLUDE_DIR
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ patchtest: failure for python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
2019-09-09 3:16 [PATCH] python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR Khem Raj
@ 2019-09-09 3:32 ` Patchwork
2019-09-09 7:44 ` [PATCH] " Richard Purdie
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-09-09 3:32 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
== Series Details ==
Series: python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
Revision: 1
URL : https://patchwork.openembedded.org/series/19781/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Patch python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
Issue Commit shortlog is too long [test_shortlog_length]
Suggested fix Edit shortlog so that it is 90 characters or less (currently 100 characters)
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
2019-09-09 3:16 [PATCH] python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR Khem Raj
2019-09-09 3:32 ` ✗ patchtest: failure for " Patchwork
@ 2019-09-09 7:44 ` Richard Purdie
2019-09-09 14:21 ` Khem Raj
1 sibling, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2019-09-09 7:44 UTC (permalink / raw)
To: Khem Raj, openembedded-core
On Sun, 2019-09-08 at 20:16 -0700, Khem Raj wrote:
> This helps recipes where they need to explicitly pass the variable
> and
> does not entertain the ones from environment
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/classes/python3native.bbclass | 6 ++++--
> meta/classes/pythonnative.bbclass | 6 ++++--
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/meta/classes/python3native.bbclass
> b/meta/classes/python3native.bbclass
> index d98fb4c758..bed04bd941 100644
> --- a/meta/classes/python3native.bbclass
> +++ b/meta/classes/python3native.bbclass
> @@ -14,8 +14,8 @@ export STAGING_LIBDIR
> # find_package(PythonLibs REQUIRED)
> # which ends up using libs/includes from build host
> # Therefore pre-empt that effort
> -export
> PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
> -export
> PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
> +PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
> +PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
>
> export _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata"
>
> @@ -24,3 +24,5 @@ export PYTHONNOUSERSITE = "1"
>
> # autoconf macros will use their internal default preference
> otherwise
> export PYTHON
> +export PYTHON_LIBRARY
> +export PYTHON_INCLUDE_DIR
I'm confused as this makes no difference to bitbake and is equivalent.
exported variables are always set in the datastore...
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR
2019-09-09 7:44 ` [PATCH] " Richard Purdie
@ 2019-09-09 14:21 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2019-09-09 14:21 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Mon, Sep 9, 2019 at 12:44 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sun, 2019-09-08 at 20:16 -0700, Khem Raj wrote:
> > This helps recipes where they need to explicitly pass the variable
> > and
> > does not entertain the ones from environment
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > meta/classes/python3native.bbclass | 6 ++++--
> > meta/classes/pythonnative.bbclass | 6 ++++--
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/meta/classes/python3native.bbclass
> > b/meta/classes/python3native.bbclass
> > index d98fb4c758..bed04bd941 100644
> > --- a/meta/classes/python3native.bbclass
> > +++ b/meta/classes/python3native.bbclass
> > @@ -14,8 +14,8 @@ export STAGING_LIBDIR
> > # find_package(PythonLibs REQUIRED)
> > # which ends up using libs/includes from build host
> > # Therefore pre-empt that effort
> > -export
> > PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
> > -export
> > PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
> > +PYTHON_LIBRARY="${STAGING_LIBDIR}/lib${PYTHON_DIR}${PYTHON_ABI}.so"
> > +PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_DIR}${PYTHON_ABI}"
> >
> > export _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata"
> >
> > @@ -24,3 +24,5 @@ export PYTHONNOUSERSITE = "1"
> >
> > # autoconf macros will use their internal default preference
> > otherwise
> > export PYTHON
> > +export PYTHON_LIBRARY
> > +export PYTHON_INCLUDE_DIR
>
> I'm confused as this makes no difference to bitbake and is equivalent.
> exported variables are always set in the datastore...
>
I was still seeing it unset on am ARM builder, I, however, did a
composite change where this change along with another change where
this was used went in together so I need to test this separately
second reeason was to make it adhere to same convention in the
bbclass like other variable e.g. PYTHON which inself could be reeason
good for this change even if it is a nop
> Cheers,
>
> Richard
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-09 14:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 3:16 [PATCH] python3native, pythonnative: Separate definition and export of PYTHON_LIBRARY and PYTHON_INCLUDE_DIR Khem Raj
2019-09-09 3:32 ` ✗ patchtest: failure for " Patchwork
2019-09-09 7:44 ` [PATCH] " Richard Purdie
2019-09-09 14:21 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.