* [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2
@ 2019-09-11 1:48 Kenneth Graunke
2019-09-11 2:34 ` ✓ Fi.CI.BAT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Kenneth Graunke @ 2019-09-11 1:48 UTC (permalink / raw)
To: intel-gfx
This allows userspace to use "legacy" mode for push constants, where
they are committed at 3DPRIMITIVE or flush time, rather than being
committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11
both use the "legacy" behavior - only Gen9 works in the "new" way.
Conflating push constants with binding tables is painful for userspace,
we would like to be able to avoid doing so.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 243d3f77be13..41d0f786e06d 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1062,6 +1062,9 @@ static void gen9_whitelist_build(struct i915_wa_list *w)
/* WaAllowUMDToModifyHDCChicken1:skl,bxt,kbl,glk,cfl */
whitelist_reg(w, GEN8_HDC_CHICKEN1);
+
+ /* WaSendPushConstantsFromMMIO:skl,bxt */
+ whitelist_reg(w, COMMON_SLICE_CHICKEN2);
}
static void skl_whitelist_build(struct intel_engine_cs *engine)
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2)
2019-09-11 1:48 [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Kenneth Graunke
@ 2019-09-11 2:34 ` Patchwork
2019-09-11 7:42 ` [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Chris Wilson
2019-09-11 8:35 ` ✓ Fi.CI.IGT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-09-11 2:34 UTC (permalink / raw)
To: Kenneth Graunke; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2)
URL : https://patchwork.freedesktop.org/series/66503/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6863 -> Patchwork_14352
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14352:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_ctx_create@basic-files:
- {fi-tgl-u}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/fi-tgl-u/igt@gem_ctx_create@basic-files.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/fi-tgl-u/igt@gem_ctx_create@basic-files.html
Known issues
------------
Here are the changes found in Patchwork_14352 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@gem_ringfill@basic-default:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/fi-icl-u3/igt@gem_ringfill@basic-default.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/fi-icl-u3/igt@gem_ringfill@basic-default.html
* igt@i915_module_load@reload:
- fi-icl-u3: [PASS][7] -> [DMESG-WARN][8] ([fdo#107724] / [fdo#111214])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/fi-icl-u3/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/fi-icl-u3/igt@i915_module_load@reload.html
#### Possible fixes ####
* igt@gem_basic@create-close:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/fi-icl-u3/igt@gem_basic@create-close.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/fi-icl-u3/igt@gem_basic@create-close.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214
Participating hosts (53 -> 45)
------------------------------
Missing (8): fi-kbl-soraka fi-icl-u4 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6863 -> Patchwork_14352
CI-20190529: 20190529
CI_DRM_6863: 1b26053f51a47b983cbd2e19ea6eb025a12c976b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14352: d4161e469c13387d116cb0fbb03531b63c3b4cba @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d4161e469c13 drm/i915: Whitelist COMMON_SLICE_CHICKEN2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2
2019-09-11 1:48 [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Kenneth Graunke
2019-09-11 2:34 ` ✓ Fi.CI.BAT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
@ 2019-09-11 7:42 ` Chris Wilson
2019-09-11 8:00 ` Chris Wilson
2019-09-11 8:35 ` ✓ Fi.CI.IGT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
2 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2019-09-11 7:42 UTC (permalink / raw)
To: Kenneth Graunke, intel-gfx
Quoting Kenneth Graunke (2019-09-11 02:48:01)
> This allows userspace to use "legacy" mode for push constants, where
> they are committed at 3DPRIMITIVE or flush time, rather than being
> committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11
> both use the "legacy" behavior - only Gen9 works in the "new" way.
>
> Conflating push constants with binding tables is painful for userspace,
> we would like to be able to avoid doing so.
>
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
> Cc: stable@vger.kernel.org
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2
2019-09-11 7:42 ` [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Chris Wilson
@ 2019-09-11 8:00 ` Chris Wilson
2019-09-11 15:22 ` Kenneth Graunke
0 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2019-09-11 8:00 UTC (permalink / raw)
To: Kenneth Graunke, intel-gfx
Quoting Chris Wilson (2019-09-11 08:42:22)
> Quoting Kenneth Graunke (2019-09-11 02:48:01)
> > This allows userspace to use "legacy" mode for push constants, where
> > they are committed at 3DPRIMITIVE or flush time, rather than being
> > committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11
> > both use the "legacy" behavior - only Gen9 works in the "new" way.
> >
> > Conflating push constants with binding tables is painful for userspace,
> > we would like to be able to avoid doing so.
> >
> > Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
> > Cc: stable@vger.kernel.org
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed. Do you also want to do this for icl?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2
2019-09-11 8:00 ` Chris Wilson
@ 2019-09-11 15:22 ` Kenneth Graunke
0 siblings, 0 replies; 8+ messages in thread
From: Kenneth Graunke @ 2019-09-11 15:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 953 bytes --]
On Wednesday, September 11, 2019 1:00:51 AM PDT Chris Wilson wrote:
> Quoting Chris Wilson (2019-09-11 08:42:22)
> > Quoting Kenneth Graunke (2019-09-11 02:48:01)
> > > This allows userspace to use "legacy" mode for push constants, where
> > > they are committed at 3DPRIMITIVE or flush time, rather than being
> > > committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11
> > > both use the "legacy" behavior - only Gen9 works in the "new" way.
> > >
> > > Conflating push constants with binding tables is painful for userspace,
> > > we would like to be able to avoid doing so.
> > >
> > > Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
> > > Cc: stable@vger.kernel.org
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Pushed. Do you also want to do this for icl?
> -Chris
Thanks! I don't think it's necessary for ICL, the bit seems to be gone
and it appears to perform the legacy behavior all the time.
--Ken
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2)
2019-09-11 1:48 [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Kenneth Graunke
2019-09-11 2:34 ` ✓ Fi.CI.BAT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
2019-09-11 7:42 ` [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Chris Wilson
@ 2019-09-11 8:35 ` Patchwork
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-09-11 8:35 UTC (permalink / raw)
To: Kenneth Graunke; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2)
URL : https://patchwork.freedesktop.org/series/66503/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6863_full -> Patchwork_14352_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14352_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276]) +15 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb8/igt@gem_exec_schedule@wide-bsd.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb1/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([fdo#108686])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-glk8/igt@gem_tiled_swapping@non-threaded.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-glk4/igt@gem_tiled_swapping@non-threaded.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_flip@basic-flip-vs-dpms:
- shard-apl: [PASS][9] -> [INCOMPLETE][10] ([fdo#103927]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-apl7/igt@kms_flip@basic-flip-vs-dpms.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-apl3/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_flip@flip-vs-suspend:
- shard-iclb: [PASS][11] -> [INCOMPLETE][12] ([fdo#107713] / [fdo#109507])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb5/igt@kms_flip@flip-vs-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb3/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103167] / [fdo#110378])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [fdo#110403])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103166])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][21] -> [FAIL][22] ([fdo#99912])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-apl7/igt@kms_setmode@basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-apl2/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][23] ([fdo#110841]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_eio@in-flight-suspend:
- shard-skl: [INCOMPLETE][25] ([fdo#104108]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-skl3/igt@gem_eio@in-flight-suspend.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-skl9/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- shard-apl: [INCOMPLETE][27] ([fdo#103927]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-apl4/igt@gem_eio@unwedge-stress.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-apl1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][29] ([fdo#110854]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb6/igt@gem_exec_balancer@smoke.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb4/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_reloc@basic-write-cpu-active:
- shard-skl: [DMESG-WARN][31] ([fdo#106107]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-skl10/igt@gem_exec_reloc@basic-write-cpu-active.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-skl10/igt@gem_exec_reloc@basic-write-cpu-active.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [SKIP][33] ([fdo#111325]) -> [PASS][34] +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb2/igt@gem_exec_schedule@preempt-bsd.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb5/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][35] ([fdo#109276]) -> [PASS][36] +12 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [INCOMPLETE][37] ([fdo#109507]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-skl6/igt@kms_flip@flip-vs-suspend-interruptible.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
- shard-hsw: [INCOMPLETE][39] ([fdo#103540]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-hsw7/igt@kms_flip@flip-vs-suspend-interruptible.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [FAIL][41] ([fdo#103167]) -> [PASS][42] +5 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-snb: [DMESG-WARN][43] ([fdo#102365]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-snb4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-snb1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
- shard-iclb: [INCOMPLETE][45] ([fdo#107713]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb7/igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb3/igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][47] ([fdo#109642] / [fdo#111068]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][49] ([fdo#109441]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][51] ([fdo#99912]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-hsw4/igt@kms_setmode@basic.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-hsw7/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][53] ([fdo#108566]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][55] ([fdo#111329]) -> [SKIP][56] ([fdo#109276])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [SKIP][57] ([fdo#109276]) -> [FAIL][58] ([fdo#111330])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb6/igt@gem_mocs_settings@mocs-reset-bsd2.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [FAIL][59] ([fdo#111330]) -> [SKIP][60] ([fdo#109276])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-iclb2/igt@gem_mocs_settings@mocs-settings-bsd2.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-iclb7/igt@gem_mocs_settings@mocs-settings-bsd2.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [INCOMPLETE][61] ([fdo#103927]) -> [DMESG-WARN][62] ([fdo#108566])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6863/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6863 -> Patchwork_14352
CI-20190529: 20190529
CI_DRM_6863: 1b26053f51a47b983cbd2e19ea6eb025a12c976b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5178: efb4539494d94f03374874d3b61bd04ef3802aaa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14352: d4161e469c13387d116cb0fbb03531b63c3b4cba @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14352/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2
@ 2019-09-10 22:42 Kenneth Graunke
2019-09-11 7:41 ` Chris Wilson
0 siblings, 1 reply; 8+ messages in thread
From: Kenneth Graunke @ 2019-09-10 22:42 UTC (permalink / raw)
To: intel-gfx
This allows userspace to use "legacy" mode for push constants, where
they are committed at 3DPRIMITIVE or flush time, rather than being
committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11
both use the "legacy" behavior - only Gen9 works in the "new" way.
Conflating push constants with binding tables is painful for userspace,
we would like to be able to avoid doing so.
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 243d3f77be13..41d0f786e06d 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1062,6 +1062,9 @@ static void gen9_whitelist_build(struct i915_wa_list *w)
/* WaAllowUMDToModifyHDCChicken1:skl,bxt,kbl,glk,cfl */
whitelist_reg(w, GEN8_HDC_CHICKEN1);
+
+ /* WaSendPushConstantsFromMMIO:skl,bxt */
+ whitelist_reg(w, COMMON_SLICE_CHICKEN2);
}
static void skl_whitelist_build(struct intel_engine_cs *engine)
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2
2019-09-10 22:42 [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Kenneth Graunke
@ 2019-09-11 7:41 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2019-09-11 7:41 UTC (permalink / raw)
To: Kenneth Graunke, intel-gfx
Quoting Kenneth Graunke (2019-09-10 23:42:26)
> This allows userspace to use "legacy" mode for push constants, where
> they are committed at 3DPRIMITIVE or flush time, rather than being
> committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time. Gen6-8 and Gen11
> both use the "legacy" behavior - only Gen9 works in the "new" way.
>
> Conflating push constants with binding tables is painful for userspace,
> we would like to be able to avoid doing so.
>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 243d3f77be13..41d0f786e06d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1062,6 +1062,9 @@ static void gen9_whitelist_build(struct i915_wa_list *w)
>
> /* WaAllowUMDToModifyHDCChicken1:skl,bxt,kbl,glk,cfl */
> whitelist_reg(w, GEN8_HDC_CHICKEN1);
> +
> + /* WaSendPushConstantsFromMMIO:skl,bxt */
> + whitelist_reg(w, COMMON_SLICE_CHICKEN2);
A couple bits in there look like they could do with a validation pass to
make sure they don't kill the machine when incorrectly set. However,
we can raise the bar tomorrow, for now this doesn't look any worse than
any other potential bad bit. Passed our sanity checks that this is
ordinarily a privileged register (i.e. whitelisting is required)
and that it is context saved, so include a s-o-b and
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
(s-o-b required!)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-09-11 15:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 1:48 [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Kenneth Graunke
2019-09-11 2:34 ` ✓ Fi.CI.BAT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
2019-09-11 7:42 ` [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Chris Wilson
2019-09-11 8:00 ` Chris Wilson
2019-09-11 15:22 ` Kenneth Graunke
2019-09-11 8:35 ` ✓ Fi.CI.IGT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-09-10 22:42 [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Kenneth Graunke
2019-09-11 7:41 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.