All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	"Darrick J. Wong" <djwong@kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	Dave Chinner <david@fromorbit.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Eric Sandeen <sandeen@sandeen.net>,
	Christoph Hellwig <hch@lst.de>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Bob Peterson <rpeterso@redhat.com>,
	cluster-devel <cluster-devel@redhat.com>
Subject: Re: [GIT PULL] iomap: new code for 5.4
Date: Thu, 19 Sep 2019 19:07:11 +0200	[thread overview]
Message-ID: <20190919170711.GA9065@lst.de> (raw)
In-Reply-To: <CAHk-=wgFRM=z6WS-QLThxL2T1AaoCQeZSoHzj8ak35uSePQVbA@mail.gmail.com>

On Thu, Sep 19, 2019 at 10:03:30AM -0700, Linus Torvalds wrote:
> It's just that we've survived three decades without that list_pop(),
> and I don't want to make our header files even bigger and more complex
> unless we actually have multiple real users.

I personally surived with it, but really hated writing the open coded
list_for_each_entry + list_del or while list_first_entry_or_null +
┐ist_del when I could have a nice primitive for it.  I finally decided
to just add that helper..

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GIT PULL] iomap: new code for 5.4
Date: Thu, 19 Sep 2019 19:07:11 +0200	[thread overview]
Message-ID: <20190919170711.GA9065@lst.de> (raw)
In-Reply-To: <CAHk-=wgFRM=z6WS-QLThxL2T1AaoCQeZSoHzj8ak35uSePQVbA@mail.gmail.com>

On Thu, Sep 19, 2019 at 10:03:30AM -0700, Linus Torvalds wrote:
> It's just that we've survived three decades without that list_pop(),
> and I don't want to make our header files even bigger and more complex
> unless we actually have multiple real users.

I personally surived with it, but really hated writing the open coded
list_for_each_entry + list_del or while list_first_entry_or_null +
?ist_del when I could have a nice primitive for it.  I finally decided
to just add that helper..



  parent reply	other threads:[~2019-09-19 17:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 15:21 [GIT PULL] iomap: new code for 5.4 Darrick J. Wong
2019-09-17 15:21 ` [Cluster-devel] " Darrick J. Wong
2019-09-19  1:31 ` Linus Torvalds
2019-09-19  1:31   ` [Cluster-devel] " Linus Torvalds
2019-09-19  2:07   ` Linus Torvalds
2019-09-19  2:07     ` [Cluster-devel] " Linus Torvalds
2019-09-19  3:45   ` Darrick J. Wong
2019-09-19  3:45     ` [Cluster-devel] " Darrick J. Wong
2019-09-19 17:03     ` Linus Torvalds
2019-09-19 17:03       ` [Cluster-devel] " Linus Torvalds
2019-09-19 17:04       ` Linus Torvalds
2019-09-19 17:04         ` [Cluster-devel] " Linus Torvalds
2019-09-19 17:07       ` Christoph Hellwig [this message]
2019-09-19 17:07         ` Christoph Hellwig
2019-09-19 17:41         ` Linus Torvalds
2019-09-19 17:41           ` [Cluster-devel] " Linus Torvalds
2019-09-19 17:01   ` Christoph Hellwig
2019-09-19 17:01     ` [Cluster-devel] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919170711.GA9065@lst.de \
    --to=hch@lst.de \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=rpeterso@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.