* [PATCH] gfs2: removed unnecessary semicolon
@ 2019-10-02 17:46 ` aliasgar.surti500
0 siblings, 0 replies; 6+ messages in thread
From: aliasgar.surti500 @ 2019-10-02 17:46 UTC (permalink / raw)
To: rpeterso, agruenba, cluster-devel, linux-kernel; +Cc: Aliasgar Surti
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
There is use of unnecessary semicolon after switch case.
Removed the semicolon.
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
fs/gfs2/recovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
index c529f8749a89..f4aa8551277b 100644
--- a/fs/gfs2/recovery.c
+++ b/fs/gfs2/recovery.c
@@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
default:
goto fail;
- };
+ }
error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] gfs2: removed unnecessary semicolon
@ 2019-10-02 17:46 ` aliasgar.surti500
0 siblings, 0 replies; 6+ messages in thread
From: aliasgar.surti500 @ 2019-10-02 17:46 UTC (permalink / raw)
To: cluster-devel.redhat.com
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
There is use of unnecessary semicolon after switch case.
Removed the semicolon.
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
fs/gfs2/recovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
index c529f8749a89..f4aa8551277b 100644
--- a/fs/gfs2/recovery.c
+++ b/fs/gfs2/recovery.c
@@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
default:
goto fail;
- };
+ }
error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gfs2: removed unnecessary semicolon
2019-10-02 17:46 ` [Cluster-devel] " aliasgar.surti500
@ 2019-10-04 15:49 ` Bob Peterson
-1 siblings, 0 replies; 6+ messages in thread
From: Bob Peterson @ 2019-10-04 15:49 UTC (permalink / raw)
To: aliasgar surti500; +Cc: agruenba, cluster-devel, linux-kernel
----- Original Message -----
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> There is use of unnecessary semicolon after switch case.
> Removed the semicolon.
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
> fs/gfs2/recovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> index c529f8749a89..f4aa8551277b 100644
> --- a/fs/gfs2/recovery.c
> +++ b/fs/gfs2/recovery.c
> @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
>
> default:
> goto fail;
> - };
> + }
>
> error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
> LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
> --
> 2.17.1
Hi,
Thanks for the patch. I did a quick search and found two more:
glops.c- break;
glops.c: };
inode.c- goto out_gunlock;
inode.c: };
Do you want to include those in your patch and re-submit it or
should I cook up a second patch?
Regards,
Bob Peterson
Red Hat File Systems
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] gfs2: removed unnecessary semicolon
@ 2019-10-04 15:49 ` Bob Peterson
0 siblings, 0 replies; 6+ messages in thread
From: Bob Peterson @ 2019-10-04 15:49 UTC (permalink / raw)
To: cluster-devel.redhat.com
----- Original Message -----
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> There is use of unnecessary semicolon after switch case.
> Removed the semicolon.
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---
> fs/gfs2/recovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> index c529f8749a89..f4aa8551277b 100644
> --- a/fs/gfs2/recovery.c
> +++ b/fs/gfs2/recovery.c
> @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
>
> default:
> goto fail;
> - };
> + }
>
> error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
> LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
> --
> 2.17.1
Hi,
Thanks for the patch. I did a quick search and found two more:
glops.c- break;
glops.c: };
inode.c- goto out_gunlock;
inode.c: };
Do you want to include those in your patch and re-submit it or
should I cook up a second patch?
Regards,
Bob Peterson
Red Hat File Systems
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Cluster-devel] [PATCH] gfs2: removed unnecessary semicolon
2019-10-04 15:49 ` [Cluster-devel] " Bob Peterson
@ 2019-10-04 17:22 ` Bob Peterson
-1 siblings, 0 replies; 6+ messages in thread
From: Bob Peterson @ 2019-10-04 17:22 UTC (permalink / raw)
To: aliasgar surti500; +Cc: cluster-devel, linux-kernel
----- Original Message -----
> ----- Original Message -----
> > From: Aliasgar Surti <aliasgar.surti500@gmail.com>
> >
> > There is use of unnecessary semicolon after switch case.
> > Removed the semicolon.
> >
> > Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> > ---
> > fs/gfs2/recovery.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> > index c529f8749a89..f4aa8551277b 100644
> > --- a/fs/gfs2/recovery.c
> > +++ b/fs/gfs2/recovery.c
> > @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
> >
> > default:
> > goto fail;
> > - };
> > + }
> >
> > error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
> > LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
> > --
> > 2.17.1
>
> Hi,
>
> Thanks for the patch. I did a quick search and found two more:
>
> glops.c- break;
> glops.c: };
>
> inode.c- goto out_gunlock;
> inode.c: };
>
> Do you want to include those in your patch and re-submit it or
> should I cook up a second patch?
Hi,
I just went ahead and added the two above to your patch and pushed
it to for-next. Thanks.
Regards,
Bob Peterson
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] gfs2: removed unnecessary semicolon
@ 2019-10-04 17:22 ` Bob Peterson
0 siblings, 0 replies; 6+ messages in thread
From: Bob Peterson @ 2019-10-04 17:22 UTC (permalink / raw)
To: cluster-devel.redhat.com
----- Original Message -----
> ----- Original Message -----
> > From: Aliasgar Surti <aliasgar.surti500@gmail.com>
> >
> > There is use of unnecessary semicolon after switch case.
> > Removed the semicolon.
> >
> > Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> > ---
> > fs/gfs2/recovery.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> > index c529f8749a89..f4aa8551277b 100644
> > --- a/fs/gfs2/recovery.c
> > +++ b/fs/gfs2/recovery.c
> > @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
> >
> > default:
> > goto fail;
> > - };
> > + }
> >
> > error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
> > LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
> > --
> > 2.17.1
>
> Hi,
>
> Thanks for the patch. I did a quick search and found two more:
>
> glops.c- break;
> glops.c: };
>
> inode.c- goto out_gunlock;
> inode.c: };
>
> Do you want to include those in your patch and re-submit it or
> should I cook up a second patch?
Hi,
I just went ahead and added the two above to your patch and pushed
it to for-next. Thanks.
Regards,
Bob Peterson
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-04 17:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 17:46 [PATCH] gfs2: removed unnecessary semicolon aliasgar.surti500
2019-10-02 17:46 ` [Cluster-devel] " aliasgar.surti500
2019-10-04 15:49 ` Bob Peterson
2019-10-04 15:49 ` [Cluster-devel] " Bob Peterson
2019-10-04 17:22 ` Bob Peterson
2019-10-04 17:22 ` Bob Peterson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.