All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michal Suchánek" <msuchanek@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF
Date: Thu, 3 Oct 2019 12:15:58 +0200	[thread overview]
Message-ID: <20191003101558.GG17916@kitsune.suse.cz> (raw)
In-Reply-To: <c0b00292-2529-135d-8282-974684508396@linux.intel.com>

On Wed, Oct 02, 2019 at 11:06:14AM -0500, Pierre-Louis Bossart wrote:
> On 10/2/19 3:33 AM, Michal Suchanek wrote:
> > Now devicetree is supposrted for probing sondwire as well.
> 
> typos...
> 
> also it'd be simpler to squash the two patches together and add in the

Except we have kernels with one or both of the patches these patches
fix.

> commit message a mention that the s390 builds without ACPI and without OF.
Makes sense.

Thanks

Michal
> 
> > 
> > Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> >   drivers/soundwire/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> > index c73bfbaa2659..c8c80df090d1 100644
> > --- a/drivers/soundwire/Kconfig
> > +++ b/drivers/soundwire/Kconfig
> > @@ -5,7 +5,7 @@
> >   menuconfig SOUNDWIRE
> >   	tristate "SoundWire support"
> > -	depends on ACPI
> > +	depends on ACPI || OF
> >   	help
> >   	  SoundWire is a 2-Pin interface with data and clock line ratified
> >   	  by the MIPI Alliance. SoundWire is used for transporting data
> > 
> 

WARNING: multiple messages have this Message-ID (diff)
From: "Michal Suchánek" <msuchanek@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [alsa-devel] [PATCH 2/2] soundwire: depend on ACPI || OF
Date: Thu, 3 Oct 2019 12:15:58 +0200	[thread overview]
Message-ID: <20191003101558.GG17916@kitsune.suse.cz> (raw)
In-Reply-To: <c0b00292-2529-135d-8282-974684508396@linux.intel.com>

On Wed, Oct 02, 2019 at 11:06:14AM -0500, Pierre-Louis Bossart wrote:
> On 10/2/19 3:33 AM, Michal Suchanek wrote:
> > Now devicetree is supposrted for probing sondwire as well.
> 
> typos...
> 
> also it'd be simpler to squash the two patches together and add in the

Except we have kernels with one or both of the patches these patches
fix.

> commit message a mention that the s390 builds without ACPI and without OF.
Makes sense.

Thanks

Michal
> 
> > 
> > Fixes: a2e484585ad3 ("soundwire: core: add device tree support for slave devices")
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> >   drivers/soundwire/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> > index c73bfbaa2659..c8c80df090d1 100644
> > --- a/drivers/soundwire/Kconfig
> > +++ b/drivers/soundwire/Kconfig
> > @@ -5,7 +5,7 @@
> >   menuconfig SOUNDWIRE
> >   	tristate "SoundWire support"
> > -	depends on ACPI
> > +	depends on ACPI || OF
> >   	help
> >   	  SoundWire is a 2-Pin interface with data and clock line ratified
> >   	  by the MIPI Alliance. SoundWire is used for transporting data
> > 
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-10-03 10:16 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 18:52 [PATCH] soundwire: slave: Fix unused function warning on !ACPI Michal Suchanek
2019-08-30 18:52 ` [alsa-devel] " Michal Suchanek
2019-08-30 18:56 ` Randy Dunlap
2019-08-30 18:56   ` [alsa-devel] " Randy Dunlap
2019-09-04  9:30   ` Vinod Koul
2019-09-04  9:30     ` [alsa-devel] " Vinod Koul
2019-09-04 10:48     ` Michal Suchánek
2019-09-04 10:48       ` [alsa-devel] " Michal Suchánek
2019-09-04 11:40       ` Vinod Koul
2019-09-04 11:40         ` [alsa-devel] " Vinod Koul
2019-10-02  8:20         ` Michal Suchánek
2019-10-02  8:20           ` [alsa-devel] " Michal Suchánek
2019-10-02  8:33           ` [PATCH 1/2] soundwire: depend on ACPI Michal Suchanek
2019-10-02  8:33             ` [alsa-devel] " Michal Suchanek
2019-10-02  8:36             ` Greg KH
2019-10-02  8:36               ` [alsa-devel] " Greg KH
2019-10-02  8:33           ` [PATCH 2/2] soundwire: depend on ACPI || OF Michal Suchanek
2019-10-02  8:33             ` [alsa-devel] " Michal Suchanek
2019-10-02  8:36             ` Greg KH
2019-10-02  8:36               ` [alsa-devel] " Greg KH
2019-10-02 16:06             ` Pierre-Louis Bossart
2019-10-02 16:06               ` Pierre-Louis Bossart
2019-10-03 10:15               ` Michal Suchánek [this message]
2019-10-03 10:15                 ` Michal Suchánek
2019-10-03 10:13           ` [PATCH v2 1/2] soundwire: depend on ACPI Michal Suchanek
2019-10-03 10:13             ` [alsa-devel] " Michal Suchanek
2019-10-06 12:07             ` Sasha Levin
2019-10-15 10:45             ` Vinod Koul
2019-10-15 10:45               ` [alsa-devel] " Vinod Koul
2019-10-03 10:13           ` [PATCH v2 2/2] soundwire: depend on ACPI || OF Michal Suchanek
2019-10-03 10:13             ` [alsa-devel] " Michal Suchanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003101558.GG17916@kitsune.suse.cz \
    --to=msuchanek@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.