All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Suchanek <msuchanek@suse.de>
To: alsa-devel@alsa-project.org
Cc: Michal Suchanek <msuchanek@suse.de>,
	Vinod Koul <vkoul@kernel.org>,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] soundwire: depend on ACPI
Date: Wed,  2 Oct 2019 10:33:29 +0200	[thread overview]
Message-ID: <459d62805e8cb20e27667626e80d962569e7e83a.1570005196.git.msuchanek@suse.de> (raw)
In-Reply-To: <20191002081717.GA4015@kitsune.suse.cz>

The device cannot be probed on !ACPI and gives this warning:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index f518273cfbe3..c73bfbaa2659 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0


WARNING: multiple messages have this Message-ID (diff)
From: Michal Suchanek <msuchanek@suse.de>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Vinod Koul <vkoul@kernel.org>,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	Michal Suchanek <msuchanek@suse.de>
Subject: [alsa-devel] [PATCH 1/2] soundwire: depend on ACPI
Date: Wed,  2 Oct 2019 10:33:29 +0200	[thread overview]
Message-ID: <459d62805e8cb20e27667626e80d962569e7e83a.1570005196.git.msuchanek@suse.de> (raw)
In-Reply-To: <20191002081717.GA4015@kitsune.suse.cz>

The device cannot be probed on !ACPI and gives this warning:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index f518273cfbe3..c73bfbaa2659 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data
-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-10-02  8:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 18:52 [PATCH] soundwire: slave: Fix unused function warning on !ACPI Michal Suchanek
2019-08-30 18:52 ` [alsa-devel] " Michal Suchanek
2019-08-30 18:56 ` Randy Dunlap
2019-08-30 18:56   ` [alsa-devel] " Randy Dunlap
2019-09-04  9:30   ` Vinod Koul
2019-09-04  9:30     ` [alsa-devel] " Vinod Koul
2019-09-04 10:48     ` Michal Suchánek
2019-09-04 10:48       ` [alsa-devel] " Michal Suchánek
2019-09-04 11:40       ` Vinod Koul
2019-09-04 11:40         ` [alsa-devel] " Vinod Koul
2019-10-02  8:20         ` Michal Suchánek
2019-10-02  8:20           ` [alsa-devel] " Michal Suchánek
2019-10-02  8:33           ` Michal Suchanek [this message]
2019-10-02  8:33             ` [alsa-devel] [PATCH 1/2] soundwire: depend on ACPI Michal Suchanek
2019-10-02  8:36             ` Greg KH
2019-10-02  8:36               ` [alsa-devel] " Greg KH
2019-10-02  8:33           ` [PATCH 2/2] soundwire: depend on ACPI || OF Michal Suchanek
2019-10-02  8:33             ` [alsa-devel] " Michal Suchanek
2019-10-02  8:36             ` Greg KH
2019-10-02  8:36               ` [alsa-devel] " Greg KH
2019-10-02 16:06             ` Pierre-Louis Bossart
2019-10-02 16:06               ` Pierre-Louis Bossart
2019-10-03 10:15               ` Michal Suchánek
2019-10-03 10:15                 ` Michal Suchánek
2019-10-03 10:13           ` [PATCH v2 1/2] soundwire: depend on ACPI Michal Suchanek
2019-10-03 10:13             ` [alsa-devel] " Michal Suchanek
2019-10-06 12:07             ` Sasha Levin
2019-10-15 10:45             ` Vinod Koul
2019-10-15 10:45               ` [alsa-devel] " Vinod Koul
2019-10-03 10:13           ` [PATCH v2 2/2] soundwire: depend on ACPI || OF Michal Suchanek
2019-10-03 10:13             ` [alsa-devel] " Michal Suchanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=459d62805e8cb20e27667626e80d962569e7e83a.1570005196.git.msuchanek@suse.de \
    --to=msuchanek@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.