From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Claudiu.Beznea@microchip.com
Cc: kamel.bouhara@bootlin.com, wsa@the-dreams.de,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
Ludovic.Desroches@microchip.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
thomas.petazzoni@bootlin.com
Subject: Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery
Date: Fri, 4 Oct 2019 22:39:33 +0200 [thread overview]
Message-ID: <20191004203933.tfhr6cwbsq2hxrov@pengutronix.de> (raw)
In-Reply-To: <08e99a4b-851e-0bee-4c5a-8578b42c283e@microchip.com>
On Fri, Oct 04, 2019 at 09:35:23AM +0000, Claudiu.Beznea@microchip.com wrote:
> Hi Kamel,
>
> On 02.10.2019 17:46, Kamel Bouhara wrote:
> > +static int at91_init_twi_recovery_info(struct platform_device *pdev,
> > + struct at91_twi_dev *dev)
> > +{
> > + struct i2c_bus_recovery_info *rinfo = &dev->rinfo;
> > +
> > + dev->pinctrl = devm_pinctrl_get(&pdev->dev);
> > + if (!dev->pinctrl || IS_ERR(dev->pinctrl)) {
>
> You may use IS_ERR_OR_NULL() here.
Can devm_pinctrl_get return NULL? From a quick look, it cannot.
rule of thumb: IS_ERR_OR_NULL is wrong as it is a sign of poor return
value semantics.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Claudiu.Beznea@microchip.com
Cc: kamel.bouhara@bootlin.com, alexandre.belloni@bootlin.com,
wsa@the-dreams.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com,
linux-i2c@vger.kernel.org, thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery
Date: Fri, 4 Oct 2019 22:39:33 +0200 [thread overview]
Message-ID: <20191004203933.tfhr6cwbsq2hxrov@pengutronix.de> (raw)
In-Reply-To: <08e99a4b-851e-0bee-4c5a-8578b42c283e@microchip.com>
On Fri, Oct 04, 2019 at 09:35:23AM +0000, Claudiu.Beznea@microchip.com wrote:
> Hi Kamel,
>
> On 02.10.2019 17:46, Kamel Bouhara wrote:
> > +static int at91_init_twi_recovery_info(struct platform_device *pdev,
> > + struct at91_twi_dev *dev)
> > +{
> > + struct i2c_bus_recovery_info *rinfo = &dev->rinfo;
> > +
> > + dev->pinctrl = devm_pinctrl_get(&pdev->dev);
> > + if (!dev->pinctrl || IS_ERR(dev->pinctrl)) {
>
> You may use IS_ERR_OR_NULL() here.
Can devm_pinctrl_get return NULL? From a quick look, it cannot.
rule of thumb: IS_ERR_OR_NULL is wrong as it is a sign of poor return
value semantics.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-04 20:39 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 14:46 [PATCH 0/4] i2c bus recovery for Microchip SoCs Kamel Bouhara
2019-10-02 14:46 ` Kamel Bouhara
2019-10-02 14:46 ` [PATCH 1/4] dt-bindings: i2c: at91: document optional bus recovery properties Kamel Bouhara
2019-10-02 14:46 ` Kamel Bouhara
2019-10-02 14:46 ` [PATCH 2/4] i2c: at91: implement i2c bus recovery Kamel Bouhara
2019-10-02 14:46 ` Kamel Bouhara
2019-10-04 9:35 ` Claudiu.Beznea
2019-10-04 9:35 ` Claudiu.Beznea
2019-10-04 9:35 ` Claudiu.Beznea
2019-10-04 20:39 ` Uwe Kleine-König [this message]
2019-10-04 20:39 ` Uwe Kleine-König
2019-10-07 10:17 ` Claudiu.Beznea
2019-10-07 10:17 ` Claudiu.Beznea
2019-10-07 10:17 ` Claudiu.Beznea
2019-10-09 13:55 ` Ludovic Desroches
2019-10-09 13:55 ` Ludovic Desroches
2019-10-09 13:55 ` Ludovic Desroches
2019-10-09 14:01 ` Alexandre Belloni
2019-10-09 14:01 ` Alexandre Belloni
2019-10-10 6:54 ` Ludovic Desroches
2019-10-10 6:54 ` Ludovic Desroches
2019-10-10 6:54 ` Ludovic Desroches
2019-10-24 12:29 ` Kamel Bouhara
2019-10-25 7:04 ` Ludovic.Desroches
2019-10-21 20:20 ` Wolfram Sang
2019-10-21 20:20 ` Wolfram Sang
2019-10-22 7:59 ` Kamel Bouhara
2019-10-24 14:08 ` Codrin.Ciubotariu
2019-10-24 14:08 ` Codrin.Ciubotariu
2019-10-24 14:08 ` Codrin.Ciubotariu
2019-10-24 15:07 ` Wolfram Sang
2019-10-24 15:07 ` Wolfram Sang
2019-10-25 1:14 ` Phil Reid
2019-10-25 1:14 ` Phil Reid
2019-10-25 1:14 ` Phil Reid
2020-08-25 13:28 ` Wolfram Sang
2020-08-25 13:28 ` Wolfram Sang
2020-08-25 23:44 ` Phil Reid
2020-08-25 23:44 ` Phil Reid
2019-10-02 14:46 ` [PATCH 3/4] ARM: at91/dt: sama5d3: add i2c gpio pinctrl Kamel Bouhara
2019-10-02 14:46 ` Kamel Bouhara
2019-10-02 14:46 ` [PATCH 4/4] ARM: at91/dt: sama5d4: " Kamel Bouhara
2019-10-02 14:46 ` Kamel Bouhara
2019-10-15 19:10 ` [PATCH 0/4] i2c bus recovery for Microchip SoCs Rob Herring
2019-10-15 19:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004203933.tfhr6cwbsq2hxrov@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.