From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Kamel Bouhara <kamel.bouhara@bootlin.com>, Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Ferre <nicolas.ferre@microchip.com>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery Date: Wed, 9 Oct 2019 16:01:45 +0200 [thread overview] Message-ID: <20191009140145.GE4254@piout.net> (raw) In-Reply-To: <20191009135500.ufkxcemccwfcfys7@M43218.corp.atmel.com> On 09/10/2019 15:55:00+0200, Ludovic Desroches wrote: > On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > > External E-Mail > > > > > > Implement i2c bus recovery when slaves devices might hold SDA low. > > In this case re-assign SCL/SDA to gpios and issue 9 dummy clock pulses > > until the slave release SDA. > > > > Hi Kamel, > > Thanks for adding this new feature. As I see patches only for sama5d3 and > sama5d4, I assume it has not been tested with a sama5d2, isn't it? > I there a point having it on sama5d2 as the controller already supports this feature? > I doubt it works with a sama5d2 because of the pinctrl. I also wonder if it can > work if we add .strict = true to pinmux_ops which is something plan for the > future... > I don't see why it wouldn't work with strict as this is switching muxing properly instead of using the pins for two functions at the same time. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Kamel Bouhara <kamel.bouhara@bootlin.com>, Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Ferre <nicolas.ferre@microchip.com>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery Date: Wed, 9 Oct 2019 16:01:45 +0200 [thread overview] Message-ID: <20191009140145.GE4254@piout.net> (raw) In-Reply-To: <20191009135500.ufkxcemccwfcfys7@M43218.corp.atmel.com> On 09/10/2019 15:55:00+0200, Ludovic Desroches wrote: > On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > > External E-Mail > > > > > > Implement i2c bus recovery when slaves devices might hold SDA low. > > In this case re-assign SCL/SDA to gpios and issue 9 dummy clock pulses > > until the slave release SDA. > > > > Hi Kamel, > > Thanks for adding this new feature. As I see patches only for sama5d3 and > sama5d4, I assume it has not been tested with a sama5d2, isn't it? > I there a point having it on sama5d2 as the controller already supports this feature? > I doubt it works with a sama5d2 because of the pinctrl. I also wonder if it can > work if we add .strict = true to pinmux_ops which is something plan for the > future... > I don't see why it wouldn't work with strict as this is switching muxing properly instead of using the pins for two functions at the same time. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-09 14:01 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-02 14:46 [PATCH 0/4] i2c bus recovery for Microchip SoCs Kamel Bouhara 2019-10-02 14:46 ` Kamel Bouhara 2019-10-02 14:46 ` [PATCH 1/4] dt-bindings: i2c: at91: document optional bus recovery properties Kamel Bouhara 2019-10-02 14:46 ` Kamel Bouhara 2019-10-02 14:46 ` [PATCH 2/4] i2c: at91: implement i2c bus recovery Kamel Bouhara 2019-10-02 14:46 ` Kamel Bouhara 2019-10-04 9:35 ` Claudiu.Beznea 2019-10-04 9:35 ` Claudiu.Beznea 2019-10-04 9:35 ` Claudiu.Beznea 2019-10-04 20:39 ` Uwe Kleine-König 2019-10-04 20:39 ` Uwe Kleine-König 2019-10-07 10:17 ` Claudiu.Beznea 2019-10-07 10:17 ` Claudiu.Beznea 2019-10-07 10:17 ` Claudiu.Beznea 2019-10-09 13:55 ` Ludovic Desroches 2019-10-09 13:55 ` Ludovic Desroches 2019-10-09 13:55 ` Ludovic Desroches 2019-10-09 14:01 ` Alexandre Belloni [this message] 2019-10-09 14:01 ` Alexandre Belloni 2019-10-10 6:54 ` Ludovic Desroches 2019-10-10 6:54 ` Ludovic Desroches 2019-10-10 6:54 ` Ludovic Desroches 2019-10-24 12:29 ` Kamel Bouhara 2019-10-25 7:04 ` Ludovic.Desroches 2019-10-21 20:20 ` Wolfram Sang 2019-10-21 20:20 ` Wolfram Sang 2019-10-22 7:59 ` Kamel Bouhara 2019-10-24 14:08 ` Codrin.Ciubotariu 2019-10-24 14:08 ` Codrin.Ciubotariu 2019-10-24 14:08 ` Codrin.Ciubotariu 2019-10-24 15:07 ` Wolfram Sang 2019-10-24 15:07 ` Wolfram Sang 2019-10-25 1:14 ` Phil Reid 2019-10-25 1:14 ` Phil Reid 2019-10-25 1:14 ` Phil Reid 2020-08-25 13:28 ` Wolfram Sang 2020-08-25 13:28 ` Wolfram Sang 2020-08-25 23:44 ` Phil Reid 2020-08-25 23:44 ` Phil Reid 2019-10-02 14:46 ` [PATCH 3/4] ARM: at91/dt: sama5d3: add i2c gpio pinctrl Kamel Bouhara 2019-10-02 14:46 ` Kamel Bouhara 2019-10-02 14:46 ` [PATCH 4/4] ARM: at91/dt: sama5d4: " Kamel Bouhara 2019-10-02 14:46 ` Kamel Bouhara 2019-10-15 19:10 ` [PATCH 0/4] i2c bus recovery for Microchip SoCs Rob Herring 2019-10-15 19:10 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191009140145.GE4254@piout.net \ --to=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=kamel.bouhara@bootlin.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=thomas.petazzoni@bootlin.com \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.