All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] thermal: stm32: make stm_thermal_pm_ops static
@ 2019-10-15 14:14 ` Ben Dooks
  0 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2019-10-15 14:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ben Dooks, Zhang Rui, Daniel Lezcano, Amit Kucheria,
	Maxime Coquelin, Alexandre Torgue, linux-pm, linux-stm32,
	linux-arm-kernel, linux-kernel

The stm_thermal_pm_ops struct is not exported to any
other units, so make it static to avoid the following
sparse warning:

drivers/thermal/st/stm_thermal.c:599:1: warning: symbol 'stm_thermal_pm_ops' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Amit Kucheria <amit.kucheria@verdurent.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/thermal/st/stm_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
index cf9ddc52f30e..40bc13c68fba 100644
--- a/drivers/thermal/st/stm_thermal.c
+++ b/drivers/thermal/st/stm_thermal.c
@@ -596,7 +596,7 @@ static int stm_thermal_resume(struct device *dev)
 }
 #endif /* CONFIG_PM_SLEEP */
 
-SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume);
+static SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume);
 
 static const struct thermal_zone_of_device_ops stm_tz_ops = {
 	.get_temp	= stm_thermal_get_temp,
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] thermal: stm32: make stm_thermal_pm_ops static
@ 2019-10-15 14:14 ` Ben Dooks
  0 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2019-10-15 14:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: Amit Kucheria, Alexandre Torgue, linux-pm, Daniel Lezcano,
	linux-kernel, Ben Dooks, Maxime Coquelin, Zhang Rui, linux-stm32,
	linux-arm-kernel

The stm_thermal_pm_ops struct is not exported to any
other units, so make it static to avoid the following
sparse warning:

drivers/thermal/st/stm_thermal.c:599:1: warning: symbol 'stm_thermal_pm_ops' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Amit Kucheria <amit.kucheria@verdurent.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/thermal/st/stm_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
index cf9ddc52f30e..40bc13c68fba 100644
--- a/drivers/thermal/st/stm_thermal.c
+++ b/drivers/thermal/st/stm_thermal.c
@@ -596,7 +596,7 @@ static int stm_thermal_resume(struct device *dev)
 }
 #endif /* CONFIG_PM_SLEEP */
 
-SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume);
+static SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume);
 
 static const struct thermal_zone_of_device_ops stm_tz_ops = {
 	.get_temp	= stm_thermal_get_temp,
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Linux-stm32] [PATCH] thermal: stm32: make stm_thermal_pm_ops static
  2019-10-15 14:14 ` Ben Dooks
@ 2019-10-15 15:12   ` Benjamin GAIGNARD
  -1 siblings, 0 replies; 4+ messages in thread
From: Benjamin GAIGNARD @ 2019-10-15 15:12 UTC (permalink / raw)
  To: Ben Dooks, linux-kernel
  Cc: Amit Kucheria, linux-pm, Daniel Lezcano, linux-kernel,
	Maxime Coquelin, Zhang Rui, linux-stm32, linux-arm-kernel


On 10/15/19 4:14 PM, Ben Dooks wrote:
> The stm_thermal_pm_ops struct is not exported to any
> other units, so make it static to avoid the following
> sparse warning:
>
> drivers/thermal/st/stm_thermal.c:599:1: warning: symbol 'stm_thermal_pm_ops' was not declared. Should it be static?

Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>

Thanks,

Benjamin

>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amit.kucheria@verdurent.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>   drivers/thermal/st/stm_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
> index cf9ddc52f30e..40bc13c68fba 100644
> --- a/drivers/thermal/st/stm_thermal.c
> +++ b/drivers/thermal/st/stm_thermal.c
> @@ -596,7 +596,7 @@ static int stm_thermal_resume(struct device *dev)
>   }
>   #endif /* CONFIG_PM_SLEEP */
>   
> -SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume);
> +static SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume);
>   
>   static const struct thermal_zone_of_device_ops stm_tz_ops = {
>   	.get_temp	= stm_thermal_get_temp,

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Linux-stm32] [PATCH] thermal: stm32: make stm_thermal_pm_ops static
@ 2019-10-15 15:12   ` Benjamin GAIGNARD
  0 siblings, 0 replies; 4+ messages in thread
From: Benjamin GAIGNARD @ 2019-10-15 15:12 UTC (permalink / raw)
  To: Ben Dooks, linux-kernel
  Cc: Amit Kucheria, linux-pm, Daniel Lezcano, linux-kernel,
	Maxime Coquelin, Zhang Rui, linux-stm32, linux-arm-kernel


On 10/15/19 4:14 PM, Ben Dooks wrote:
> The stm_thermal_pm_ops struct is not exported to any
> other units, so make it static to avoid the following
> sparse warning:
>
> drivers/thermal/st/stm_thermal.c:599:1: warning: symbol 'stm_thermal_pm_ops' was not declared. Should it be static?

Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>

Thanks,

Benjamin

>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amit.kucheria@verdurent.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>   drivers/thermal/st/stm_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
> index cf9ddc52f30e..40bc13c68fba 100644
> --- a/drivers/thermal/st/stm_thermal.c
> +++ b/drivers/thermal/st/stm_thermal.c
> @@ -596,7 +596,7 @@ static int stm_thermal_resume(struct device *dev)
>   }
>   #endif /* CONFIG_PM_SLEEP */
>   
> -SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume);
> +static SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume);
>   
>   static const struct thermal_zone_of_device_ops stm_tz_ops = {
>   	.get_temp	= stm_thermal_get_temp,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-15 15:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 14:14 [PATCH] thermal: stm32: make stm_thermal_pm_ops static Ben Dooks
2019-10-15 14:14 ` Ben Dooks
2019-10-15 15:12 ` [Linux-stm32] " Benjamin GAIGNARD
2019-10-15 15:12   ` Benjamin GAIGNARD

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.