From: kbuild test robot <lkp@intel.com> To: Alexandru Ardelean <alexandru.ardelean@analog.com> Cc: kbuild-all@lists.01.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, Lars-Peter Clausen <lars@metafoo.de>, Alexandru Ardelean <alexandru.ardelean@analog.com> Subject: Re: [PATCH][RESEND] input: adp5589: Make keypad support optional Date: Fri, 25 Oct 2019 04:30:21 +0800 [thread overview] Message-ID: <201910250404.cAvRQgmk%lkp@intel.com> (raw) In-Reply-To: <20191023070541.13940-1-alexandru.ardelean@analog.com> [-- Attachment #1: Type: text/plain, Size: 3546 bytes --] Hi Alexandru, I love your patch! Perhaps something to improve: [auto build test WARNING on input/next] [cannot apply to v5.4-rc4 next-20191024] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Alexandru-Ardelean/input-adp5589-Make-keypad-support-optional/20191025-034654 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: mips-allmodconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_probe': >> drivers/input/keyboard/adp5589-keys.c:1019:22: warning: this statement may fall through [-Wimplicit-fallthrough=] kpad->support_row5 = true; ~~~~~~~~~~~~~~~~~~~^~~~~~ drivers/input/keyboard/adp5589-keys.c:1020:2: note: here case ADP5585_01: ^~~~ vim +1019 drivers/input/keyboard/adp5589-keys.c 994 995 static int adp5589_probe(struct i2c_client *client, 996 const struct i2c_device_id *id) 997 { 998 struct adp5589_kpad *kpad; 999 const struct adp5589_kpad_platform_data *pdata = 1000 dev_get_platdata(&client->dev); 1001 unsigned int revid; 1002 int error, ret; 1003 1004 if (!i2c_check_functionality(client->adapter, 1005 I2C_FUNC_SMBUS_BYTE_DATA)) { 1006 dev_err(&client->dev, "SMBUS Byte Data not Supported\n"); 1007 return -EIO; 1008 } 1009 1010 1011 kpad = kzalloc(sizeof(*kpad), GFP_KERNEL); 1012 if (!kpad) 1013 return -ENOMEM; 1014 1015 kpad->client = client; 1016 1017 switch (id->driver_data) { 1018 case ADP5585_02: > 1019 kpad->support_row5 = true; 1020 case ADP5585_01: 1021 kpad->is_adp5585 = true; 1022 kpad->var = &const_adp5585; 1023 break; 1024 case ADP5589: 1025 kpad->support_row5 = true; 1026 kpad->var = &const_adp5589; 1027 break; 1028 } 1029 1030 ret = adp5589_read(client, ADP5589_5_ID); 1031 if (ret < 0) { 1032 error = ret; 1033 goto err_free_mem; 1034 } 1035 1036 revid = (u8) ret & ADP5589_5_DEVICE_ID_MASK; 1037 1038 error = adp5589_keypad_add(kpad, revid, pdata); 1039 if (error) 1040 goto err_free_mem; 1041 1042 error = adp5589_setup(kpad, pdata); 1043 if (error) 1044 goto err_keypad_remove; 1045 1046 if (kpad->gpimapsize) 1047 adp5589_report_switch_state(kpad); 1048 1049 error = adp5589_gpio_add(kpad, pdata); 1050 if (error) 1051 goto err_keypad_remove; 1052 1053 i2c_set_clientdata(client, kpad); 1054 1055 dev_info(&client->dev, "Rev.%d keypad, irq %d\n", revid, client->irq); 1056 return 0; 1057 1058 err_keypad_remove: 1059 adp5589_keypad_remove(kpad, pdata); 1060 err_free_mem: 1061 kfree(kpad); 1062 1063 return error; 1064 } 1065 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 61527 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH][RESEND] input: adp5589: Make keypad support optional Date: Fri, 25 Oct 2019 04:30:21 +0800 [thread overview] Message-ID: <201910250404.cAvRQgmk%lkp@intel.com> (raw) In-Reply-To: <20191023070541.13940-1-alexandru.ardelean@analog.com> [-- Attachment #1: Type: text/plain, Size: 3657 bytes --] Hi Alexandru, I love your patch! Perhaps something to improve: [auto build test WARNING on input/next] [cannot apply to v5.4-rc4 next-20191024] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Alexandru-Ardelean/input-adp5589-Make-keypad-support-optional/20191025-034654 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: mips-allmodconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_probe': >> drivers/input/keyboard/adp5589-keys.c:1019:22: warning: this statement may fall through [-Wimplicit-fallthrough=] kpad->support_row5 = true; ~~~~~~~~~~~~~~~~~~~^~~~~~ drivers/input/keyboard/adp5589-keys.c:1020:2: note: here case ADP5585_01: ^~~~ vim +1019 drivers/input/keyboard/adp5589-keys.c 994 995 static int adp5589_probe(struct i2c_client *client, 996 const struct i2c_device_id *id) 997 { 998 struct adp5589_kpad *kpad; 999 const struct adp5589_kpad_platform_data *pdata = 1000 dev_get_platdata(&client->dev); 1001 unsigned int revid; 1002 int error, ret; 1003 1004 if (!i2c_check_functionality(client->adapter, 1005 I2C_FUNC_SMBUS_BYTE_DATA)) { 1006 dev_err(&client->dev, "SMBUS Byte Data not Supported\n"); 1007 return -EIO; 1008 } 1009 1010 1011 kpad = kzalloc(sizeof(*kpad), GFP_KERNEL); 1012 if (!kpad) 1013 return -ENOMEM; 1014 1015 kpad->client = client; 1016 1017 switch (id->driver_data) { 1018 case ADP5585_02: > 1019 kpad->support_row5 = true; 1020 case ADP5585_01: 1021 kpad->is_adp5585 = true; 1022 kpad->var = &const_adp5585; 1023 break; 1024 case ADP5589: 1025 kpad->support_row5 = true; 1026 kpad->var = &const_adp5589; 1027 break; 1028 } 1029 1030 ret = adp5589_read(client, ADP5589_5_ID); 1031 if (ret < 0) { 1032 error = ret; 1033 goto err_free_mem; 1034 } 1035 1036 revid = (u8) ret & ADP5589_5_DEVICE_ID_MASK; 1037 1038 error = adp5589_keypad_add(kpad, revid, pdata); 1039 if (error) 1040 goto err_free_mem; 1041 1042 error = adp5589_setup(kpad, pdata); 1043 if (error) 1044 goto err_keypad_remove; 1045 1046 if (kpad->gpimapsize) 1047 adp5589_report_switch_state(kpad); 1048 1049 error = adp5589_gpio_add(kpad, pdata); 1050 if (error) 1051 goto err_keypad_remove; 1052 1053 i2c_set_clientdata(client, kpad); 1054 1055 dev_info(&client->dev, "Rev.%d keypad, irq %d\n", revid, client->irq); 1056 return 0; 1057 1058 err_keypad_remove: 1059 adp5589_keypad_remove(kpad, pdata); 1060 err_free_mem: 1061 kfree(kpad); 1062 1063 return error; 1064 } 1065 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 61527 bytes --]
next prev parent reply other threads:[~2019-10-24 20:31 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20190717122133.24333-1-alexandru.ardelean@analog.com> 2019-09-27 12:38 ` [PATCH][RESEND] input: adp5589: Make keypad support optional Alexandru Ardelean 2019-09-27 12:38 ` Alexandru Ardelean 2019-10-23 7:05 ` Alexandru Ardelean 2019-10-23 22:59 ` Dmitry Torokhov 2019-10-24 9:24 ` Ardelean, Alexandru 2019-10-24 20:30 ` kbuild test robot [this message] 2019-10-24 20:30 ` kbuild test robot 2019-10-25 0:50 ` kbuild test robot 2019-10-25 0:50 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201910250404.cAvRQgmk%lkp@intel.com \ --to=lkp@intel.com \ --cc=alexandru.ardelean@analog.com \ --cc=dmitry.torokhov@gmail.com \ --cc=kbuild-all@lists.01.org \ --cc=lars@metafoo.de \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.