From: kbuild test robot <lkp@intel.com> To: Alexandru Ardelean <alexandru.ardelean@analog.com> Cc: kbuild-all@lists.01.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, Lars-Peter Clausen <lars@metafoo.de>, Alexandru Ardelean <alexandru.ardelean@analog.com> Subject: Re: [PATCH][RESEND] input: adp5589: Make keypad support optional Date: Fri, 25 Oct 2019 08:50:27 +0800 [thread overview] Message-ID: <201910250833.IlbJgJPZ%lkp@intel.com> (raw) In-Reply-To: <20191023070541.13940-1-alexandru.ardelean@analog.com> [-- Attachment #1: Type: text/plain, Size: 3541 bytes --] Hi Alexandru, I love your patch! Yet something to improve: [auto build test ERROR on input/next] [also build test ERROR on v5.4-rc4] [cannot apply to next-20191024] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Alexandru-Ardelean/input-adp5589-Make-keypad-support-optional/20191025-034654 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: x86_64-kexec (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/input/keyboard/adp5589-keys.c:575:9: error: expected '{' before 'const' struct const adp5589_kpad_platform_data *pdata) ^~~~~ drivers/input/keyboard/adp5589-keys.c:581:9: error: expected '{' before 'const' struct const adp5589_kpad_platform_data *pdata) ^~~~~ drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_probe': >> drivers/input/keyboard/adp5589-keys.c:1049:10: error: implicit declaration of function 'adp5589_gpio_add'; did you mean 'adp5589_keypad_add'? [-Werror=implicit-function-declaration] error = adp5589_gpio_add(kpad, pdata); ^~~~~~~~~~~~~~~~ adp5589_keypad_add drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_remove': >> drivers/input/keyboard/adp5589-keys.c:1074:2: error: implicit declaration of function 'adp5589_gpio_remove'; did you mean 'adp5589_remove'? [-Werror=implicit-function-declaration] adp5589_gpio_remove(kpad, pdata); ^~~~~~~~~~~~~~~~~~~ adp5589_remove drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_probe': drivers/input/keyboard/adp5589-keys.c:1019:22: warning: this statement may fall through [-Wimplicit-fallthrough=] kpad->support_row5 = true; ~~~~~~~~~~~~~~~~~~~^~~~~~ drivers/input/keyboard/adp5589-keys.c:1020:2: note: here case ADP5585_01: ^~~~ cc1: some warnings being treated as errors vim +575 drivers/input/keyboard/adp5589-keys.c 552 553 static void adp5589_gpio_remove(struct adp5589_kpad *kpad, 554 const struct adp5589_kpad_platform_data *pdata) 555 { 556 struct device *dev = &kpad->client->dev; 557 const struct adp5589_gpio_platform_data *gpio_data = pdata->gpio_data; 558 int error; 559 560 if (!kpad->export_gpio) 561 return; 562 563 if (gpio_data->teardown) { 564 error = gpio_data->teardown(kpad->client, 565 kpad->gc.base, kpad->gc.ngpio, 566 gpio_data->context); 567 if (error) 568 dev_warn(dev, "teardown failed %d\n", error); 569 } 570 571 gpiochip_remove(&kpad->gc); 572 } 573 #else 574 static inline int adp5589_gpio_add(struct adp5589_kpad *kpad, > 575 struct const adp5589_kpad_platform_data *pdata) 576 { 577 return 0; 578 } 579 580 static inline void adp5589_gpio_remove(struct adp5589_kpad *kpad, > 581 struct const adp5589_kpad_platform_data *pdata) 582 { 583 } 584 #endif 585 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 27445 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH][RESEND] input: adp5589: Make keypad support optional Date: Fri, 25 Oct 2019 08:50:27 +0800 [thread overview] Message-ID: <201910250833.IlbJgJPZ%lkp@intel.com> (raw) In-Reply-To: <20191023070541.13940-1-alexandru.ardelean@analog.com> [-- Attachment #1: Type: text/plain, Size: 3630 bytes --] Hi Alexandru, I love your patch! Yet something to improve: [auto build test ERROR on input/next] [also build test ERROR on v5.4-rc4] [cannot apply to next-20191024] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Alexandru-Ardelean/input-adp5589-Make-keypad-support-optional/20191025-034654 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: x86_64-kexec (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/input/keyboard/adp5589-keys.c:575:9: error: expected '{' before 'const' struct const adp5589_kpad_platform_data *pdata) ^~~~~ drivers/input/keyboard/adp5589-keys.c:581:9: error: expected '{' before 'const' struct const adp5589_kpad_platform_data *pdata) ^~~~~ drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_probe': >> drivers/input/keyboard/adp5589-keys.c:1049:10: error: implicit declaration of function 'adp5589_gpio_add'; did you mean 'adp5589_keypad_add'? [-Werror=implicit-function-declaration] error = adp5589_gpio_add(kpad, pdata); ^~~~~~~~~~~~~~~~ adp5589_keypad_add drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_remove': >> drivers/input/keyboard/adp5589-keys.c:1074:2: error: implicit declaration of function 'adp5589_gpio_remove'; did you mean 'adp5589_remove'? [-Werror=implicit-function-declaration] adp5589_gpio_remove(kpad, pdata); ^~~~~~~~~~~~~~~~~~~ adp5589_remove drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_probe': drivers/input/keyboard/adp5589-keys.c:1019:22: warning: this statement may fall through [-Wimplicit-fallthrough=] kpad->support_row5 = true; ~~~~~~~~~~~~~~~~~~~^~~~~~ drivers/input/keyboard/adp5589-keys.c:1020:2: note: here case ADP5585_01: ^~~~ cc1: some warnings being treated as errors vim +575 drivers/input/keyboard/adp5589-keys.c 552 553 static void adp5589_gpio_remove(struct adp5589_kpad *kpad, 554 const struct adp5589_kpad_platform_data *pdata) 555 { 556 struct device *dev = &kpad->client->dev; 557 const struct adp5589_gpio_platform_data *gpio_data = pdata->gpio_data; 558 int error; 559 560 if (!kpad->export_gpio) 561 return; 562 563 if (gpio_data->teardown) { 564 error = gpio_data->teardown(kpad->client, 565 kpad->gc.base, kpad->gc.ngpio, 566 gpio_data->context); 567 if (error) 568 dev_warn(dev, "teardown failed %d\n", error); 569 } 570 571 gpiochip_remove(&kpad->gc); 572 } 573 #else 574 static inline int adp5589_gpio_add(struct adp5589_kpad *kpad, > 575 struct const adp5589_kpad_platform_data *pdata) 576 { 577 return 0; 578 } 579 580 static inline void adp5589_gpio_remove(struct adp5589_kpad *kpad, > 581 struct const adp5589_kpad_platform_data *pdata) 582 { 583 } 584 #endif 585 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 27445 bytes --]
next prev parent reply other threads:[~2019-10-25 0:50 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20190717122133.24333-1-alexandru.ardelean@analog.com> 2019-09-27 12:38 ` [PATCH][RESEND] input: adp5589: Make keypad support optional Alexandru Ardelean 2019-09-27 12:38 ` Alexandru Ardelean 2019-10-23 7:05 ` Alexandru Ardelean 2019-10-23 22:59 ` Dmitry Torokhov 2019-10-24 9:24 ` Ardelean, Alexandru 2019-10-24 20:30 ` kbuild test robot 2019-10-24 20:30 ` kbuild test robot 2019-10-25 0:50 ` kbuild test robot [this message] 2019-10-25 0:50 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201910250833.IlbJgJPZ%lkp@intel.com \ --to=lkp@intel.com \ --cc=alexandru.ardelean@analog.com \ --cc=dmitry.torokhov@gmail.com \ --cc=kbuild-all@lists.01.org \ --cc=lars@metafoo.de \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.