From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: mchehab@kernel.org, robh+dt@kernel.org, sakari.ailus@iki.fi, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org Subject: Re: [PATCH v4 0/2] Add IMX296 CMOS image sensor support Date: Thu, 31 Oct 2019 18:53:52 +0530 [thread overview] Message-ID: <20191031132352.GA24273@mani> (raw) In-Reply-To: <20191031131644.GA8917@pendragon.ideasonboard.com> Hi Laurent, On Thu, Oct 31, 2019 at 03:16:44PM +0200, Laurent Pinchart wrote: > Hi Mani, > > Thank you for the patches. > > On Wed, Oct 30, 2019 at 03:19:00PM +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This patchset adds support for IMX296 CMOS image sensor from Sony. > > Sensor can be programmed through I2C and 4-wire interface but the > > current driver only supports I2C interface. The sensor is > > capable of outputting frames in CSI2 format (1 Lane). In the case > > of sensor resolution, driver only supports 1440x1088 at 30 FPS. > > > > The driver has been validated using Framos IMX296 module interfaced to > > 96Boards Dragonboard410c. > > I've just been made aware of your work. I also worked on an IMX296 > sensor driver in parallel, which I will post to the list. My driver > doesn't hardcode the resolution but computes register values at runtime, > so I wonder if it could be a better option. I'll post it now. > I'm fine with it. The reason the driver is simple in the first place is, that's how my usual workflow is. Start small and build it big ;-) Anyway, I'm happy if your driver gets in. Thanks, Mani > > Changes in v4: > > > > * Fixed issues related to gain settings and few misc cleanups in driver > > * Documented port node and removed maxItems, default prop from dt binding > > as per the review > > > > Changes in v3: > > > > * Fixed the reference to video-interfaces.txt in binding. > > > > Changes in v2: > > > > * Switched to YAML binding > > > > Manivannan Sadhasivam (2): > > dt-bindings: media: i2c: Add IMX296 CMOS sensor binding > > media: i2c: Add IMX296 CMOS image sensor driver > > > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++ > > MAINTAINERS | 8 + > > drivers/media/i2c/Kconfig | 11 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/imx296.c | 715 ++++++++++++++++++ > > 5 files changed, 829 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > create mode 100644 drivers/media/i2c/imx296.c > > -- > Regards, > > Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: devicetree@vger.kernel.org, c.barrett@framos.com, linux-kernel@vger.kernel.org, a.brela@framos.com, peter.griffin@linaro.org, robh+dt@kernel.org, sakari.ailus@iki.fi, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH v4 0/2] Add IMX296 CMOS image sensor support Date: Thu, 31 Oct 2019 18:53:52 +0530 [thread overview] Message-ID: <20191031132352.GA24273@mani> (raw) In-Reply-To: <20191031131644.GA8917@pendragon.ideasonboard.com> Hi Laurent, On Thu, Oct 31, 2019 at 03:16:44PM +0200, Laurent Pinchart wrote: > Hi Mani, > > Thank you for the patches. > > On Wed, Oct 30, 2019 at 03:19:00PM +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This patchset adds support for IMX296 CMOS image sensor from Sony. > > Sensor can be programmed through I2C and 4-wire interface but the > > current driver only supports I2C interface. The sensor is > > capable of outputting frames in CSI2 format (1 Lane). In the case > > of sensor resolution, driver only supports 1440x1088 at 30 FPS. > > > > The driver has been validated using Framos IMX296 module interfaced to > > 96Boards Dragonboard410c. > > I've just been made aware of your work. I also worked on an IMX296 > sensor driver in parallel, which I will post to the list. My driver > doesn't hardcode the resolution but computes register values at runtime, > so I wonder if it could be a better option. I'll post it now. > I'm fine with it. The reason the driver is simple in the first place is, that's how my usual workflow is. Start small and build it big ;-) Anyway, I'm happy if your driver gets in. Thanks, Mani > > Changes in v4: > > > > * Fixed issues related to gain settings and few misc cleanups in driver > > * Documented port node and removed maxItems, default prop from dt binding > > as per the review > > > > Changes in v3: > > > > * Fixed the reference to video-interfaces.txt in binding. > > > > Changes in v2: > > > > * Switched to YAML binding > > > > Manivannan Sadhasivam (2): > > dt-bindings: media: i2c: Add IMX296 CMOS sensor binding > > media: i2c: Add IMX296 CMOS image sensor driver > > > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++ > > MAINTAINERS | 8 + > > drivers/media/i2c/Kconfig | 11 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/imx296.c | 715 ++++++++++++++++++ > > 5 files changed, 829 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > create mode 100644 drivers/media/i2c/imx296.c > > -- > Regards, > > Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-31 13:24 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-30 9:49 [PATCH v4 0/2] Add IMX296 CMOS image sensor support Manivannan Sadhasivam 2019-10-30 9:49 ` Manivannan Sadhasivam 2019-10-30 9:49 ` [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Manivannan Sadhasivam 2019-10-30 9:49 ` Manivannan Sadhasivam 2019-10-30 11:53 ` Sakari Ailus 2019-10-30 11:53 ` Sakari Ailus 2019-10-30 12:01 ` Manivannan Sadhasivam 2019-10-30 12:01 ` Manivannan Sadhasivam 2019-11-05 1:43 ` Rob Herring 2019-11-05 1:43 ` Rob Herring 2019-10-31 13:15 ` Laurent Pinchart 2019-10-31 13:15 ` Laurent Pinchart 2019-10-31 13:45 ` Manivannan Sadhasivam 2019-10-31 13:45 ` Manivannan Sadhasivam 2019-10-31 14:11 ` Laurent Pinchart 2019-10-31 14:11 ` Laurent Pinchart 2019-10-31 14:28 ` Sakari Ailus 2019-10-31 14:28 ` Sakari Ailus 2019-10-31 16:54 ` Laurent Pinchart 2019-10-31 16:54 ` Laurent Pinchart 2019-10-31 17:08 ` Sakari Ailus 2019-10-31 17:08 ` Sakari Ailus 2019-11-04 19:02 ` Laurent Pinchart 2019-11-04 19:02 ` Laurent Pinchart 2019-11-04 21:30 ` Sakari Ailus 2019-11-04 21:30 ` Sakari Ailus 2019-11-04 22:00 ` Laurent Pinchart 2019-11-04 22:00 ` Laurent Pinchart 2019-10-31 14:58 ` Manivannan Sadhasivam 2019-10-31 14:58 ` Manivannan Sadhasivam 2019-10-30 9:49 ` [PATCH v4 2/2] media: i2c: Add IMX296 CMOS image sensor driver Manivannan Sadhasivam 2019-10-30 9:49 ` Manivannan Sadhasivam 2019-10-31 13:16 ` [PATCH v4 0/2] Add IMX296 CMOS image sensor support Laurent Pinchart 2019-10-31 13:16 ` Laurent Pinchart 2019-10-31 13:23 ` Manivannan Sadhasivam [this message] 2019-10-31 13:23 ` Manivannan Sadhasivam 2019-10-31 13:28 ` Laurent Pinchart 2019-10-31 13:28 ` Laurent Pinchart 2019-10-31 15:48 ` Sakari Ailus 2019-10-31 15:48 ` Sakari Ailus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191031132352.GA24273@mani \ --to=manivannan.sadhasivam@linaro.org \ --cc=a.brela@framos.com \ --cc=c.barrett@framos.com \ --cc=devicetree@vger.kernel.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=peter.griffin@linaro.org \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.