From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, c.barrett@framos.com,
a.brela@framos.com, peter.griffin@linaro.org
Subject: Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding
Date: Mon, 4 Nov 2019 19:43:53 -0600 [thread overview]
Message-ID: <20191105014353.GA841@bogus> (raw)
In-Reply-To: <20191030120105.GA11432@Mani-XPS-13-9360>
On Wed, Oct 30, 2019 at 05:31:05PM +0530, Manivannan Sadhasivam wrote:
> Hi Sakari,
>
> On Wed, Oct 30, 2019 at 01:53:28PM +0200, Sakari Ailus wrote:
> > Hi Nabuvannan,
> >
> > On Wed, Oct 30, 2019 at 03:19:01PM +0530, Manivannan Sadhasivam wrote:
> > > Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also
> > > add MAINTAINERS entry for the binding and driver.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++++++++++++++++++
> > > MAINTAINERS | 8 ++
> > > 2 files changed, 102 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx296.yaml b/Documentation/devicetree/bindings/media/i2c/imx296.yaml
> > > new file mode 100644
> > > index 000000000000..c04ec2203268
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/i2c/imx296.yaml
> > > @@ -0,0 +1,94 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/i2c/imx296.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor
> > > +
> > > +maintainers:
> > > + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > +
> > > +description: |-
> > > + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image
> > > + sensor with square pixel array and 1.58 M effective pixels. This chip
> > > + features a global shutter with variable charge-integration time. It is
> > > + programmable through I2C and 4-wire interfaces. The sensor output is
> > > + available via CSI-2 serial data output (1 Lane).
> > > +
> > > +properties:
> > > + compatible:
> > > + const: sony,imx296
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + clocks:
> > > + maxItems: 1
> > > +
> > > + clock-names:
> > > + description:
> > > + Input clock for the sensor.
> > > + items:
> > > + - const: mclk
> > > +
> > > + clock-frequency:
> > > + description:
> > > + Frequency of the mclk clock in Hertz.
> > > +
> > > + vddo-supply:
> > > + description:
> > > + Definition of the regulator used as interface power supply.
> > > +
> > > + vdda-supply:
> > > + description:
> > > + Definition of the regulator used as analog power supply.
> > > +
> > > + vddd-supply:
> > > + description:
> > > + Definition of the regulator used as digital power supply.
> > > +
> > > + reset-gpios:
> > > + description:
> > > + The phandle and specifier for the GPIO that controls sensor reset.
> > > + maxItems: 1
> > > +
> > > + port: true
> >
> > You're missing "type: object" under port.
> >
>
> I did that intentionally, since there are other places where I can see the
> "type" field not specified. So, I was not sure about that. Most of the
> display bindings don't specify "type" and they are most available ones.
> I don't think the "port" property differs between cameras and displays.
> So I went with that.
The difference is the panel bindings have a common schema included
which defines 'port' at least as a node. I don't think an include would
help too much here, so probably best to add 'type: object' for now.
Either way, this may change once video-interfaces.txt is converted if
any of those properties apply here.
Either way:
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: devicetree@vger.kernel.org, c.barrett@framos.com,
linux-kernel@vger.kernel.org, a.brela@framos.com,
peter.griffin@linaro.org, Sakari Ailus <sakari.ailus@iki.fi>,
mchehab@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding
Date: Mon, 4 Nov 2019 19:43:53 -0600 [thread overview]
Message-ID: <20191105014353.GA841@bogus> (raw)
In-Reply-To: <20191030120105.GA11432@Mani-XPS-13-9360>
On Wed, Oct 30, 2019 at 05:31:05PM +0530, Manivannan Sadhasivam wrote:
> Hi Sakari,
>
> On Wed, Oct 30, 2019 at 01:53:28PM +0200, Sakari Ailus wrote:
> > Hi Nabuvannan,
> >
> > On Wed, Oct 30, 2019 at 03:19:01PM +0530, Manivannan Sadhasivam wrote:
> > > Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also
> > > add MAINTAINERS entry for the binding and driver.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > > .../devicetree/bindings/media/i2c/imx296.yaml | 94 +++++++++++++++++++
> > > MAINTAINERS | 8 ++
> > > 2 files changed, 102 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx296.yaml b/Documentation/devicetree/bindings/media/i2c/imx296.yaml
> > > new file mode 100644
> > > index 000000000000..c04ec2203268
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/i2c/imx296.yaml
> > > @@ -0,0 +1,94 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/i2c/imx296.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor
> > > +
> > > +maintainers:
> > > + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > +
> > > +description: |-
> > > + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image
> > > + sensor with square pixel array and 1.58 M effective pixels. This chip
> > > + features a global shutter with variable charge-integration time. It is
> > > + programmable through I2C and 4-wire interfaces. The sensor output is
> > > + available via CSI-2 serial data output (1 Lane).
> > > +
> > > +properties:
> > > + compatible:
> > > + const: sony,imx296
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + clocks:
> > > + maxItems: 1
> > > +
> > > + clock-names:
> > > + description:
> > > + Input clock for the sensor.
> > > + items:
> > > + - const: mclk
> > > +
> > > + clock-frequency:
> > > + description:
> > > + Frequency of the mclk clock in Hertz.
> > > +
> > > + vddo-supply:
> > > + description:
> > > + Definition of the regulator used as interface power supply.
> > > +
> > > + vdda-supply:
> > > + description:
> > > + Definition of the regulator used as analog power supply.
> > > +
> > > + vddd-supply:
> > > + description:
> > > + Definition of the regulator used as digital power supply.
> > > +
> > > + reset-gpios:
> > > + description:
> > > + The phandle and specifier for the GPIO that controls sensor reset.
> > > + maxItems: 1
> > > +
> > > + port: true
> >
> > You're missing "type: object" under port.
> >
>
> I did that intentionally, since there are other places where I can see the
> "type" field not specified. So, I was not sure about that. Most of the
> display bindings don't specify "type" and they are most available ones.
> I don't think the "port" property differs between cameras and displays.
> So I went with that.
The difference is the panel bindings have a common schema included
which defines 'port' at least as a node. I don't think an include would
help too much here, so probably best to add 'type: object' for now.
Either way, this may change once video-interfaces.txt is converted if
any of those properties apply here.
Either way:
Reviewed-by: Rob Herring <robh@kernel.org>
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-05 1:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 9:49 [PATCH v4 0/2] Add IMX296 CMOS image sensor support Manivannan Sadhasivam
2019-10-30 9:49 ` Manivannan Sadhasivam
2019-10-30 9:49 ` [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Manivannan Sadhasivam
2019-10-30 9:49 ` Manivannan Sadhasivam
2019-10-30 11:53 ` Sakari Ailus
2019-10-30 11:53 ` Sakari Ailus
2019-10-30 12:01 ` Manivannan Sadhasivam
2019-10-30 12:01 ` Manivannan Sadhasivam
2019-11-05 1:43 ` Rob Herring [this message]
2019-11-05 1:43 ` Rob Herring
2019-10-31 13:15 ` Laurent Pinchart
2019-10-31 13:15 ` Laurent Pinchart
2019-10-31 13:45 ` Manivannan Sadhasivam
2019-10-31 13:45 ` Manivannan Sadhasivam
2019-10-31 14:11 ` Laurent Pinchart
2019-10-31 14:11 ` Laurent Pinchart
2019-10-31 14:28 ` Sakari Ailus
2019-10-31 14:28 ` Sakari Ailus
2019-10-31 16:54 ` Laurent Pinchart
2019-10-31 16:54 ` Laurent Pinchart
2019-10-31 17:08 ` Sakari Ailus
2019-10-31 17:08 ` Sakari Ailus
2019-11-04 19:02 ` Laurent Pinchart
2019-11-04 19:02 ` Laurent Pinchart
2019-11-04 21:30 ` Sakari Ailus
2019-11-04 21:30 ` Sakari Ailus
2019-11-04 22:00 ` Laurent Pinchart
2019-11-04 22:00 ` Laurent Pinchart
2019-10-31 14:58 ` Manivannan Sadhasivam
2019-10-31 14:58 ` Manivannan Sadhasivam
2019-10-30 9:49 ` [PATCH v4 2/2] media: i2c: Add IMX296 CMOS image sensor driver Manivannan Sadhasivam
2019-10-30 9:49 ` Manivannan Sadhasivam
2019-10-31 13:16 ` [PATCH v4 0/2] Add IMX296 CMOS image sensor support Laurent Pinchart
2019-10-31 13:16 ` Laurent Pinchart
2019-10-31 13:23 ` Manivannan Sadhasivam
2019-10-31 13:23 ` Manivannan Sadhasivam
2019-10-31 13:28 ` Laurent Pinchart
2019-10-31 13:28 ` Laurent Pinchart
2019-10-31 15:48 ` Sakari Ailus
2019-10-31 15:48 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105014353.GA841@bogus \
--to=robh@kernel.org \
--cc=a.brela@framos.com \
--cc=c.barrett@framos.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=peter.griffin@linaro.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.