[PATCH 0/2] Couple of reset-brcmstb fixes

[PATCH 0/2] Couple of reset-brcmstb fixes

[Florian Fainelli]

Hi Philipp,

This series replaces the previously submitted fixes to the reset-brcmstb
driver and also fix the dt binding example.

Thank you!

Florian Fainelli (2):
  dt-bindings: reset: Fix brcmstb-reset example
  reset: brcmstb: Remove resource checks

 .../devicetree/bindings/reset/brcm,brcmstb-reset.txt        | 2 +-
 drivers/reset/reset-brcmstb.c                               | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

-- 
2.17.1

[PATCH 0/2] Couple of reset-brcmstb fixes

[Florian Fainelli]

Hi Philipp,

This series replaces the previously submitted fixes to the reset-brcmstb
driver and also fix the dt binding example.

Thank you!

Florian Fainelli (2):
  dt-bindings: reset: Fix brcmstb-reset example
  reset: brcmstb: Remove resource checks

 .../devicetree/bindings/reset/brcm,brcmstb-reset.txt        | 2 +-
 drivers/reset/reset-brcmstb.c                               | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/2] dt-bindings: reset: Fix brcmstb-reset example

[Florian Fainelli]

The reset controller has a #reset-cells value of 1, so we should see a
phandle plus a register identifier, fix the example.

Fixes: 0807caf647dd ("dt-bindings: reset: Add document for Broadcom STB reset controller")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt b/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
index 6e5341b4f891..ee59409640f2 100644
--- a/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
+++ b/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
@@ -22,6 +22,6 @@ Example:
 	};
 
 	&ethernet_switch {
-		resets = <&reset>;
+		resets = <&reset 26>;
 		reset-names = "switch";
 	};
-- 
2.17.1

[PATCH 1/2] dt-bindings: reset: Fix brcmstb-reset example

[Florian Fainelli]

The reset controller has a #reset-cells value of 1, so we should see a
phandle plus a register identifier, fix the example.

Fixes: 0807caf647dd ("dt-bindings: reset: Add document for Broadcom STB reset controller")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt b/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
index 6e5341b4f891..ee59409640f2 100644
--- a/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
+++ b/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
@@ -22,6 +22,6 @@ Example:
 	};
 
 	&ethernet_switch {
-		resets = <&reset>;
+		resets = <&reset 26>;
 		reset-names = "switch";
 	};
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] reset: brcmstb: Remove resource checks

[Florian Fainelli]

The use of IS_ALIGNED() is incorrect, the typical resource we pass looks
like this: start: 0x8404318, size: 0x30. When using IS_ALIGNED() we will
get the following 0x8404318 & (0x18 - 1) = 0x10 which is definitively
not equal to 0, same goes with the size. These two checks would make the
driver fail probing.

Remove the resource checks, since there should be no constraint on the
base addresse or size.

Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/reset/reset-brcmstb.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/reset/reset-brcmstb.c b/drivers/reset/reset-brcmstb.c
index a608f445dad6..f213264c8567 100644
--- a/drivers/reset/reset-brcmstb.c
+++ b/drivers/reset/reset-brcmstb.c
@@ -91,12 +91,6 @@ static int brcmstb_reset_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!IS_ALIGNED(res->start, SW_INIT_BANK_SIZE) ||
-	    !IS_ALIGNED(resource_size(res), SW_INIT_BANK_SIZE)) {
-		dev_err(kdev, "incorrect register range\n");
-		return -EINVAL;
-	}
-
 	priv->base = devm_ioremap_resource(kdev, res);
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
-- 
2.17.1

[PATCH 2/2] reset: brcmstb: Remove resource checks

[Florian Fainelli]

The use of IS_ALIGNED() is incorrect, the typical resource we pass looks
like this: start: 0x8404318, size: 0x30. When using IS_ALIGNED() we will
get the following 0x8404318 & (0x18 - 1) = 0x10 which is definitively
not equal to 0, same goes with the size. These two checks would make the
driver fail probing.

Remove the resource checks, since there should be no constraint on the
base addresse or size.

Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/reset/reset-brcmstb.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/reset/reset-brcmstb.c b/drivers/reset/reset-brcmstb.c
index a608f445dad6..f213264c8567 100644
--- a/drivers/reset/reset-brcmstb.c
+++ b/drivers/reset/reset-brcmstb.c
@@ -91,12 +91,6 @@ static int brcmstb_reset_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!IS_ALIGNED(res->start, SW_INIT_BANK_SIZE) ||
-	    !IS_ALIGNED(resource_size(res), SW_INIT_BANK_SIZE)) {
-		dev_err(kdev, "incorrect register range\n");
-		return -EINVAL;
-	}
-
 	priv->base = devm_ioremap_resource(kdev, res);
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Couple of reset-brcmstb fixes

[Philipp Zabel]

Hi Florian,

On Mon, 2019-11-04 at 10:15 -0800, Florian Fainelli wrote:
> Hi Philipp,
> 
> This series replaces the previously submitted fixes to the reset-brcmstb
> driver and also fix the dt binding example.
> 
> Thank you!

Thank you. Both applied to reset/fixes.

regards
Philipp

Re: [PATCH 0/2] Couple of reset-brcmstb fixes

[Philipp Zabel]

Hi Florian,

On Mon, 2019-11-04 at 10:15 -0800, Florian Fainelli wrote:
> Hi Philipp,
> 
> This series replaces the previously submitted fixes to the reset-brcmstb
> driver and also fix the dt binding example.
> 
> Thank you!

Thank you. Both applied to reset/fixes.

regards
Philipp


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Couple of reset-brcmstb fixes

[Florian Fainelli]

On 11/6/19 1:01 AM, Philipp Zabel wrote:
> Hi Florian,
> 
> On Mon, 2019-11-04 at 10:15 -0800, Florian Fainelli wrote:
>> Hi Philipp,
>>
>> This series replaces the previously submitted fixes to the reset-brcmstb
>> driver and also fix the dt binding example.
>>
>> Thank you!
> 
> Thank you. Both applied to reset/fixes.

Philipp, when do you expect these patches to hit Linus' tree? Thanks!
-- 
Florian

Re: [PATCH 0/2] Couple of reset-brcmstb fixes

[Florian Fainelli]

On 11/6/19 1:01 AM, Philipp Zabel wrote:
> Hi Florian,
> 
> On Mon, 2019-11-04 at 10:15 -0800, Florian Fainelli wrote:
>> Hi Philipp,
>>
>> This series replaces the previously submitted fixes to the reset-brcmstb
>> driver and also fix the dt binding example.
>>
>> Thank you!
> 
> Thank you. Both applied to reset/fixes.

Philipp, when do you expect these patches to hit Linus' tree? Thanks!
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] Couple of reset-brcmstb fixes

[Philipp Zabel]

Hi Florian,

On Tue, 2019-12-10 at 09:51 -0800, Florian Fainelli wrote:
> On 11/6/19 1:01 AM, Philipp Zabel wrote:
> > Hi Florian,
> > 
> > On Mon, 2019-11-04 at 10:15 -0800, Florian Fainelli wrote:
> > > Hi Philipp,
> > > 
> > > This series replaces the previously submitted fixes to the reset-brcmstb
> > > driver and also fix the dt binding example.
> > > 
> > > Thank you!
> > 
> > Thank you. Both applied to reset/fixes.
> 
> Philipp, when do you expect these patches to hit Linus' tree? Thanks!

I have just sent out a pull request for v5.5, I hope we can get them
into -rc2.

regards
Philipp

Re: [PATCH 0/2] Couple of reset-brcmstb fixes

[Philipp Zabel]

Hi Florian,

On Tue, 2019-12-10 at 09:51 -0800, Florian Fainelli wrote:
> On 11/6/19 1:01 AM, Philipp Zabel wrote:
> > Hi Florian,
> > 
> > On Mon, 2019-11-04 at 10:15 -0800, Florian Fainelli wrote:
> > > Hi Philipp,
> > > 
> > > This series replaces the previously submitted fixes to the reset-brcmstb
> > > driver and also fix the dt binding example.
> > > 
> > > Thank you!
> > 
> > Thank you. Both applied to reset/fixes.
> 
> Philipp, when do you expect these patches to hit Linus' tree? Thanks!

I have just sent out a pull request for v5.5, I hope we can get them
into -rc2.

regards
Philipp


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel