All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Delaunay <patrick.delaunay@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/5] usb: host: dwc2: force reset assert
Date: Tue, 12 Nov 2019 10:42:13 +0100	[thread overview]
Message-ID: <20191112094214.12686-5-patrick.delaunay@st.com> (raw)
In-Reply-To: <20191112094214.12686-1-patrick.delaunay@st.com>

Assert reset before deassert in dwc2_reset;
this patch solve issues when the DWC2 registers are already
initialized with value incompatible with host mode.

Force a hardware reset of the IP reset all the DWC2 registers at
default value, the host driver start with a clean state
(Core Soft reset doen in dwc_otg_core_reset is not enought
 to reset all register).

The error can occurs in U-Boot when DWC2 device gadget driver
force device mode (called by ums or dfu command, before to execute
the usb start command).

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

Changes in v3: None
Changes in v2:
- add clk_disable_bulk in dwc2_usb_remove

 drivers/usb/host/dwc2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c
index 9a00bea24f..870b06459e 100644
--- a/drivers/usb/host/dwc2.c
+++ b/drivers/usb/host/dwc2.c
@@ -1149,6 +1149,8 @@ static int dwc2_reset(struct udevice *dev)
 			return ret;
 	}
 
+	/* force reset to clear all IP register */
+	reset_assert_bulk(&priv->resets);
 	ret = reset_deassert_bulk(&priv->resets);
 	if (ret) {
 		reset_release_bulk(&priv->resets);
-- 
2.17.1

  parent reply	other threads:[~2019-11-12  9:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  9:42 [U-Boot] [PATCH v3 0/5] usb: host: dwc2: use driver model for PHY and CLOCK Patrick Delaunay
2019-11-12  9:42 ` [U-Boot] [PATCH v3 1/5] dm: clk: add stub for clk_disable_bulk when CONFIG_CLK is desactivated Patrick Delaunay
2019-11-12 10:16   ` Jean-Jacques Hiblot
2019-11-12 15:47     ` Patrick DELAUNAY
2019-11-12 10:40   ` Simon Goldschmidt
2019-11-20 10:04     ` Patrick DELAUNAY
2019-11-12  9:42 ` [U-Boot] [PATCH v3 2/5] usb: host: dwc2: add phy support Patrick Delaunay
2019-11-12  9:42 ` [U-Boot] [PATCH v3 3/5] usb: host: dwc2: add clk support Patrick Delaunay
2019-11-12  9:42 ` Patrick Delaunay [this message]
2019-11-12  9:42 ` [U-Boot] [PATCH v3 5/5] usb: host: dwc2: add trace to have clean usb start Patrick Delaunay
2020-02-14 13:34 ` [PATCH v3 0/5] usb: host: dwc2: use driver model for PHY and CLOCK Patrick DELAUNAY
2020-02-14 18:29   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112094214.12686-5-patrick.delaunay@st.com \
    --to=patrick.delaunay@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.