From: Patrick DELAUNAY <patrick.delaunay@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/5] dm: clk: add stub for clk_disable_bulk when CONFIG_CLK is desactivated
Date: Tue, 12 Nov 2019 15:47:56 +0000 [thread overview]
Message-ID: <2e3b948dad6b470ba1356dbf04080d6e@SFHDAG6NODE3.st.com> (raw)
In-Reply-To: <19c5071a-ab8a-7c68-a7fe-bda25391b531@ti.com>
Hi Jean-Jacques,
> From: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Sent: mardi 12 novembre 2019 11:17
>
> Hi Patrick,
>
> On 12/11/2019 10:42, Patrick Delaunay wrote:
> > Add stub for clk_disable_bulk() when CONFIG_CLK is desactivated.
> >
> > That avoid compilation issue (undefined reference to
> > `clk_disable_bulk') for code:
> >
> > clk_disable_bulk(&priv->clks);
> > clk_release_bulk(&priv->clks);
> >
> > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> > ---
> >
> > Changes in v3:
> > - Add stub for clk_disable_bulk
> >
> > Changes in v2: None
> >
> > include/clk.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/include/clk.h b/include/clk.h index
> > a5ee53d94a..6f0b0fe4bc 100644
> > --- a/include/clk.h
> > +++ b/include/clk.h
> > @@ -379,7 +379,11 @@ int clk_disable(struct clk *clk);
> > * by clk_get_bulk().
> > * @return zero on success, or -ve error code.
> > */
> > + #if CONFIG_IS_ENABLED(CLK)
> > int clk_disable_bulk(struct clk_bulk *bulk);
> > +#else
> > +inline int clk_disable_bulk(struct clk_bulk *bulk) { return 0; }
> > +#endif
>
> Maybe this could be done for all clk operations ?
I think about, but after reflection
1/ stub already exist for :
clk_get_by_index
clk_get_bulk
clk_get_by_name
clk_release_all
=> just inline , return -ENOSYS
2/ clk_release_bulk inline call for clk_release_all
3/ other function (clk_request, clk_free, clk_get_rate, clk_enable, clk_disable)
should be not used as "clk" parameter is never valid / available if CONFIG_CLK is not activited
4/ the only remaining case is
int clk_disable_bulk(struct clk_bulk *bulk);
=> clk_get_bulk return -ENOSYS but normally this information is not keept by caller....
On error bulk.count = 0, and for me clk_disable_bulk(bulk wthou count = 0) is valid even if CONFIG_CLK is disable....
So I decide to limit the patch to this function to minimize the impacts
also because the 2020.01 windows is closed.
Moreover I have not board to test CONFIG_CLK disabled.
But I agree : it is more clear a have a stub for other function which can be used
including clk_valid
=> I can propose a 2nd separate patch with this proposal if it is required.
> JJ
Regards
Patrick
next prev parent reply other threads:[~2019-11-12 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 9:42 [U-Boot] [PATCH v3 0/5] usb: host: dwc2: use driver model for PHY and CLOCK Patrick Delaunay
2019-11-12 9:42 ` [U-Boot] [PATCH v3 1/5] dm: clk: add stub for clk_disable_bulk when CONFIG_CLK is desactivated Patrick Delaunay
2019-11-12 10:16 ` Jean-Jacques Hiblot
2019-11-12 15:47 ` Patrick DELAUNAY [this message]
2019-11-12 10:40 ` Simon Goldschmidt
2019-11-20 10:04 ` Patrick DELAUNAY
2019-11-12 9:42 ` [U-Boot] [PATCH v3 2/5] usb: host: dwc2: add phy support Patrick Delaunay
2019-11-12 9:42 ` [U-Boot] [PATCH v3 3/5] usb: host: dwc2: add clk support Patrick Delaunay
2019-11-12 9:42 ` [U-Boot] [PATCH v3 4/5] usb: host: dwc2: force reset assert Patrick Delaunay
2019-11-12 9:42 ` [U-Boot] [PATCH v3 5/5] usb: host: dwc2: add trace to have clean usb start Patrick Delaunay
2020-02-14 13:34 ` [PATCH v3 0/5] usb: host: dwc2: use driver model for PHY and CLOCK Patrick DELAUNAY
2020-02-14 18:29 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e3b948dad6b470ba1356dbf04080d6e@SFHDAG6NODE3.st.com \
--to=patrick.delaunay@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.