All of lore.kernel.org
 help / color / mirror / Atom feed
From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 1/2] drm/i915/tgl: Wa_1606679103
Date: Wed, 13 Nov 2019 15:19:53 -0800	[thread overview]
Message-ID: <20191113231953.24853-1-radhakrishna.sripada@intel.com> (raw)
In-Reply-To: <20191113191840.23620-1-radhakrishna.sripada@intel.com>

Extend disabling SAMPLER_STATE prefetch workaround to gen12.

v2: Limit the WA to TGL A0 and update the WA no(Chris)

BSpec: 52890
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index e4bccc14602f..da27eb1cd7cd 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1370,11 +1370,6 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 				    GEN7_SARCHKMD,
 				    GEN7_DISABLE_DEMAND_PREFETCH);
 
-		/* Wa_1606682166:icl */
-		wa_write_or(wal,
-			    GEN7_SARCHKMD,
-			    GEN7_DISABLE_SAMPLER_PREFETCH);
-
 		/* Wa_1409178092:icl */
 		wa_write_masked_or(wal,
 				   GEN11_SCRATCH2,
@@ -1382,6 +1377,16 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 				   0);
 	}
 
+	if (IS_TGL_REVID(i915, TGL_REVID_A0, TGL_REVID_A0) || IS_GEN(i915, 11)) {
+		/*
+		 * Wa_1606682166:icl
+		 * Wa_1606679103:tgl
+		 */
+		wa_write_or(wal,
+			    GEN7_SARCHKMD,
+			    GEN7_DISABLE_SAMPLER_PREFETCH);
+	}
+
 	if (IS_GEN_RANGE(i915, 9, 11)) {
 		/* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl */
 		wa_masked_en(wal,
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Wa_1606679103
Date: Wed, 13 Nov 2019 15:19:53 -0800	[thread overview]
Message-ID: <20191113231953.24853-1-radhakrishna.sripada@intel.com> (raw)
Message-ID: <20191113231953.c1wso6p5WRdqMWZ9MxVe72klL6Exaybk1KXEMhq-v1k@z> (raw)
In-Reply-To: <20191113191840.23620-1-radhakrishna.sripada@intel.com>

Extend disabling SAMPLER_STATE prefetch workaround to gen12.

v2: Limit the WA to TGL A0 and update the WA no(Chris)

BSpec: 52890
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index e4bccc14602f..da27eb1cd7cd 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1370,11 +1370,6 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 				    GEN7_SARCHKMD,
 				    GEN7_DISABLE_DEMAND_PREFETCH);
 
-		/* Wa_1606682166:icl */
-		wa_write_or(wal,
-			    GEN7_SARCHKMD,
-			    GEN7_DISABLE_SAMPLER_PREFETCH);
-
 		/* Wa_1409178092:icl */
 		wa_write_masked_or(wal,
 				   GEN11_SCRATCH2,
@@ -1382,6 +1377,16 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 				   0);
 	}
 
+	if (IS_TGL_REVID(i915, TGL_REVID_A0, TGL_REVID_A0) || IS_GEN(i915, 11)) {
+		/*
+		 * Wa_1606682166:icl
+		 * Wa_1606679103:tgl
+		 */
+		wa_write_or(wal,
+			    GEN7_SARCHKMD,
+			    GEN7_DISABLE_SAMPLER_PREFETCH);
+	}
+
 	if (IS_GEN_RANGE(i915, 9, 11)) {
 		/* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl */
 		wa_masked_en(wal,
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-13 23:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 19:18 [PATCH 1/2] drm/i915/tgl: Wa_1606679103 Radhakrishna Sripada
2019-11-13 19:18 ` [Intel-gfx] " Radhakrishna Sripada
2019-11-13 19:18 ` [PATCH 2/2] drm/i915/tgl: Add Wa_1408615072 Radhakrishna Sripada
2019-11-13 19:18   ` [Intel-gfx] " Radhakrishna Sripada
2019-11-14 10:28   ` Ville Syrjälä
2019-11-14 10:28     ` [Intel-gfx] " Ville Syrjälä
2019-11-14 21:50   ` [PATCH v2 " Radhakrishna Sripada
2019-11-14 21:50     ` [Intel-gfx] " Radhakrishna Sripada
2019-11-15 21:07     ` Matt Roper
2019-11-15 21:07       ` [Intel-gfx] " Matt Roper
2019-11-13 22:12 ` [PATCH 1/2] drm/i915/tgl: Wa_1606679103 Chris Wilson
2019-11-13 22:12   ` [Intel-gfx] " Chris Wilson
2019-11-13 23:19 ` Radhakrishna Sripada [this message]
2019-11-13 23:19   ` [Intel-gfx] [PATCH v2 " Radhakrishna Sripada
2019-11-13 23:32   ` Chris Wilson
2019-11-13 23:32     ` [Intel-gfx] " Chris Wilson
2019-11-14  3:50 ` ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/tgl: Wa_1606679103 (rev2) Patchwork
2019-11-14  3:50   ` [Intel-gfx] " Patchwork
2019-11-14 22:21 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/tgl: Wa_1606679103 (rev3) Patchwork
2019-11-14 22:21   ` [Intel-gfx] " Patchwork
2019-11-16  3:20 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-16  3:20   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113231953.24853-1-radhakrishna.sripada@intel.com \
    --to=radhakrishna.sripada@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.