From: Mika Westerberg <mika.westerberg@intel.com> To: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Karol Herbst <kherbst@redhat.com>, Bjorn Helgaas <helgaas@kernel.org>, LKML <linux-kernel@vger.kernel.org>, Lyude Paul <lyude@redhat.com>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Linux PCI <linux-pci@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, nouveau <nouveau@lists.freedesktop.org>, Dave Airlie <airlied@gmail.com>, Mario Limonciello <Mario.Limonciello@dell.com> Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Date: Thu, 21 Nov 2019 13:17:39 +0200 [thread overview] Message-ID: <20191121111739.GT11621@lahna.fi.intel.com> (raw) In-Reply-To: <CAJZ5v0hAgz4Fu=83AJE2PYUsi+Jk=Lrr4MNp5ySA9yY=3wr5rg@mail.gmail.com> On Thu, Nov 21, 2019 at 12:03:52PM +0100, Rafael J. Wysocki wrote: > On Thu, Nov 21, 2019 at 11:14 AM Mika Westerberg > <mika.westerberg@intel.com> wrote: > > > > On Wed, Nov 20, 2019 at 10:36:31PM +0100, Karol Herbst wrote: > > > with the branch and patch applied: > > > https://gist.githubusercontent.com/karolherbst/03c4c8141b0fa292d781badfa186479e/raw/5c62640afbc57d6e69ea924c338bd2836e770d02/gistfile1.txt > > > > Thanks for testing. Too bad it did not help :( I suppose there is no > > change if you increase the delay to say 1s? > > Well, look at the original patch in this thread. > > What it does is to prevent the device (GPU in this particular case) > from going into a PCI low-power state before invoking AML to power it > down (the AML is still invoked after this patch AFAICS), so why would > that have anything to do with the delays? Yes, I know what it does :) I was just thinking that maybe it's still the link that does not come up when we go back to D0 I guess that's not the case here. > The only reason would be the AML running too early, but that doesn't > seem likely. IMO more likely is that the AML does something which > cannot be done to a device in a PCI low-power state. It may very well be the case.
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@intel.com> To: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Karol Herbst <kherbst@redhat.com>, Linux PM <linux-pm@vger.kernel.org>, Linux PCI <linux-pci@vger.kernel.org>, Mario Limonciello <Mario.Limonciello@dell.com>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, LKML <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Bjorn Helgaas <helgaas@kernel.org>, nouveau <nouveau@lists.freedesktop.org> Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Date: Thu, 21 Nov 2019 13:17:39 +0200 [thread overview] Message-ID: <20191121111739.GT11621@lahna.fi.intel.com> (raw) Message-ID: <20191121111739.x4lCuhbU9--8uc1SFZ6G5C8S9sZlon2IvojMqZOCgyM@z> (raw) In-Reply-To: <CAJZ5v0hAgz4Fu=83AJE2PYUsi+Jk=Lrr4MNp5ySA9yY=3wr5rg@mail.gmail.com> On Thu, Nov 21, 2019 at 12:03:52PM +0100, Rafael J. Wysocki wrote: > On Thu, Nov 21, 2019 at 11:14 AM Mika Westerberg > <mika.westerberg@intel.com> wrote: > > > > On Wed, Nov 20, 2019 at 10:36:31PM +0100, Karol Herbst wrote: > > > with the branch and patch applied: > > > https://gist.githubusercontent.com/karolherbst/03c4c8141b0fa292d781badfa186479e/raw/5c62640afbc57d6e69ea924c338bd2836e770d02/gistfile1.txt > > > > Thanks for testing. Too bad it did not help :( I suppose there is no > > change if you increase the delay to say 1s? > > Well, look at the original patch in this thread. > > What it does is to prevent the device (GPU in this particular case) > from going into a PCI low-power state before invoking AML to power it > down (the AML is still invoked after this patch AFAICS), so why would > that have anything to do with the delays? Yes, I know what it does :) I was just thinking that maybe it's still the link that does not come up when we go back to D0 I guess that's not the case here. > The only reason would be the AML running too early, but that doesn't > seem likely. IMO more likely is that the AML does something which > cannot be done to a device in a PCI low-power state. It may very well be the case. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-21 11:17 UTC|newest] Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-17 12:19 [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Karol Herbst 2019-11-14 19:17 ` Karol Herbst 2019-11-14 19:17 ` Karol Herbst 2019-11-19 20:06 ` Dave Airlie 2019-11-19 20:06 ` Dave Airlie 2019-11-19 20:06 ` Dave Airlie 2019-11-19 21:49 ` Bjorn Helgaas 2019-11-19 21:49 ` Bjorn Helgaas 2019-11-19 22:26 ` Karol Herbst 2019-11-19 22:26 ` Karol Herbst 2019-11-19 22:26 ` Karol Herbst 2019-11-19 22:57 ` Bjorn Helgaas 2019-11-19 22:57 ` Bjorn Helgaas 2019-11-20 10:18 ` Mika Westerberg 2019-11-20 10:18 ` Mika Westerberg 2019-11-20 10:52 ` Rafael J. Wysocki 2019-11-20 10:52 ` Rafael J. Wysocki 2019-11-20 10:52 ` Rafael J. Wysocki 2019-11-20 11:22 ` Mika Westerberg 2019-11-20 11:22 ` Mika Westerberg 2019-11-20 11:48 ` Rafael J. Wysocki 2019-11-20 11:48 ` Rafael J. Wysocki 2019-11-20 11:51 ` Karol Herbst 2019-11-20 11:51 ` Karol Herbst 2019-11-20 12:06 ` Rafael J. Wysocki 2019-11-20 12:06 ` Rafael J. Wysocki 2019-11-20 12:06 ` Rafael J. Wysocki 2019-11-20 12:09 ` Karol Herbst 2019-11-20 12:09 ` Karol Herbst 2019-11-20 12:09 ` Karol Herbst 2019-11-20 12:14 ` Rafael J. Wysocki 2019-11-20 12:14 ` Rafael J. Wysocki 2019-11-20 12:19 ` Karol Herbst 2019-11-20 12:19 ` Karol Herbst 2019-11-20 12:11 ` Rafael J. Wysocki 2019-11-20 12:11 ` Rafael J. Wysocki 2019-11-20 11:51 ` Mika Westerberg 2019-11-20 11:51 ` Mika Westerberg 2019-11-20 11:54 ` Karol Herbst 2019-11-20 11:54 ` Karol Herbst 2019-11-20 11:54 ` Karol Herbst 2019-11-20 11:58 ` Karol Herbst 2019-11-20 11:58 ` Karol Herbst 2019-11-20 11:58 ` Karol Herbst 2019-11-20 12:09 ` Mika Westerberg 2019-11-20 12:09 ` Mika Westerberg 2019-11-20 12:11 ` Karol Herbst 2019-11-20 12:11 ` Karol Herbst 2019-11-20 12:11 ` Karol Herbst 2019-11-20 15:15 ` Mika Westerberg 2019-11-20 15:15 ` Mika Westerberg 2019-11-20 15:37 ` Karol Herbst 2019-11-20 15:37 ` Karol Herbst 2019-11-20 15:53 ` Mika Westerberg 2019-11-20 15:53 ` Mika Westerberg 2019-11-20 16:23 ` Mika Westerberg 2019-11-20 16:23 ` Mika Westerberg 2019-11-20 21:36 ` Karol Herbst 2019-11-20 21:36 ` Karol Herbst 2019-11-20 21:36 ` Karol Herbst 2019-11-21 10:14 ` Mika Westerberg 2019-11-21 10:14 ` Mika Westerberg 2019-11-21 11:03 ` Rafael J. Wysocki 2019-11-21 11:03 ` Rafael J. Wysocki 2019-11-21 11:08 ` Rafael J. Wysocki 2019-11-21 11:08 ` Rafael J. Wysocki 2019-11-21 11:08 ` Rafael J. Wysocki 2019-11-21 11:15 ` Rafael J. Wysocki 2019-11-21 11:15 ` Rafael J. Wysocki 2019-11-21 11:17 ` Mika Westerberg [this message] 2019-11-21 11:17 ` Mika Westerberg 2019-11-21 11:31 ` Rafael J. Wysocki 2019-11-21 11:31 ` Rafael J. Wysocki 2019-11-20 21:37 ` Rafael J. Wysocki 2019-11-20 21:37 ` Rafael J. Wysocki 2019-11-20 21:40 ` Karol Herbst 2019-11-20 21:40 ` Karol Herbst 2019-11-20 22:29 ` Rafael J. Wysocki 2019-11-20 22:29 ` Rafael J. Wysocki 2019-11-21 11:28 ` Mika Westerberg 2019-11-21 11:28 ` Mika Westerberg 2019-11-21 11:34 ` Rafael J. Wysocki 2019-11-21 11:34 ` Rafael J. Wysocki 2019-11-21 11:34 ` Rafael J. Wysocki 2019-11-21 11:46 ` Mika Westerberg 2019-11-21 11:46 ` Mika Westerberg 2019-11-21 12:52 ` Mika Westerberg 2019-11-21 12:52 ` Mika Westerberg 2019-11-21 12:56 ` Karol Herbst 2019-11-21 12:56 ` Karol Herbst 2019-11-21 15:43 ` Rafael J. Wysocki 2019-11-21 15:43 ` Rafael J. Wysocki 2019-11-21 15:43 ` Rafael J. Wysocki 2019-11-21 19:49 ` Mika Westerberg 2019-11-21 19:49 ` Mika Westerberg 2019-11-21 22:39 ` Rafael J. Wysocki 2019-11-21 22:39 ` Rafael J. Wysocki 2019-11-21 22:39 ` Rafael J. Wysocki 2019-11-21 22:50 ` Karol Herbst 2019-11-21 22:50 ` Karol Herbst 2019-11-22 0:13 ` Karol Herbst 2019-11-22 0:13 ` Karol Herbst 2019-11-22 9:07 ` Rafael J. Wysocki 2019-11-22 9:07 ` Rafael J. Wysocki 2019-11-22 11:30 ` Karol Herbst 2019-11-22 11:30 ` Karol Herbst 2019-11-22 11:30 ` Karol Herbst 2019-11-22 10:36 ` Mika Westerberg 2019-11-22 10:36 ` Mika Westerberg 2019-11-22 11:30 ` Rafael J. Wysocki 2019-11-22 11:30 ` Rafael J. Wysocki 2019-11-22 11:34 ` Karol Herbst 2019-11-22 11:34 ` Karol Herbst 2019-11-22 11:34 ` Karol Herbst 2019-11-22 11:54 ` Rafael J. Wysocki 2019-11-22 11:54 ` Rafael J. Wysocki 2019-11-22 11:52 ` Mika Westerberg 2019-11-22 11:52 ` Mika Westerberg 2019-11-22 12:15 ` Rafael J. Wysocki 2019-11-22 12:15 ` Rafael J. Wysocki 2019-11-21 12:52 ` Karol Herbst 2019-11-21 12:52 ` Karol Herbst 2019-11-21 15:47 ` Rafael J. Wysocki 2019-11-21 15:47 ` Rafael J. Wysocki 2019-11-21 16:06 ` Karol Herbst 2019-11-21 16:06 ` Karol Herbst 2019-11-21 16:39 ` Rafael J. Wysocki 2019-11-21 16:39 ` Rafael J. Wysocki 2019-11-26 23:10 ` Lyude Paul 2019-11-26 23:10 ` Lyude Paul 2019-11-27 11:48 ` Mika Westerberg 2019-11-27 11:48 ` Mika Westerberg 2019-11-27 11:51 ` Karol Herbst 2019-11-27 11:51 ` Karol Herbst 2019-11-27 19:51 ` Lyude Paul 2019-11-27 19:51 ` Lyude Paul 2019-12-09 11:17 ` Karol Herbst 2019-12-09 11:17 ` Karol Herbst 2019-12-09 11:38 ` Rafael J. Wysocki 2019-12-09 11:38 ` Rafael J. Wysocki 2019-12-09 11:38 ` Rafael J. Wysocki 2019-12-09 12:24 ` Karol Herbst 2019-12-09 12:24 ` Karol Herbst 2019-12-10 19:58 ` Dave Airlie 2019-12-10 19:58 ` Dave Airlie 2019-12-10 20:49 ` Karol Herbst 2019-12-10 20:49 ` Karol Herbst 2020-01-13 15:31 ` Karol Herbst 2020-01-13 15:31 ` Karol Herbst 2020-01-13 15:31 ` Karol Herbst
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191121111739.GT11621@lahna.fi.intel.com \ --to=mika.westerberg@intel.com \ --cc=Mario.Limonciello@dell.com \ --cc=airlied@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=helgaas@kernel.org \ --cc=kherbst@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=nouveau@lists.freedesktop.org \ --cc=rafael@kernel.org \ --cc=rjw@rjwysocki.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.