All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-11-25 10:42 ` Chris Wilson
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2019-11-25 10:42 UTC (permalink / raw)
  To: intel-gfx
  Cc: Chris Wilson, Martin Peres, Joonas Lahtinen, Rodrigo Vivi,
	Jani Nikula, stable

We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
update the user instructions accordingly.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
 drivers/gpu/drm/i915/i915_utils.c     | 3 +--
 drivers/gpu/drm/i915/i915_utils.h     | 2 ++
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 2b30a45fa25c..1cf53fd4fe66 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
 	if (!xchg(&warned, true) &&
 	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
 		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
-		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
+		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
 		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
 		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
 		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
index c47261ae86ea..9b68b21becf1 100644
--- a/drivers/gpu/drm/i915/i915_utils.c
+++ b/drivers/gpu/drm/i915/i915_utils.c
@@ -8,8 +8,7 @@
 #include "i915_drv.h"
 #include "i915_utils.h"
 
-#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
-#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
+#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
 		    "providing the dmesg log by booting with drm.debug=0xf"
 
 void
diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
index 04139ba1191e..13674b016092 100644
--- a/drivers/gpu/drm/i915/i915_utils.h
+++ b/drivers/gpu/drm/i915/i915_utils.h
@@ -34,6 +34,8 @@
 struct drm_i915_private;
 struct timer_list;
 
+#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
+
 #undef WARN_ON
 /* Many gcc seem to no see through this and fall over :( */
 #if 0
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-11-25 10:42 ` Chris Wilson
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2019-11-25 10:42 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, stable

We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
update the user instructions accordingly.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
 drivers/gpu/drm/i915/i915_utils.c     | 3 +--
 drivers/gpu/drm/i915/i915_utils.h     | 2 ++
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 2b30a45fa25c..1cf53fd4fe66 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
 	if (!xchg(&warned, true) &&
 	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
 		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
-		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
+		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
 		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
 		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
 		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
index c47261ae86ea..9b68b21becf1 100644
--- a/drivers/gpu/drm/i915/i915_utils.c
+++ b/drivers/gpu/drm/i915/i915_utils.c
@@ -8,8 +8,7 @@
 #include "i915_drv.h"
 #include "i915_utils.h"
 
-#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
-#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
+#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
 		    "providing the dmesg log by booting with drm.debug=0xf"
 
 void
diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
index 04139ba1191e..13674b016092 100644
--- a/drivers/gpu/drm/i915/i915_utils.h
+++ b/drivers/gpu/drm/i915/i915_utils.h
@@ -34,6 +34,8 @@
 struct drm_i915_private;
 struct timer_list;
 
+#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
+
 #undef WARN_ON
 /* Many gcc seem to no see through this and fall over :( */
 #if 0
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Update bug URL to point at gitlab issues
@ 2019-11-25 12:51   ` Patchwork
  0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-25 12:51 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Update bug URL to point at gitlab issues
URL   : https://patchwork.freedesktop.org/series/69974/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7416 -> Patchwork_15419
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/index.html

Known issues
------------

  Here are the changes found in Patchwork_15419 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [PASS][1] -> [FAIL][2] ([fdo#103167])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-kbl-7560u}:     [INCOMPLETE][3] ([fdo#109964] / [fdo#112298]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][5] ([fdo#108511]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][7] ([fdo#111407]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][9] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][10] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +3 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-kbl-x1275:       [DMESG-WARN][11] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602]) +4 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@runner@aborted:
    - fi-cfl-guc:         [FAIL][13] ([fdo#110943]) -> [FAIL][14] ([fdo#110943] / [fdo#112387])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-cfl-guc/igt@runner@aborted.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-cfl-guc/igt@runner@aborted.html
    - fi-kbl-guc:         [FAIL][15] ([fdo#110943]) -> [FAIL][16] ([fdo#110943] / [fdo#112387])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-guc/igt@runner@aborted.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-guc/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#110943]: https://bugs.freedesktop.org/show_bug.cgi?id=110943
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
  [fdo#112387]: https://bugs.freedesktop.org/show_bug.cgi?id=112387


Participating hosts (47 -> 44)
------------------------------

  Additional (2): fi-gdg-551 fi-elk-e7500 
  Missing    (5): fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7416 -> Patchwork_15419

  CI-20190529: 20190529
  CI_DRM_7416: 27c78108eb4aa74878015666a796dcfe09dcbd00 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5305: eafaa79dfb71f7251126f1c000e0cbe94425c95a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15419: 5daace7968d30cd579b9c34a11064f5817e46f0c @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

5daace7968d3 drm/i915: Update bug URL to point at gitlab issues

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update bug URL to point at gitlab issues
@ 2019-11-25 12:51   ` Patchwork
  0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-25 12:51 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Update bug URL to point at gitlab issues
URL   : https://patchwork.freedesktop.org/series/69974/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7416 -> Patchwork_15419
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/index.html

Known issues
------------

  Here are the changes found in Patchwork_15419 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [PASS][1] -> [FAIL][2] ([fdo#103167])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-kbl-7560u}:     [INCOMPLETE][3] ([fdo#109964] / [fdo#112298]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][5] ([fdo#108511]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][7] ([fdo#111407]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][9] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][10] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +3 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-kbl-x1275:       [DMESG-WARN][11] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602]) +4 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@runner@aborted:
    - fi-cfl-guc:         [FAIL][13] ([fdo#110943]) -> [FAIL][14] ([fdo#110943] / [fdo#112387])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-cfl-guc/igt@runner@aborted.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-cfl-guc/igt@runner@aborted.html
    - fi-kbl-guc:         [FAIL][15] ([fdo#110943]) -> [FAIL][16] ([fdo#110943] / [fdo#112387])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7416/fi-kbl-guc/igt@runner@aborted.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/fi-kbl-guc/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#110943]: https://bugs.freedesktop.org/show_bug.cgi?id=110943
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
  [fdo#112387]: https://bugs.freedesktop.org/show_bug.cgi?id=112387


Participating hosts (47 -> 44)
------------------------------

  Additional (2): fi-gdg-551 fi-elk-e7500 
  Missing    (5): fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7416 -> Patchwork_15419

  CI-20190529: 20190529
  CI_DRM_7416: 27c78108eb4aa74878015666a796dcfe09dcbd00 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5305: eafaa79dfb71f7251126f1c000e0cbe94425c95a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15419: 5daace7968d30cd579b9c34a11064f5817e46f0c @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

5daace7968d3 drm/i915: Update bug URL to point at gitlab issues

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15419/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues
  2019-11-25 10:42 ` [Intel-gfx] " Chris Wilson
  (?)
@ 2019-12-02 10:30   ` Jani Nikula
  -1 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-12-02 10:30 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx
  Cc: Chris Wilson, Martin Peres, Joonas Lahtinen, Rodrigo Vivi, stable

On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
> update the user instructions accordingly.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 2b30a45fa25c..1cf53fd4fe66 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>  	if (!xchg(&warned, true) &&
>  	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>  		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
> -		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
> +		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>  		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>  		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>  		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index c47261ae86ea..9b68b21becf1 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -8,8 +8,7 @@
>  #include "i915_drv.h"
>  #include "i915_utils.h"
>  
> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>  		    "providing the dmesg log by booting with drm.debug=0xf"

Space between URL and "providing"?

>  
>  void
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index 04139ba1191e..13674b016092 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -34,6 +34,8 @@
>  struct drm_i915_private;
>  struct timer_list;
>  
> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"

Do we really need the question mark?

BR,
Jani.

> +
>  #undef WARN_ON
>  /* Many gcc seem to no see through this and fall over :( */
>  #if 0

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 10:30   ` Jani Nikula
  0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-12-02 10:30 UTC (permalink / raw)
  To: intel-gfx
  Cc: Chris Wilson, Martin Peres, Joonas Lahtinen, Rodrigo Vivi, stable

On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
> update the user instructions accordingly.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 2b30a45fa25c..1cf53fd4fe66 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>  	if (!xchg(&warned, true) &&
>  	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>  		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
> -		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
> +		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>  		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>  		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>  		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index c47261ae86ea..9b68b21becf1 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -8,8 +8,7 @@
>  #include "i915_drv.h"
>  #include "i915_utils.h"
>  
> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>  		    "providing the dmesg log by booting with drm.debug=0xf"

Space between URL and "providing"?

>  
>  void
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index 04139ba1191e..13674b016092 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -34,6 +34,8 @@
>  struct drm_i915_private;
>  struct timer_list;
>  
> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"

Do we really need the question mark?

BR,
Jani.

> +
>  #undef WARN_ON
>  /* Many gcc seem to no see through this and fall over :( */
>  #if 0

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 10:30   ` Jani Nikula
  0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-12-02 10:30 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: stable

On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
> update the user instructions accordingly.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 2b30a45fa25c..1cf53fd4fe66 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>  	if (!xchg(&warned, true) &&
>  	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>  		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
> -		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
> +		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>  		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>  		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>  		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index c47261ae86ea..9b68b21becf1 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -8,8 +8,7 @@
>  #include "i915_drv.h"
>  #include "i915_utils.h"
>  
> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>  		    "providing the dmesg log by booting with drm.debug=0xf"

Space between URL and "providing"?

>  
>  void
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index 04139ba1191e..13674b016092 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -34,6 +34,8 @@
>  struct drm_i915_private;
>  struct timer_list;
>  
> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"

Do we really need the question mark?

BR,
Jani.

> +
>  #undef WARN_ON
>  /* Many gcc seem to no see through this and fall over :( */
>  #if 0

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 11:26     ` Peres, Martin
  0 siblings, 0 replies; 17+ messages in thread
From: Peres, Martin @ 2019-12-02 11:26 UTC (permalink / raw)
  To: Nikula, Jani, Chris Wilson, intel-gfx
  Cc: Joonas Lahtinen, Vivi, Rodrigo, stable

[-- Attachment #1: Type: text/plain, Size: 3247 bytes --]

On 02/12/2019 12:30, Jani Nikula wrote:
> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
>> update the user instructions accordingly.
>>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Martin Peres <martin.peres@linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: stable@vger.kernel.org
>> ---
>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>> index 2b30a45fa25c..1cf53fd4fe66 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>>  	if (!xchg(&warned, true) &&
>>  	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>>  		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
>> -		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
>> +		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>>  		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>>  		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>>  		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>> index c47261ae86ea..9b68b21becf1 100644
>> --- a/drivers/gpu/drm/i915/i915_utils.c
>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>> @@ -8,8 +8,7 @@
>>  #include "i915_drv.h"
>>  #include "i915_utils.h"
>>  
>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>>  		    "providing the dmesg log by booting with drm.debug=0xf"
> 
> Space between URL and "providing"?

If the following comment is accepted, then we need to change this
sentence to:

Please file bugs according to the instruction found at FDO_BUG_URL.

> 
>>  
>>  void
>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>> index 04139ba1191e..13674b016092 100644
>> --- a/drivers/gpu/drm/i915/i915_utils.h
>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>> @@ -34,6 +34,8 @@
>>  struct drm_i915_private;
>>  struct timer_list;
>>  
>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
> 
> Do we really need the question mark?

We may want to point to
https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
don't you think?

Martin

> 
> BR,
> Jani.
> 
>> +
>>  #undef WARN_ON
>>  /* Many gcc seem to no see through this and fall over :( */
>>  #if 0
> 


[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1774 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 11:26     ` Peres, Martin
  0 siblings, 0 replies; 17+ messages in thread
From: Peres, Martin @ 2019-12-02 11:26 UTC (permalink / raw)
  To: Nikula, Jani, Chris Wilson, intel-gfx; +Cc: stable

[-- Attachment #1: Type: text/plain, Size: 3247 bytes --]

On 02/12/2019 12:30, Jani Nikula wrote:
> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
>> update the user instructions accordingly.
>>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Martin Peres <martin.peres@linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: stable@vger.kernel.org
>> ---
>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>> index 2b30a45fa25c..1cf53fd4fe66 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>>  	if (!xchg(&warned, true) &&
>>  	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>>  		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
>> -		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
>> +		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>>  		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>>  		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>>  		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>> index c47261ae86ea..9b68b21becf1 100644
>> --- a/drivers/gpu/drm/i915/i915_utils.c
>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>> @@ -8,8 +8,7 @@
>>  #include "i915_drv.h"
>>  #include "i915_utils.h"
>>  
>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>>  		    "providing the dmesg log by booting with drm.debug=0xf"
> 
> Space between URL and "providing"?

If the following comment is accepted, then we need to change this
sentence to:

Please file bugs according to the instruction found at FDO_BUG_URL.

> 
>>  
>>  void
>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>> index 04139ba1191e..13674b016092 100644
>> --- a/drivers/gpu/drm/i915/i915_utils.h
>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>> @@ -34,6 +34,8 @@
>>  struct drm_i915_private;
>>  struct timer_list;
>>  
>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
> 
> Do we really need the question mark?

We may want to point to
https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
don't you think?

Martin

> 
> BR,
> Jani.
> 
>> +
>>  #undef WARN_ON
>>  /* Many gcc seem to no see through this and fall over :( */
>>  #if 0
> 


[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1774 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues
  2019-12-02 11:26     ` [Intel-gfx] " Peres, Martin
  (?)
@ 2019-12-02 11:36       ` Jani Nikula
  -1 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-12-02 11:36 UTC (permalink / raw)
  To: Peres, Martin, Chris Wilson, intel-gfx
  Cc: Joonas Lahtinen, Vivi, Rodrigo, stable

On Mon, 02 Dec 2019, "Peres, Martin" <martin.peres@intel.com> wrote:
> On 02/12/2019 12:30, Jani Nikula wrote:
>> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
>>> update the user instructions accordingly.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Martin Peres <martin.peres@linux.intel.com>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: stable@vger.kernel.org
>>> ---
>>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>>> index 2b30a45fa25c..1cf53fd4fe66 100644
>>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>>>  	if (!xchg(&warned, true) &&
>>>  	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>>>  		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
>>> -		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
>>> +		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>>>  		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>>>  		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>>>  		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
>>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>>> index c47261ae86ea..9b68b21becf1 100644
>>> --- a/drivers/gpu/drm/i915/i915_utils.c
>>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>>> @@ -8,8 +8,7 @@
>>>  #include "i915_drv.h"
>>>  #include "i915_utils.h"
>>>  
>>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
>>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
>>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>>>  		    "providing the dmesg log by booting with drm.debug=0xf"
>> 
>> Space between URL and "providing"?
>
> If the following comment is accepted, then we need to change this
> sentence to:
>
> Please file bugs according to the instruction found at FDO_BUG_URL.
>
>> 
>>>  
>>>  void
>>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>>> index 04139ba1191e..13674b016092 100644
>>> --- a/drivers/gpu/drm/i915/i915_utils.h
>>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>>> @@ -34,6 +34,8 @@
>>>  struct drm_i915_private;
>>>  struct timer_list;
>>>  
>>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
>> 
>> Do we really need the question mark?
>
> We may want to point to
> https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
> don't you think?

Does gitlab let you set the URL, or is it always autogenerated from the
title? Need to at least fix the "file file" there. ;)

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 11:36       ` Jani Nikula
  0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-12-02 11:36 UTC (permalink / raw)
  To: Peres, Martin, Chris Wilson, intel-gfx
  Cc: Joonas Lahtinen, Vivi, Rodrigo, stable

On Mon, 02 Dec 2019, "Peres, Martin" <martin.peres@intel.com> wrote:
> On 02/12/2019 12:30, Jani Nikula wrote:
>> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
>>> update the user instructions accordingly.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Martin Peres <martin.peres@linux.intel.com>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: stable@vger.kernel.org
>>> ---
>>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>>> index 2b30a45fa25c..1cf53fd4fe66 100644
>>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>>>  	if (!xchg(&warned, true) &&
>>>  	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>>>  		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
>>> -		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
>>> +		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>>>  		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>>>  		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>>>  		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
>>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>>> index c47261ae86ea..9b68b21becf1 100644
>>> --- a/drivers/gpu/drm/i915/i915_utils.c
>>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>>> @@ -8,8 +8,7 @@
>>>  #include "i915_drv.h"
>>>  #include "i915_utils.h"
>>>  
>>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
>>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
>>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>>>  		    "providing the dmesg log by booting with drm.debug=0xf"
>> 
>> Space between URL and "providing"?
>
> If the following comment is accepted, then we need to change this
> sentence to:
>
> Please file bugs according to the instruction found at FDO_BUG_URL.
>
>> 
>>>  
>>>  void
>>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>>> index 04139ba1191e..13674b016092 100644
>>> --- a/drivers/gpu/drm/i915/i915_utils.h
>>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>>> @@ -34,6 +34,8 @@
>>>  struct drm_i915_private;
>>>  struct timer_list;
>>>  
>>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
>> 
>> Do we really need the question mark?
>
> We may want to point to
> https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
> don't you think?

Does gitlab let you set the URL, or is it always autogenerated from the
title? Need to at least fix the "file file" there. ;)

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 11:36       ` Jani Nikula
  0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-12-02 11:36 UTC (permalink / raw)
  To: Peres, Martin, Chris Wilson, intel-gfx; +Cc: stable

On Mon, 02 Dec 2019, "Peres, Martin" <martin.peres@intel.com> wrote:
> On 02/12/2019 12:30, Jani Nikula wrote:
>> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
>>> update the user instructions accordingly.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Martin Peres <martin.peres@linux.intel.com>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: stable@vger.kernel.org
>>> ---
>>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>>> index 2b30a45fa25c..1cf53fd4fe66 100644
>>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>>>  	if (!xchg(&warned, true) &&
>>>  	    ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>>>  		pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
>>> -		pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
>>> +		pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>>>  		pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>>>  		pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>>>  		pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
>>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>>> index c47261ae86ea..9b68b21becf1 100644
>>> --- a/drivers/gpu/drm/i915/i915_utils.c
>>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>>> @@ -8,8 +8,7 @@
>>>  #include "i915_drv.h"
>>>  #include "i915_utils.h"
>>>  
>>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
>>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
>>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>>>  		    "providing the dmesg log by booting with drm.debug=0xf"
>> 
>> Space between URL and "providing"?
>
> If the following comment is accepted, then we need to change this
> sentence to:
>
> Please file bugs according to the instruction found at FDO_BUG_URL.
>
>> 
>>>  
>>>  void
>>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>>> index 04139ba1191e..13674b016092 100644
>>> --- a/drivers/gpu/drm/i915/i915_utils.h
>>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>>> @@ -34,6 +34,8 @@
>>>  struct drm_i915_private;
>>>  struct timer_list;
>>>  
>>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
>> 
>> Do we really need the question mark?
>
> We may want to point to
> https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
> don't you think?

Does gitlab let you set the URL, or is it always autogenerated from the
title? Need to at least fix the "file file" there. ;)

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 14:25         ` Chris Wilson
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2019-12-02 14:25 UTC (permalink / raw)
  To: Peres, Martin, intel-gfx, Jani Nikula
  Cc: Joonas Lahtinen, Vivi, Rodrigo, stable

Quoting Jani Nikula (2019-12-02 11:36:01)
> On Mon, 02 Dec 2019, "Peres, Martin" <martin.peres@intel.com> wrote:
> > On 02/12/2019 12:30, Jani Nikula wrote:
> >> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
> >>> update the user instructions accordingly.
> >>>
> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>> Cc: Martin Peres <martin.peres@linux.intel.com>
> >>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >>> Cc: Jani Nikula <jani.nikula@intel.com>
> >>> Cc: stable@vger.kernel.org
> >>> ---
> >>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
> >>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
> >>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
> >>>  3 files changed, 4 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> >>> index 2b30a45fa25c..1cf53fd4fe66 100644
> >>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> >>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> >>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
> >>>     if (!xchg(&warned, true) &&
> >>>         ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
> >>>             pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
> >>> -           pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
> >>> +           pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
> >>>             pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
> >>>             pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
> >>>             pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
> >>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> >>> index c47261ae86ea..9b68b21becf1 100644
> >>> --- a/drivers/gpu/drm/i915/i915_utils.c
> >>> +++ b/drivers/gpu/drm/i915/i915_utils.c
> >>> @@ -8,8 +8,7 @@
> >>>  #include "i915_drv.h"
> >>>  #include "i915_utils.h"
> >>>  
> >>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
> >>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
> >>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
> >>>                 "providing the dmesg log by booting with drm.debug=0xf"
> >> 
> >> Space between URL and "providing"?
> >
> > If the following comment is accepted, then we need to change this
> > sentence to:
> >
> > Please file bugs according to the instruction found at FDO_BUG_URL.
> >
> >> 
> >>>  
> >>>  void
> >>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> >>> index 04139ba1191e..13674b016092 100644
> >>> --- a/drivers/gpu/drm/i915/i915_utils.h
> >>> +++ b/drivers/gpu/drm/i915/i915_utils.h
> >>> @@ -34,6 +34,8 @@
> >>>  struct drm_i915_private;
> >>>  struct timer_list;
> >>>  
> >>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
> >> 
> >> Do we really need the question mark?
> >
> > We may want to point to
> > https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
> > don't you think?
> 
> Does gitlab let you set the URL, or is it always autogenerated from the
> title? Need to at least fix the "file file" there. ;)

Martin feel free to update the patch with the final wording and links :)
-Chris

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 14:25         ` Chris Wilson
  0 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2019-12-02 14:25 UTC (permalink / raw)
  To: Peres, Martin, intel-gfx, Jani Nikula; +Cc: stable

Quoting Jani Nikula (2019-12-02 11:36:01)
> On Mon, 02 Dec 2019, "Peres, Martin" <martin.peres@intel.com> wrote:
> > On 02/12/2019 12:30, Jani Nikula wrote:
> >> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
> >>> update the user instructions accordingly.
> >>>
> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>> Cc: Martin Peres <martin.peres@linux.intel.com>
> >>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >>> Cc: Jani Nikula <jani.nikula@intel.com>
> >>> Cc: stable@vger.kernel.org
> >>> ---
> >>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
> >>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
> >>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
> >>>  3 files changed, 4 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> >>> index 2b30a45fa25c..1cf53fd4fe66 100644
> >>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> >>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> >>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
> >>>     if (!xchg(&warned, true) &&
> >>>         ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
> >>>             pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
> >>> -           pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
> >>> +           pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
> >>>             pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
> >>>             pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
> >>>             pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
> >>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> >>> index c47261ae86ea..9b68b21becf1 100644
> >>> --- a/drivers/gpu/drm/i915/i915_utils.c
> >>> +++ b/drivers/gpu/drm/i915/i915_utils.c
> >>> @@ -8,8 +8,7 @@
> >>>  #include "i915_drv.h"
> >>>  #include "i915_utils.h"
> >>>  
> >>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
> >>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
> >>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
> >>>                 "providing the dmesg log by booting with drm.debug=0xf"
> >> 
> >> Space between URL and "providing"?
> >
> > If the following comment is accepted, then we need to change this
> > sentence to:
> >
> > Please file bugs according to the instruction found at FDO_BUG_URL.
> >
> >> 
> >>>  
> >>>  void
> >>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> >>> index 04139ba1191e..13674b016092 100644
> >>> --- a/drivers/gpu/drm/i915/i915_utils.h
> >>> +++ b/drivers/gpu/drm/i915/i915_utils.h
> >>> @@ -34,6 +34,8 @@
> >>>  struct drm_i915_private;
> >>>  struct timer_list;
> >>>  
> >>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
> >> 
> >> Do we really need the question mark?
> >
> > We may want to point to
> > https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
> > don't you think?
> 
> Does gitlab let you set the URL, or is it always autogenerated from the
> title? Need to at least fix the "file file" there. ;)

Martin feel free to update the patch with the final wording and links :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues
  2019-12-02 14:25         ` [Intel-gfx] " Chris Wilson
  (?)
@ 2019-12-02 16:45           ` Peres, Martin
  -1 siblings, 0 replies; 17+ messages in thread
From: Peres, Martin @ 2019-12-02 16:45 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx, Nikula, Jani
  Cc: Joonas Lahtinen, Vivi, Rodrigo, stable

[-- Attachment #1: Type: text/plain, Size: 3973 bytes --]

On 02/12/2019 16:25, Chris Wilson wrote:
> Quoting Jani Nikula (2019-12-02 11:36:01)
>> On Mon, 02 Dec 2019, "Peres, Martin" <martin.peres@intel.com> wrote:
>>> On 02/12/2019 12:30, Jani Nikula wrote:
>>>> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>>>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
>>>>> update the user instructions accordingly.
>>>>>
>>>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>>> Cc: Martin Peres <martin.peres@linux.intel.com>
>>>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>>> Cc: stable@vger.kernel.org
>>>>> ---
>>>>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>>>>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>>>>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>>>>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> index 2b30a45fa25c..1cf53fd4fe66 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>>>>>     if (!xchg(&warned, true) &&
>>>>>         ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>>>>>             pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
>>>>> -           pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
>>>>> +           pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>>>>>             pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>>>>>             pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>>>>>             pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
>>>>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>>>>> index c47261ae86ea..9b68b21becf1 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_utils.c
>>>>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>>>>> @@ -8,8 +8,7 @@
>>>>>  #include "i915_drv.h"
>>>>>  #include "i915_utils.h"
>>>>>  
>>>>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
>>>>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
>>>>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>>>>>                 "providing the dmesg log by booting with drm.debug=0xf"
>>>>
>>>> Space between URL and "providing"?
>>>
>>> If the following comment is accepted, then we need to change this
>>> sentence to:
>>>
>>> Please file bugs according to the instruction found at FDO_BUG_URL.
>>>
>>>>
>>>>>  
>>>>>  void
>>>>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>>>>> index 04139ba1191e..13674b016092 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_utils.h
>>>>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>>>>> @@ -34,6 +34,8 @@
>>>>>  struct drm_i915_private;
>>>>>  struct timer_list;
>>>>>  
>>>>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
>>>>
>>>> Do we really need the question mark?
>>>
>>> We may want to point to
>>> https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
>>> don't you think?
>>
>> Does gitlab let you set the URL, or is it always autogenerated from the
>> title? Need to at least fix the "file file" there. ;)
> 
> Martin feel free to update the patch with the final wording and links :)
> -Chris
> 

Darn it, do I need to break my almost 5 year streak of not having a
single i915 patch :o?

Well, I guess now is a good time for this, I had a patch series I wanted
to contribute anyway.

Martin

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1765 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 16:45           ` Peres, Martin
  0 siblings, 0 replies; 17+ messages in thread
From: Peres, Martin @ 2019-12-02 16:45 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx, Nikula, Jani; +Cc: stable

[-- Attachment #1: Type: text/plain, Size: 3973 bytes --]

On 02/12/2019 16:25, Chris Wilson wrote:
> Quoting Jani Nikula (2019-12-02 11:36:01)
>> On Mon, 02 Dec 2019, "Peres, Martin" <martin.peres@intel.com> wrote:
>>> On 02/12/2019 12:30, Jani Nikula wrote:
>>>> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>>>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
>>>>> update the user instructions accordingly.
>>>>>
>>>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>>> Cc: Martin Peres <martin.peres@linux.intel.com>
>>>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>>> Cc: stable@vger.kernel.org
>>>>> ---
>>>>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>>>>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>>>>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>>>>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> index 2b30a45fa25c..1cf53fd4fe66 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>>>>>     if (!xchg(&warned, true) &&
>>>>>         ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>>>>>             pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
>>>>> -           pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
>>>>> +           pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>>>>>             pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>>>>>             pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>>>>>             pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
>>>>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>>>>> index c47261ae86ea..9b68b21becf1 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_utils.c
>>>>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>>>>> @@ -8,8 +8,7 @@
>>>>>  #include "i915_drv.h"
>>>>>  #include "i915_utils.h"
>>>>>  
>>>>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
>>>>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
>>>>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>>>>>                 "providing the dmesg log by booting with drm.debug=0xf"
>>>>
>>>> Space between URL and "providing"?
>>>
>>> If the following comment is accepted, then we need to change this
>>> sentence to:
>>>
>>> Please file bugs according to the instruction found at FDO_BUG_URL.
>>>
>>>>
>>>>>  
>>>>>  void
>>>>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>>>>> index 04139ba1191e..13674b016092 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_utils.h
>>>>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>>>>> @@ -34,6 +34,8 @@
>>>>>  struct drm_i915_private;
>>>>>  struct timer_list;
>>>>>  
>>>>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
>>>>
>>>> Do we really need the question mark?
>>>
>>> We may want to point to
>>> https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
>>> don't you think?
>>
>> Does gitlab let you set the URL, or is it always autogenerated from the
>> title? Need to at least fix the "file file" there. ;)
> 
> Martin feel free to update the patch with the final wording and links :)
> -Chris
> 

Darn it, do I need to break my almost 5 year streak of not having a
single i915 patch :o?

Well, I guess now is a good time for this, I had a patch series I wanted
to contribute anyway.

Martin

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1765 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update bug URL to point at gitlab issues
@ 2019-12-02 16:45           ` Peres, Martin
  0 siblings, 0 replies; 17+ messages in thread
From: Peres, Martin @ 2019-12-02 16:45 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx, Nikula, Jani; +Cc: stable

[-- Attachment #1: Type: text/plain, Size: 3973 bytes --]

On 02/12/2019 16:25, Chris Wilson wrote:
> Quoting Jani Nikula (2019-12-02 11:36:01)
>> On Mon, 02 Dec 2019, "Peres, Martin" <martin.peres@intel.com> wrote:
>>> On 02/12/2019 12:30, Jani Nikula wrote:
>>>> On Mon, 25 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>>>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so
>>>>> update the user instructions accordingly.
>>>>>
>>>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>>> Cc: Martin Peres <martin.peres@linux.intel.com>
>>>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>>> Cc: stable@vger.kernel.org
>>>>> ---
>>>>>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>>>>>  drivers/gpu/drm/i915/i915_utils.c     | 3 +--
>>>>>  drivers/gpu/drm/i915/i915_utils.h     | 2 ++
>>>>>  3 files changed, 4 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> index 2b30a45fa25c..1cf53fd4fe66 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>>>>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915,
>>>>>     if (!xchg(&warned, true) &&
>>>>>         ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) {
>>>>>             pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n");
>>>>> -           pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n");
>>>>> +           pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n");
>>>>>             pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n");
>>>>>             pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n");
>>>>>             pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n",
>>>>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>>>>> index c47261ae86ea..9b68b21becf1 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_utils.c
>>>>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>>>>> @@ -8,8 +8,7 @@
>>>>>  #include "i915_drv.h"
>>>>>  #include "i915_utils.h"
>>>>>  
>>>>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI"
>>>>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \
>>>>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \
>>>>>                 "providing the dmesg log by booting with drm.debug=0xf"
>>>>
>>>> Space between URL and "providing"?
>>>
>>> If the following comment is accepted, then we need to change this
>>> sentence to:
>>>
>>> Please file bugs according to the instruction found at FDO_BUG_URL.
>>>
>>>>
>>>>>  
>>>>>  void
>>>>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>>>>> index 04139ba1191e..13674b016092 100644
>>>>> --- a/drivers/gpu/drm/i915/i915_utils.h
>>>>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>>>>> @@ -34,6 +34,8 @@
>>>>>  struct drm_i915_private;
>>>>>  struct timer_list;
>>>>>  
>>>>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?"
>>>>
>>>> Do we really need the question mark?
>>>
>>> We may want to point to
>>> https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs,
>>> don't you think?
>>
>> Does gitlab let you set the URL, or is it always autogenerated from the
>> title? Need to at least fix the "file file" there. ;)
> 
> Martin feel free to update the patch with the final wording and links :)
> -Chris
> 

Darn it, do I need to break my almost 5 year streak of not having a
single i915 patch :o?

Well, I guess now is a good time for this, I had a patch series I wanted
to contribute anyway.

Martin

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1765 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2019-12-02 16:58 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 10:42 [PATCH] drm/i915: Update bug URL to point at gitlab issues Chris Wilson
2019-11-25 10:42 ` [Intel-gfx] " Chris Wilson
2019-11-25 12:51 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-25 12:51   ` [Intel-gfx] " Patchwork
2019-12-02 10:30 ` [PATCH] " Jani Nikula
2019-12-02 10:30   ` [Intel-gfx] " Jani Nikula
2019-12-02 10:30   ` Jani Nikula
2019-12-02 11:26   ` Peres, Martin
2019-12-02 11:26     ` [Intel-gfx] " Peres, Martin
2019-12-02 11:36     ` Jani Nikula
2019-12-02 11:36       ` [Intel-gfx] " Jani Nikula
2019-12-02 11:36       ` Jani Nikula
2019-12-02 14:25       ` Chris Wilson
2019-12-02 14:25         ` [Intel-gfx] " Chris Wilson
2019-12-02 16:45         ` Peres, Martin
2019-12-02 16:45           ` [Intel-gfx] " Peres, Martin
2019-12-02 16:45           ` Peres, Martin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.