From: Maxime Ripard <mripard@kernel.org>
To: Vasily Khoruzhick <anarsoul@gmail.com>,
Yangtao Li <tiny.windzz@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
Date: Wed, 27 Nov 2019 18:35:47 +0100 [thread overview]
Message-ID: <20191127173547.ch3pcv3lxgdcrfnu@gilmour.lan> (raw)
In-Reply-To: <20191127111419.z5hfu5soxceiivg6@core.my.home>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Wed, Nov 27, 2019 at 12:14:19PM +0100, Ondřej Jirman wrote:
> > + /*
> > + * Avoid entering the interrupt handler, the thermal device is not
> > + * registered yet, we deffer the registration of the interrupt to
> > + * the end.
> > + */
> > + ret = devm_request_threaded_irq(dev, irq, NULL,
> > + sun8i_irq_thread,
> > + IRQF_ONESHOT, "ths", tmdev);
> > + if (ret)
> > + return ret;
> > +
> > + return ret;
>
> I guess just return devm_request_threaded_irq(... ^
This is harder to extend though, so I'd keep the current construct
(with a return 0 though).
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <mripard@kernel.org>
To: Vasily Khoruzhick <anarsoul@gmail.com>,
Yangtao Li <tiny.windzz@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
Date: Wed, 27 Nov 2019 18:35:47 +0100 [thread overview]
Message-ID: <20191127173547.ch3pcv3lxgdcrfnu@gilmour.lan> (raw)
In-Reply-To: <20191127111419.z5hfu5soxceiivg6@core.my.home>
[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]
On Wed, Nov 27, 2019 at 12:14:19PM +0100, Ondřej Jirman wrote:
> > + /*
> > + * Avoid entering the interrupt handler, the thermal device is not
> > + * registered yet, we deffer the registration of the interrupt to
> > + * the end.
> > + */
> > + ret = devm_request_threaded_irq(dev, irq, NULL,
> > + sun8i_irq_thread,
> > + IRQF_ONESHOT, "ths", tmdev);
> > + if (ret)
> > + return ret;
> > +
> > + return ret;
>
> I guess just return devm_request_threaded_irq(... ^
This is harder to extend though, so I'd keep the current construct
(with a return 0 though).
Thanks!
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-27 17:35 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 5:29 [PATCH v6 0/7] add thermal sensor driver for A64, A83T, H3, H5, H6, R40 Vasily Khoruzhick
2019-11-27 5:29 ` Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 Vasily Khoruzhick
2019-11-27 5:29 ` Vasily Khoruzhick
2019-11-27 11:14 ` Ondřej Jirman
2019-11-27 11:14 ` Ondřej Jirman
2019-11-27 17:35 ` Maxime Ripard [this message]
2019-11-27 17:35 ` Maxime Ripard
2019-11-27 19:44 ` Frank Lee
2019-11-27 19:44 ` Frank Lee
2019-11-27 19:48 ` Vasily Khoruzhick
2019-11-27 19:48 ` Vasily Khoruzhick
2019-11-27 22:24 ` Ondřej Jirman
2019-11-27 22:24 ` Ondřej Jirman
2019-11-28 15:16 ` Frank Lee
2019-11-28 15:16 ` Frank Lee
2019-11-29 0:53 ` Ondřej Jirman
2019-11-29 0:53 ` Ondřej Jirman
2019-11-28 7:42 ` Maxime Ripard
2019-11-28 7:42 ` Maxime Ripard
2019-11-27 17:27 ` Maxime Ripard
2019-11-27 17:27 ` Maxime Ripard
2019-11-28 16:43 ` Frank Lee
2019-11-28 16:43 ` Frank Lee
2019-11-28 17:06 ` Ondřej Jirman
2019-11-28 17:06 ` Ondřej Jirman
2019-11-29 11:46 ` Frank Lee
2019-11-29 11:46 ` Frank Lee
2019-12-02 1:58 ` Ondřej Jirman
2019-12-02 1:58 ` Ondřej Jirman
2019-12-09 18:04 ` Frank Lee
2019-12-09 18:04 ` Frank Lee
2019-11-27 5:29 ` [PATCH v6 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings Vasily Khoruzhick
2019-11-27 5:29 ` Vasily Khoruzhick
2019-11-27 17:44 ` Maxime Ripard
2019-11-27 17:44 ` Maxime Ripard
2019-11-27 18:07 ` Ondřej Jirman
2019-11-27 18:07 ` Ondřej Jirman
2019-11-27 18:52 ` Vasily Khoruzhick
2019-11-27 18:52 ` Vasily Khoruzhick
2019-11-27 20:23 ` Vasily Khoruzhick
2019-11-27 20:23 ` Vasily Khoruzhick
2019-11-28 7:43 ` Maxime Ripard
2019-11-28 7:43 ` Maxime Ripard
2019-11-28 14:35 ` Frank Lee
2019-11-28 14:35 ` Frank Lee
2019-11-28 14:45 ` Frank Lee
2019-11-28 14:45 ` Frank Lee
2019-11-28 16:24 ` Vasily Khoruzhick
2019-11-28 16:24 ` Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 3/7] ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones Vasily Khoruzhick
2019-11-27 5:29 ` Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 4/7] ARM: dts: sun8i-h3: " Vasily Khoruzhick
2019-11-27 5:29 ` Vasily Khoruzhick
2019-11-27 19:40 ` Samuel Holland
2019-11-27 19:40 ` Samuel Holland
2019-11-27 5:29 ` [PATCH v6 5/7] arm64: dts: allwinner: sun50i-h5: " Vasily Khoruzhick
2019-11-27 5:29 ` Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 6/7] arm64: dts: allwinner: sun50i-h6: " Vasily Khoruzhick
2019-11-27 5:29 ` Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 7/7] arm64: dts: allwinner: a64: Add thermal sensors " Vasily Khoruzhick
2019-11-27 5:29 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127173547.ch3pcv3lxgdcrfnu@gilmour.lan \
--to=mripard@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=anarsoul@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.