From: Vasily Khoruzhick <anarsoul@gmail.com> To: Frank Lee <tiny.windzz@gmail.com> Cc: Maxime Ripard <mripard@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amit.kucheria@verdurent.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, "David S. Miller" <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux PM <linux-pm@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 Date: Wed, 27 Nov 2019 11:48:32 -0800 [thread overview] Message-ID: <CA+E=qVcdwQO3Y8ismmBN-gRVNMs1Thx+TPLqstKM9fYf2_0qFQ@mail.gmail.com> (raw) In-Reply-To: <CAEExFWvG-Af4qtUrxQV4ssNQCVQAmpXfxB+92wX+6ZxUNfX-Jw@mail.gmail.com> On Wed, Nov 27, 2019 at 11:44 AM Frank Lee <tiny.windzz@gmail.com> wrote: > > Hello Vasily, > > Thank you very much for your work on this. > This looks good to me. Thanks! > By the way, I would like to ask comments about adding the following code. Can we add it as follow up patch? I don't think that I have a device with working suspend to test it and I'm hesitant to add any code that I can't test. > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c > index c0ed60782b11..579dde5e0701 100644 > --- a/drivers/thermal/sun8i_thermal.c > +++ b/drivers/thermal/sun8i_thermal.c > @@ -629,11 +629,63 @@ static const struct of_device_id of_ths_match[] = { > }; > MODULE_DEVICE_TABLE(of, of_ths_match); > > +static int __maybe_unused sun8i_thermal_suspend(struct device *dev) > +{ > + struct ths_device *tmdev; = dev_get_drvdata(dev); > + > + clk_disable(tmdev->mod_clk); > + clk_disable(tmdev->bus_clk); > + > + reset_control_assert(tmdev->reset); > + > + return 0; > +} > + > +static int __maybe_unused sun8i_thermal_resume(struct device *dev) > +{ > + struct ths_device *tmdev; = dev_get_drvdata(dev); > + int error; > + > + error = reset_control_deassert(tmdev->reset); > + if (error) > + return error; > + > + error = clk_enable(tmdev->bus_clk); > + if (error) > + goto assert_reset; > + > + clk_set_rate(tmdev->mod_clk, 24000000); > + error = clk_enable(tmdev->mod_clk); > + if (error) > + goto bus_disable; > + > + sun8i_ths_calibrate(tmdev); > + > + ret = tmdev->chip->init(tmdev); > + if (ret) > + goto mod_disable; > + > + return 0; > + > +mod_disable: > + clk_disable(tmdev->mod_clk); > +bus_disable: > + clk_disable(tmdev->bus_clk); > +assert_reset: > + reset_control_assert(tmdev->reset); > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(sun8i_thermal_pm_ops, > + sun8i_thermal_suspend, sun8i_thermal_resume); > + > static struct platform_driver ths_driver = { > .probe = sun8i_ths_probe, > .remove = sun8i_ths_remove, > .driver = { > .name = "sun8i-thermal", > + .pm = &sun8i_thermal_pm_ops, > .of_match_table = of_ths_match, > }, > }; > > Yangtao
WARNING: multiple messages have this Message-ID (diff)
From: Vasily Khoruzhick <anarsoul@gmail.com> To: Frank Lee <tiny.windzz@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, Amit Kucheria <amit.kucheria@verdurent.com>, Linux PM <linux-pm@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Maxime Ripard <mripard@kernel.org>, Eduardo Valentin <edubezval@gmail.com>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, Zhang Rui <rui.zhang@intel.com>, "David S. Miller" <davem@davemloft.net>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 Date: Wed, 27 Nov 2019 11:48:32 -0800 [thread overview] Message-ID: <CA+E=qVcdwQO3Y8ismmBN-gRVNMs1Thx+TPLqstKM9fYf2_0qFQ@mail.gmail.com> (raw) In-Reply-To: <CAEExFWvG-Af4qtUrxQV4ssNQCVQAmpXfxB+92wX+6ZxUNfX-Jw@mail.gmail.com> On Wed, Nov 27, 2019 at 11:44 AM Frank Lee <tiny.windzz@gmail.com> wrote: > > Hello Vasily, > > Thank you very much for your work on this. > This looks good to me. Thanks! > By the way, I would like to ask comments about adding the following code. Can we add it as follow up patch? I don't think that I have a device with working suspend to test it and I'm hesitant to add any code that I can't test. > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c > index c0ed60782b11..579dde5e0701 100644 > --- a/drivers/thermal/sun8i_thermal.c > +++ b/drivers/thermal/sun8i_thermal.c > @@ -629,11 +629,63 @@ static const struct of_device_id of_ths_match[] = { > }; > MODULE_DEVICE_TABLE(of, of_ths_match); > > +static int __maybe_unused sun8i_thermal_suspend(struct device *dev) > +{ > + struct ths_device *tmdev; = dev_get_drvdata(dev); > + > + clk_disable(tmdev->mod_clk); > + clk_disable(tmdev->bus_clk); > + > + reset_control_assert(tmdev->reset); > + > + return 0; > +} > + > +static int __maybe_unused sun8i_thermal_resume(struct device *dev) > +{ > + struct ths_device *tmdev; = dev_get_drvdata(dev); > + int error; > + > + error = reset_control_deassert(tmdev->reset); > + if (error) > + return error; > + > + error = clk_enable(tmdev->bus_clk); > + if (error) > + goto assert_reset; > + > + clk_set_rate(tmdev->mod_clk, 24000000); > + error = clk_enable(tmdev->mod_clk); > + if (error) > + goto bus_disable; > + > + sun8i_ths_calibrate(tmdev); > + > + ret = tmdev->chip->init(tmdev); > + if (ret) > + goto mod_disable; > + > + return 0; > + > +mod_disable: > + clk_disable(tmdev->mod_clk); > +bus_disable: > + clk_disable(tmdev->bus_clk); > +assert_reset: > + reset_control_assert(tmdev->reset); > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(sun8i_thermal_pm_ops, > + sun8i_thermal_suspend, sun8i_thermal_resume); > + > static struct platform_driver ths_driver = { > .probe = sun8i_ths_probe, > .remove = sun8i_ths_remove, > .driver = { > .name = "sun8i-thermal", > + .pm = &sun8i_thermal_pm_ops, > .of_match_table = of_ths_match, > }, > }; > > Yangtao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-27 19:49 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-27 5:29 [PATCH v6 0/7] add thermal sensor driver for A64, A83T, H3, H5, H6, R40 Vasily Khoruzhick 2019-11-27 5:29 ` Vasily Khoruzhick 2019-11-27 5:29 ` [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 Vasily Khoruzhick 2019-11-27 5:29 ` Vasily Khoruzhick 2019-11-27 11:14 ` Ondřej Jirman 2019-11-27 11:14 ` Ondřej Jirman 2019-11-27 17:35 ` Maxime Ripard 2019-11-27 17:35 ` Maxime Ripard 2019-11-27 19:44 ` Frank Lee 2019-11-27 19:44 ` Frank Lee 2019-11-27 19:48 ` Vasily Khoruzhick [this message] 2019-11-27 19:48 ` Vasily Khoruzhick 2019-11-27 22:24 ` Ondřej Jirman 2019-11-27 22:24 ` Ondřej Jirman 2019-11-28 15:16 ` Frank Lee 2019-11-28 15:16 ` Frank Lee 2019-11-29 0:53 ` Ondřej Jirman 2019-11-29 0:53 ` Ondřej Jirman 2019-11-28 7:42 ` Maxime Ripard 2019-11-28 7:42 ` Maxime Ripard 2019-11-27 17:27 ` Maxime Ripard 2019-11-27 17:27 ` Maxime Ripard 2019-11-28 16:43 ` Frank Lee 2019-11-28 16:43 ` Frank Lee 2019-11-28 17:06 ` Ondřej Jirman 2019-11-28 17:06 ` Ondřej Jirman 2019-11-29 11:46 ` Frank Lee 2019-11-29 11:46 ` Frank Lee 2019-12-02 1:58 ` Ondřej Jirman 2019-12-02 1:58 ` Ondřej Jirman 2019-12-09 18:04 ` Frank Lee 2019-12-09 18:04 ` Frank Lee 2019-11-27 5:29 ` [PATCH v6 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings Vasily Khoruzhick 2019-11-27 5:29 ` Vasily Khoruzhick 2019-11-27 17:44 ` Maxime Ripard 2019-11-27 17:44 ` Maxime Ripard 2019-11-27 18:07 ` Ondřej Jirman 2019-11-27 18:07 ` Ondřej Jirman 2019-11-27 18:52 ` Vasily Khoruzhick 2019-11-27 18:52 ` Vasily Khoruzhick 2019-11-27 20:23 ` Vasily Khoruzhick 2019-11-27 20:23 ` Vasily Khoruzhick 2019-11-28 7:43 ` Maxime Ripard 2019-11-28 7:43 ` Maxime Ripard 2019-11-28 14:35 ` Frank Lee 2019-11-28 14:35 ` Frank Lee 2019-11-28 14:45 ` Frank Lee 2019-11-28 14:45 ` Frank Lee 2019-11-28 16:24 ` Vasily Khoruzhick 2019-11-28 16:24 ` Vasily Khoruzhick 2019-11-27 5:29 ` [PATCH v6 3/7] ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones Vasily Khoruzhick 2019-11-27 5:29 ` Vasily Khoruzhick 2019-11-27 5:29 ` [PATCH v6 4/7] ARM: dts: sun8i-h3: " Vasily Khoruzhick 2019-11-27 5:29 ` Vasily Khoruzhick 2019-11-27 19:40 ` Samuel Holland 2019-11-27 19:40 ` Samuel Holland 2019-11-27 5:29 ` [PATCH v6 5/7] arm64: dts: allwinner: sun50i-h5: " Vasily Khoruzhick 2019-11-27 5:29 ` Vasily Khoruzhick 2019-11-27 5:29 ` [PATCH v6 6/7] arm64: dts: allwinner: sun50i-h6: " Vasily Khoruzhick 2019-11-27 5:29 ` Vasily Khoruzhick 2019-11-27 5:29 ` [PATCH v6 7/7] arm64: dts: allwinner: a64: Add thermal sensors " Vasily Khoruzhick 2019-11-27 5:29 ` Vasily Khoruzhick
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+E=qVcdwQO3Y8ismmBN-gRVNMs1Thx+TPLqstKM9fYf2_0qFQ@mail.gmail.com' \ --to=anarsoul@gmail.com \ --cc=amit.kucheria@verdurent.com \ --cc=daniel.lezcano@linaro.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edubezval@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab+samsung@kernel.org \ --cc=mripard@kernel.org \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=tiny.windzz@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.