From: Shawn Guo <shawnguo@kernel.org> To: Anson Huang <Anson.Huang@nxp.com> Cc: robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH 3/3] ARM: dts: imx6sll: Add Rev A board support Date: Wed, 4 Dec 2019 10:39:21 +0800 [thread overview] Message-ID: <20191204023920.GO9767@dragon> (raw) In-Reply-To: <1573033650-11848-3-git-send-email-Anson.Huang@nxp.com> On Wed, Nov 06, 2019 at 05:47:30PM +0800, Anson Huang wrote: > i.MX6SLL EVK Rev A board is same with latest i.MX6SLL EVK board except > eMMC can ONLY run at HS200 mode, add support for this board. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6sll-evk-reva.dts | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6sll-evk-reva.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 71f08e7..3845bbf 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -557,6 +557,7 @@ dtb-$(CONFIG_SOC_IMX6SL) += \ > imx6sl-warp.dtb > dtb-$(CONFIG_SOC_IMX6SLL) += \ > imx6sll-evk.dtb \ > + imx6sll-evk-reva.dtb \ > imx6sll-kobo-clarahd.dtb > dtb-$(CONFIG_SOC_IMX6SX) += \ > imx6sx-nitrogen6sx.dtb \ > diff --git a/arch/arm/boot/dts/imx6sll-evk-reva.dts b/arch/arm/boot/dts/imx6sll-evk-reva.dts > new file mode 100644 > index 0000000..7ca2563 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6sll-evk-reva.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2016 Freescale Semiconductor, Inc. > + * Copyright 2017-2019 NXP. > + * > + */ > + > +#include "imx6sll-evk.dts" > + > +&usdhc2 { > + compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc"; It looks odd to me that we need to deal with a board level difference with a SoC level compatible. The USDHC compatible should be solely determined by the IP programming model, not the board level capability. Shawn > +}; > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org> To: Anson Huang <Anson.Huang@nxp.com> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] ARM: dts: imx6sll: Add Rev A board support Date: Wed, 4 Dec 2019 10:39:21 +0800 [thread overview] Message-ID: <20191204023920.GO9767@dragon> (raw) In-Reply-To: <1573033650-11848-3-git-send-email-Anson.Huang@nxp.com> On Wed, Nov 06, 2019 at 05:47:30PM +0800, Anson Huang wrote: > i.MX6SLL EVK Rev A board is same with latest i.MX6SLL EVK board except > eMMC can ONLY run at HS200 mode, add support for this board. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6sll-evk-reva.dts | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6sll-evk-reva.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 71f08e7..3845bbf 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -557,6 +557,7 @@ dtb-$(CONFIG_SOC_IMX6SL) += \ > imx6sl-warp.dtb > dtb-$(CONFIG_SOC_IMX6SLL) += \ > imx6sll-evk.dtb \ > + imx6sll-evk-reva.dtb \ > imx6sll-kobo-clarahd.dtb > dtb-$(CONFIG_SOC_IMX6SX) += \ > imx6sx-nitrogen6sx.dtb \ > diff --git a/arch/arm/boot/dts/imx6sll-evk-reva.dts b/arch/arm/boot/dts/imx6sll-evk-reva.dts > new file mode 100644 > index 0000000..7ca2563 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6sll-evk-reva.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2016 Freescale Semiconductor, Inc. > + * Copyright 2017-2019 NXP. > + * > + */ > + > +#include "imx6sll-evk.dts" > + > +&usdhc2 { > + compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc"; It looks odd to me that we need to deal with a board level difference with a SoC level compatible. The USDHC compatible should be solely determined by the IP programming model, not the board level capability. Shawn > +}; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-04 2:39 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-06 9:47 [PATCH 1/3] ARM: dts: imx6sll: Update usdhc fallback compatible to support HS400 mode Anson Huang 2019-11-06 9:47 ` Anson Huang 2019-11-06 9:47 ` [PATCH 2/3] ARM: dts: imx6sll-evk: Add eMMC support Anson Huang 2019-11-06 9:47 ` Anson Huang 2019-11-06 9:47 ` [PATCH 3/3] ARM: dts: imx6sll: Add Rev A board support Anson Huang 2019-11-06 9:47 ` Anson Huang 2019-12-04 2:39 ` Shawn Guo [this message] 2019-12-04 2:39 ` Shawn Guo 2019-12-04 2:52 ` Anson Huang 2019-12-04 2:52 ` Anson Huang 2019-12-04 3:39 ` Shawn Guo 2019-12-04 3:39 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191204023920.GO9767@dragon \ --to=shawnguo@kernel.org \ --cc=Anson.Huang@nxp.com \ --cc=Linux-imx@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.