All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brendan Higgins <brendanhiggins@google.com>
To: jdike@addtoit.com, richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Piotr Sroka <piotrs@cadence.com>
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
	davidgow@google.com, Brendan Higgins <brendanhiggins@google.com>,
	linux-mtd@lists.infradead.org
Subject: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
Date: Wed, 11 Dec 2019 11:27:37 -0800	[thread overview]
Message-ID: <20191211192742.95699-3-brendanhiggins@google.com> (raw)
In-Reply-To: <20191211192742.95699-1-brendanhiggins@google.com>

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 74fb91adeb469..a80a46bb5b8bc 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -452,7 +452,7 @@ config MTD_NAND_PLATFORM
 
 config MTD_NAND_CADENCE
 	tristate "Support Cadence NAND (HPNFC) controller"
-	depends on OF || COMPILE_TEST
+	depends on (OF || COMPILE_TEST) && HAS_IOMEM
 	help
 	  Enable the driver for NAND flash on platforms using a Cadence NAND
 	  controller.
-- 
2.24.0.525.g8f36a354ae-goog


WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: jdike@addtoit.com, richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 Boris Brezillon <bbrezillon@kernel.org>,
	Piotr Sroka <piotrs@cadence.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
	linux-mtd@lists.infradead.org, linux-um@lists.infradead.org,
	linux-kernel@vger.kernel.org, davidgow@google.com
Subject: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
Date: Wed, 11 Dec 2019 11:27:37 -0800	[thread overview]
Message-ID: <20191211192742.95699-3-brendanhiggins@google.com> (raw)
In-Reply-To: <20191211192742.95699-1-brendanhiggins@google.com>

Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:

ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
 drivers/mtd/nand/raw/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 74fb91adeb469..a80a46bb5b8bc 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -452,7 +452,7 @@ config MTD_NAND_PLATFORM
 
 config MTD_NAND_CADENCE
 	tristate "Support Cadence NAND (HPNFC) controller"
-	depends on OF || COMPILE_TEST
+	depends on (OF || COMPILE_TEST) && HAS_IOMEM
 	help
 	  Enable the driver for NAND flash on platforms using a Cadence NAND
 	  controller.
-- 
2.24.0.525.g8f36a354ae-goog


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2019-12-11 19:28 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-16  8:42   ` Linus Walleij
2019-12-16  8:42     ` Linus Walleij
2019-12-16  9:31     ` Arnd Bergmann
2019-12-16  9:31       ` Arnd Bergmann
2019-12-16 10:39   ` Linus Walleij
2019-12-16 10:39     ` Linus Walleij
2020-01-23 22:15     ` Brendan Higgins
2020-01-23 22:15       ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins [this message]
2019-12-11 19:27   ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
2020-01-09 15:23   ` Miquel Raynal
2020-01-09 15:23     ` Miquel Raynal
2020-01-25  2:12     ` Brendan Higgins
2020-01-25  2:12       ` Brendan Higgins
2020-01-25  2:12       ` Brendan Higgins
2020-01-25 15:28       ` Miquel Raynal
2020-01-25 15:28         ` Miquel Raynal
2020-01-25 15:28         ` Miquel Raynal
2020-01-27 19:00         ` Brendan Higgins
2020-01-27 19:00           ` Brendan Higgins
2020-01-30 19:50         ` Miquel Raynal
2020-01-30 19:50           ` Miquel Raynal
2020-01-30 19:55           ` Brendan Higgins
2020-01-30 19:55             ` Brendan Higgins
2020-01-30 19:55             ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-12  5:45   ` Radhey Shyam Pandey
2019-12-12  5:45     ` Radhey Shyam Pandey
2019-12-12  5:45     ` Radhey Shyam Pandey
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
2019-12-20  7:07   ` Herbert Xu
2019-12-20  7:07     ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-12 19:36   ` LABBE Corentin
2019-12-12 19:36     ` LABBE Corentin
2019-12-12 19:36     ` LABBE Corentin
2019-12-20  7:07   ` Herbert Xu
2019-12-20  7:07     ` Herbert Xu
2019-12-20  7:07     ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-14 11:28   ` Greg Kroah-Hartman
2019-12-14 11:28     ` Greg Kroah-Hartman
2019-12-14 11:28     ` Greg Kroah-Hartman
2020-01-23 22:16     ` Brendan Higgins
2020-01-23 22:16       ` Brendan Higgins
2020-01-23 22:16       ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-12  0:12   ` Joel Stanley
2019-12-12  0:12     ` Joel Stanley
2019-12-12  0:30     ` Brendan Higgins
2019-12-12  0:30       ` Brendan Higgins
2019-12-16  6:01       ` Joel Stanley
2019-12-16  6:01         ` Joel Stanley
2020-01-27  9:46       ` Brendan Higgins
2020-01-27  9:46         ` Brendan Higgins
2020-01-31  3:43         ` Joel Stanley
2020-01-31  3:43           ` Joel Stanley
2019-12-11 20:06 ` [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Johannes Berg
2019-12-12  0:35   ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211192742.95699-3-brendanhiggins@google.com \
    --to=brendanhiggins@google.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=bbrezillon@kernel.org \
    --cc=davidgow@google.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-um@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=piotrs@cadence.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.