All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brendan Higgins <brendanhiggins@google.com>
To: jdike@addtoit.com, richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Moses Christopher <moseschristopherb@gmail.com>
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
	davidgow@google.com, Brendan Higgins <brendanhiggins@google.com>,
	devel@driverdev.osuosl.org
Subject: [PATCH v1 6/7] staging: axis-fifo: add unspecified HAS_IOMEM dependency
Date: Wed, 11 Dec 2019 11:27:41 -0800	[thread overview]
Message-ID: <20191211192742.95699-7-brendanhiggins@google.com> (raw)
In-Reply-To: <20191211192742.95699-1-brendanhiggins@google.com>

Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:

ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe':
drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
 drivers/staging/axis-fifo/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/axis-fifo/Kconfig b/drivers/staging/axis-fifo/Kconfig
index 3fffe4d6f327f..f180a8e9f58af 100644
--- a/drivers/staging/axis-fifo/Kconfig
+++ b/drivers/staging/axis-fifo/Kconfig
@@ -4,7 +4,7 @@
 #
 config XIL_AXIS_FIFO
 	tristate "Xilinx AXI-Stream FIFO IP core driver"
-	depends on OF
+	depends on OF && HAS_IOMEM
 	help
 	  This adds support for the Xilinx AXI-Stream FIFO IP core driver.
 	  The AXI Streaming FIFO allows memory mapped access to a AXI Streaming
-- 
2.24.0.525.g8f36a354ae-goog


WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: jdike@addtoit.com, richard@nod.at,
	anton.ivanov@cambridgegreys.com,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Arnd Bergmann <arnd@arndb.de>,
	 Moses Christopher <moseschristopherb@gmail.com>
Cc: devel@driverdev.osuosl.org,
	Brendan Higgins <brendanhiggins@google.com>,
	linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
	davidgow@google.com
Subject: [PATCH v1 6/7] staging: axis-fifo: add unspecified HAS_IOMEM dependency
Date: Wed, 11 Dec 2019 11:27:41 -0800	[thread overview]
Message-ID: <20191211192742.95699-7-brendanhiggins@google.com> (raw)
In-Reply-To: <20191211192742.95699-1-brendanhiggins@google.com>

Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:

ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe':
drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource'

Fix the build error by adding the unspecified dependency.

Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
 drivers/staging/axis-fifo/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/axis-fifo/Kconfig b/drivers/staging/axis-fifo/Kconfig
index 3fffe4d6f327f..f180a8e9f58af 100644
--- a/drivers/staging/axis-fifo/Kconfig
+++ b/drivers/staging/axis-fifo/Kconfig
@@ -4,7 +4,7 @@
 #
 config XIL_AXIS_FIFO
 	tristate "Xilinx AXI-Stream FIFO IP core driver"
-	depends on OF
+	depends on OF && HAS_IOMEM
 	help
 	  This adds support for the Xilinx AXI-Stream FIFO IP core driver.
 	  The AXI Streaming FIFO allows memory mapped access to a AXI Streaming
-- 
2.24.0.525.g8f36a354ae-goog

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2019-12-11 19:28 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-16  8:42   ` Linus Walleij
2019-12-16  8:42     ` Linus Walleij
2019-12-16  9:31     ` Arnd Bergmann
2019-12-16  9:31       ` Arnd Bergmann
2019-12-16 10:39   ` Linus Walleij
2019-12-16 10:39     ` Linus Walleij
2020-01-23 22:15     ` Brendan Higgins
2020-01-23 22:15       ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2020-01-09 15:23   ` Miquel Raynal
2020-01-09 15:23     ` Miquel Raynal
2020-01-25  2:12     ` Brendan Higgins
2020-01-25  2:12       ` Brendan Higgins
2020-01-25  2:12       ` Brendan Higgins
2020-01-25 15:28       ` Miquel Raynal
2020-01-25 15:28         ` Miquel Raynal
2020-01-25 15:28         ` Miquel Raynal
2020-01-27 19:00         ` Brendan Higgins
2020-01-27 19:00           ` Brendan Higgins
2020-01-30 19:50         ` Miquel Raynal
2020-01-30 19:50           ` Miquel Raynal
2020-01-30 19:55           ` Brendan Higgins
2020-01-30 19:55             ` Brendan Higgins
2020-01-30 19:55             ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-12  5:45   ` Radhey Shyam Pandey
2019-12-12  5:45     ` Radhey Shyam Pandey
2019-12-12  5:45     ` Radhey Shyam Pandey
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
2019-12-20  7:07   ` Herbert Xu
2019-12-20  7:07     ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-12 19:36   ` LABBE Corentin
2019-12-12 19:36     ` LABBE Corentin
2019-12-12 19:36     ` LABBE Corentin
2019-12-20  7:07   ` Herbert Xu
2019-12-20  7:07     ` Herbert Xu
2019-12-20  7:07     ` Herbert Xu
2019-12-11 19:27 ` Brendan Higgins [this message]
2019-12-11 19:27   ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
2019-12-14 11:28   ` Greg Kroah-Hartman
2019-12-14 11:28     ` Greg Kroah-Hartman
2019-12-14 11:28     ` Greg Kroah-Hartman
2020-01-23 22:16     ` Brendan Higgins
2020-01-23 22:16       ` Brendan Higgins
2020-01-23 22:16       ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
2019-12-11 19:27   ` Brendan Higgins
2019-12-12  0:12   ` Joel Stanley
2019-12-12  0:12     ` Joel Stanley
2019-12-12  0:30     ` Brendan Higgins
2019-12-12  0:30       ` Brendan Higgins
2019-12-16  6:01       ` Joel Stanley
2019-12-16  6:01         ` Joel Stanley
2020-01-27  9:46       ` Brendan Higgins
2020-01-27  9:46         ` Brendan Higgins
2020-01-31  3:43         ` Joel Stanley
2020-01-31  3:43           ` Joel Stanley
2019-12-11 20:06 ` [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Johannes Berg
2019-12-12  0:35   ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211192742.95699-7-brendanhiggins@google.com \
    --to=brendanhiggins@google.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=davidgow@google.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=moseschristopherb@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.