* [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency
@ 2019-12-13 21:38 Tomasz Duszynski
2019-12-23 16:40 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Duszynski @ 2019-12-13 21:38 UTC (permalink / raw)
To: linux-iio; +Cc: linux-kernel, Tomasz Duszynski
IIO triggered buffer depends on IIO buffer which is missing from Kconfig
file. This should go unnoticed most of the time because there's a
chance something else has already enabled buffers. In some rare cases
though one might experience kbuild warnings about unmet direct
dependencies and build failures due to missing symbols.
Fix this by selecting IIO_BUFFER explicitly.
Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
---
drivers/iio/chemical/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
index fa4586037bb8..0b91de4df8f4 100644
--- a/drivers/iio/chemical/Kconfig
+++ b/drivers/iio/chemical/Kconfig
@@ -65,6 +65,7 @@ config IAQCORE
config PMS7003
tristate "Plantower PMS7003 particulate matter sensor"
depends on SERIAL_DEV_BUS
+ select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
help
Say Y here to build support for the Plantower PMS7003 particulate
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency
2019-12-13 21:38 [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency Tomasz Duszynski
@ 2019-12-23 16:40 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-12-23 16:40 UTC (permalink / raw)
To: Tomasz Duszynski; +Cc: linux-iio, linux-kernel
On Fri, 13 Dec 2019 22:38:08 +0100
Tomasz Duszynski <tduszyns@gmail.com> wrote:
> IIO triggered buffer depends on IIO buffer which is missing from Kconfig
> file. This should go unnoticed most of the time because there's a
> chance something else has already enabled buffers. In some rare cases
> though one might experience kbuild warnings about unmet direct
> dependencies and build failures due to missing symbols.
>
> Fix this by selecting IIO_BUFFER explicitly.
>
> Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
Applied to the fixes-togreg branch of iio.git. Marked for stable and
with the addition of a fixes tag.
Thanks,
Jonathan
> ---
> drivers/iio/chemical/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index fa4586037bb8..0b91de4df8f4 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -65,6 +65,7 @@ config IAQCORE
> config PMS7003
> tristate "Plantower PMS7003 particulate matter sensor"
> depends on SERIAL_DEV_BUS
> + select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
> Say Y here to build support for the Plantower PMS7003 particulate
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-23 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 21:38 [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency Tomasz Duszynski
2019-12-23 16:40 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.