[PATCH v2] multiboot2: set min address for mbi allocation to 0x1000

[PATCH v2] multiboot2: set min address for mbi allocation to 0x1000

[Lukasz Hawrylko]

In some cases GRUB2 allocates multiboot2 structure at 0 address, that is
a confusing behavior. Consumers of that structure can have internal NULL-checks
that will throw an error when get a pointer to data allocated at address 0.
To prevent that, define min address for mbi allocation in x86 and x86_64
platforms.

Signed-off-by: Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 grub-core/loader/multiboot_mbi2.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/grub-core/loader/multiboot_mbi2.c b/grub-core/loader/multiboot_mbi2.c
index 53da78615..18e766c7b 100644
--- a/grub-core/loader/multiboot_mbi2.c
+++ b/grub-core/loader/multiboot_mbi2.c
@@ -48,6 +48,12 @@
 #define HAS_VGA_TEXT 0
 #endif
 
+#if defined (__i386__) || defined (__x86_64__)
+#define MBI_MIN_ADDR 0x1000
+#else
+#define MBI_MIN_ADDR 0
+#endif
+
 struct module
 {
   struct module *next;
@@ -708,7 +714,7 @@ grub_multiboot2_make_mbi (grub_uint32_t *target)
   COMPILE_TIME_ASSERT (MULTIBOOT_TAG_ALIGN % sizeof (grub_properly_aligned_t) == 0);
 
   err = grub_relocator_alloc_chunk_align (grub_multiboot2_relocator, &ch,
-					  0, 0xffffffff - bufsize,
+					  MBI_MIN_ADDR, 0xffffffff - bufsize,
 					  bufsize, MULTIBOOT_TAG_ALIGN,
 					  GRUB_RELOCATOR_PREFERENCE_NONE, 1);
   if (err)
-- 
2.20.1

Re: [PATCH v2] multiboot2: set min address for mbi allocation to 0x1000

[Daniel Kiper]

On Mon, Dec 16, 2019 at 11:15:55AM +0100, Lukasz Hawrylko wrote:
> In some cases GRUB2 allocates multiboot2 structure at 0 address, that is
> a confusing behavior. Consumers of that structure can have internal NULL-checks
> that will throw an error when get a pointer to data allocated at address 0.
> To prevent that, define min address for mbi allocation in x86 and x86_64
> platforms.
>
> Signed-off-by: Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

LGTM. If there are no objections I will commit it by the end of this week.

Thanks,

Daniel