All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeff Chang <richtek.jeff.chang@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com, matthias.bgg@gmail.com,
	alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, jeff_chang@richtek.com
Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver
Date: Tue, 17 Dec 2019 16:17:06 +0100	[thread overview]
Message-ID: <20191217151706.GA3654493@kroah.com> (raw)
In-Reply-To: <1576148934-27701-1-git-send-email-richtek.jeff.chang@gmail.com>

On Thu, Dec 12, 2019 at 07:08:54PM +0800, Jeff Chang wrote:
ookup("ext_dev_io", NULL);
> +	if (!d->rt_root) {
> +		d->rt_root = debugfs_create_dir("ext_dev_io", NULL);
> +		if (!d->rt_root)
> +			return -ENODEV;

No need to ever check the result of this function

> +		d->rt_dir_create = true;
> +	}
> +	d->ic_root = debugfs_create_dir(di->dirname, d->rt_root);
> +	if (!d->ic_root)
> +		goto err_cleanup_rt;

Same here.

> +	if (!debugfs_create_u16("reg", 0644, d->ic_root, &d->reg))
> +		goto err_cleanup_ic;

No need to ever check any result of any debugfs_create_* function.  In
fact, this function doesn't even return a value anymore, so if you tried
to build this against Linus's latest tree, it wouldn't work :)

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeff Chang <richtek.jeff.chang@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	tiwai@suse.com, lgirdwood@gmail.com, jeff_chang@richtek.com,
	broonie@kernel.org, matthias.bgg@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver
Date: Tue, 17 Dec 2019 16:17:06 +0100	[thread overview]
Message-ID: <20191217151706.GA3654493@kroah.com> (raw)
In-Reply-To: <1576148934-27701-1-git-send-email-richtek.jeff.chang@gmail.com>

On Thu, Dec 12, 2019 at 07:08:54PM +0800, Jeff Chang wrote:
ookup("ext_dev_io", NULL);
> +	if (!d->rt_root) {
> +		d->rt_root = debugfs_create_dir("ext_dev_io", NULL);
> +		if (!d->rt_root)
> +			return -ENODEV;

No need to ever check the result of this function

> +		d->rt_dir_create = true;
> +	}
> +	d->ic_root = debugfs_create_dir(di->dirname, d->rt_root);
> +	if (!d->ic_root)
> +		goto err_cleanup_rt;

Same here.

> +	if (!debugfs_create_u16("reg", 0644, d->ic_root, &d->reg))
> +		goto err_cleanup_ic;

No need to ever check any result of any debugfs_create_* function.  In
fact, this function doesn't even return a value anymore, so if you tried
to build this against Linus's latest tree, it wouldn't work :)

thanks,

greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeff Chang <richtek.jeff.chang@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	tiwai@suse.com, lgirdwood@gmail.com, jeff_chang@richtek.com,
	broonie@kernel.org, matthias.bgg@gmail.com, perex@perex.cz,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver
Date: Tue, 17 Dec 2019 16:17:06 +0100	[thread overview]
Message-ID: <20191217151706.GA3654493@kroah.com> (raw)
In-Reply-To: <1576148934-27701-1-git-send-email-richtek.jeff.chang@gmail.com>

On Thu, Dec 12, 2019 at 07:08:54PM +0800, Jeff Chang wrote:
ookup("ext_dev_io", NULL);
> +	if (!d->rt_root) {
> +		d->rt_root = debugfs_create_dir("ext_dev_io", NULL);
> +		if (!d->rt_root)
> +			return -ENODEV;

No need to ever check the result of this function

> +		d->rt_dir_create = true;
> +	}
> +	d->ic_root = debugfs_create_dir(di->dirname, d->rt_root);
> +	if (!d->ic_root)
> +		goto err_cleanup_rt;

Same here.

> +	if (!debugfs_create_u16("reg", 0644, d->ic_root, &d->reg))
> +		goto err_cleanup_ic;

No need to ever check any result of any debugfs_create_* function.  In
fact, this function doesn't even return a value anymore, so if you tried
to build this against Linus's latest tree, it wouldn't work :)

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-12-17 15:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 11:08 [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver Jeff Chang
2019-12-12 11:08 ` Jeff Chang
2019-12-12 11:08 ` [alsa-devel] " Jeff Chang
2019-12-12 11:57 ` Matthias Brugger
2019-12-12 11:57   ` Matthias Brugger
2019-12-12 11:57   ` [alsa-devel] " Matthias Brugger
2019-12-12 12:06 ` Mark Brown
2019-12-12 12:06   ` Mark Brown
2019-12-12 12:06   ` [alsa-devel] " Mark Brown
2019-12-17 15:17 ` Greg KH [this message]
2019-12-17 15:17   ` Greg KH
2019-12-17 15:17   ` [alsa-devel] " Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2019-12-20 10:15 Jeff Chang
2019-12-20 10:15 ` Jeff Chang
2019-12-20 12:11 ` Mark Brown
2019-12-20 12:11   ` Mark Brown
2019-12-23  2:10   ` jeff_chang(張世佳)
2019-12-24 23:51     ` Mark Brown
2019-12-24 23:51       ` Mark Brown
2019-12-25  1:45       ` jeff_chang(張世佳)
2019-12-25 17:45         ` Mark Brown
2019-12-25 17:45           ` Mark Brown
2019-12-12 12:12 Jeff Chang
2019-12-12 12:12 ` Jeff Chang
2019-12-12 14:53 ` Mark Brown
2019-12-12 14:53   ` Mark Brown
2019-12-13  7:36   ` [alsa-devel] " jeff_chang(張世佳)
2019-12-13 11:32     ` Mark Brown
2019-12-13 11:32       ` Mark Brown
2019-12-12  9:12 Jeff Chang
2019-12-12  9:12 ` Jeff Chang
2019-12-12 10:36 ` Jaroslav Kysela
2019-12-12 10:36   ` Jaroslav Kysela
2019-12-12 11:05   ` jeff_chang(張世佳)
2019-12-12  8:29 [PATCH] ASoC: add " Jeff Chang
2019-12-12  8:29 ` Jeff Chang
2019-12-12  8:52 ` Matthias Brugger
2019-12-12  8:52   ` Matthias Brugger
2019-12-12  6:58 Jeff Chang
2019-12-12  6:58 ` Jeff Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217151706.GA3654493@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jeff_chang@richtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=perex@perex.cz \
    --cc=richtek.jeff.chang@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.