From: Mark Brown <broonie@kernel.org>
To: "jeff_chang(張世佳)" <jeff_chang@richtek.com>
Cc: Jeff Chang <richtek.jeff.chang@gmail.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver
Date: Wed, 25 Dec 2019 17:45:27 +0000 [thread overview]
Message-ID: <20191225174527.GB27497@sirena.org.uk> (raw)
In-Reply-To: <938f562e322849328d5a7782b2c1de97@ex1.rt.l>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
On Wed, Dec 25, 2019 at 01:45:43AM +0000, jeff_chang(張世佳) wrote:
> This is adau1997 driver on upstream branch
> @ sound/soc/codecs/adau1997.c
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> * ADAU1977/ADAU1978/ADAU1979 driver
This is the result of an automatic conversion which wasn't
reviewed, it's not ideal.
> It seems not whole comment use c++. Only first line at source file, Right?
Please do it like this:
// SPDX-License-Identifier: GPL-2.0-only
//
// ADAU1977/ADAU1978/ADAU1979 driver
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "jeff_chang(張世佳)" <jeff_chang@richtek.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Jeff Chang <richtek.jeff.chang@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver
Date: Wed, 25 Dec 2019 17:45:27 +0000 [thread overview]
Message-ID: <20191225174527.GB27497@sirena.org.uk> (raw)
In-Reply-To: <938f562e322849328d5a7782b2c1de97@ex1.rt.l>
[-- Attachment #1.1: Type: text/plain, Size: 529 bytes --]
On Wed, Dec 25, 2019 at 01:45:43AM +0000, jeff_chang(張世佳) wrote:
> This is adau1997 driver on upstream branch
> @ sound/soc/codecs/adau1997.c
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> * ADAU1977/ADAU1978/ADAU1979 driver
This is the result of an automatic conversion which wasn't
reviewed, it's not ideal.
> It seems not whole comment use c++. Only first line at source file, Right?
Please do it like this:
// SPDX-License-Identifier: GPL-2.0-only
//
// ADAU1977/ADAU1978/ADAU1979 driver
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "jeff_chang(張世佳)" <jeff_chang@richtek.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Jeff Chang <richtek.jeff.chang@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver
Date: Wed, 25 Dec 2019 17:45:27 +0000 [thread overview]
Message-ID: <20191225174527.GB27497@sirena.org.uk> (raw)
In-Reply-To: <938f562e322849328d5a7782b2c1de97@ex1.rt.l>
[-- Attachment #1.1: Type: text/plain, Size: 529 bytes --]
On Wed, Dec 25, 2019 at 01:45:43AM +0000, jeff_chang(張世佳) wrote:
> This is adau1997 driver on upstream branch
> @ sound/soc/codecs/adau1997.c
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> * ADAU1977/ADAU1978/ADAU1979 driver
This is the result of an automatic conversion which wasn't
reviewed, it's not ideal.
> It seems not whole comment use c++. Only first line at source file, Right?
Please do it like this:
// SPDX-License-Identifier: GPL-2.0-only
//
// ADAU1977/ADAU1978/ADAU1979 driver
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-25 17:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 10:15 [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver Jeff Chang
2019-12-20 10:15 ` Jeff Chang
2019-12-20 10:15 ` [alsa-devel] " Jeff Chang
2019-12-20 12:11 ` Mark Brown
2019-12-20 12:11 ` Mark Brown
2019-12-20 12:11 ` [alsa-devel] " Mark Brown
2019-12-23 2:10 ` jeff_chang(張世佳)
2019-12-24 23:51 ` Mark Brown
2019-12-24 23:51 ` Mark Brown
2019-12-24 23:51 ` [alsa-devel] " Mark Brown
2019-12-25 1:45 ` jeff_chang(張世佳)
2019-12-25 1:45 ` [alsa-devel] " jeff_chang(張世佳)
2019-12-25 17:45 ` Mark Brown [this message]
2019-12-25 17:45 ` Mark Brown
2019-12-25 17:45 ` [alsa-devel] " Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2019-12-12 12:12 Jeff Chang
2019-12-12 12:12 ` Jeff Chang
2019-12-12 14:53 ` Mark Brown
2019-12-12 14:53 ` Mark Brown
2019-12-13 7:36 ` [alsa-devel] " jeff_chang(張世佳)
2019-12-13 11:32 ` Mark Brown
2019-12-13 11:32 ` Mark Brown
2019-12-12 11:08 Jeff Chang
2019-12-12 11:08 ` Jeff Chang
2019-12-12 11:57 ` Matthias Brugger
2019-12-12 11:57 ` Matthias Brugger
2019-12-12 12:06 ` Mark Brown
2019-12-12 12:06 ` Mark Brown
2019-12-17 15:17 ` Greg KH
2019-12-17 15:17 ` Greg KH
2019-12-12 9:12 Jeff Chang
2019-12-12 9:12 ` Jeff Chang
2019-12-12 10:36 ` Jaroslav Kysela
2019-12-12 10:36 ` Jaroslav Kysela
2019-12-12 11:05 ` jeff_chang(張世佳)
2019-12-12 8:29 [PATCH] ASoC: add " Jeff Chang
2019-12-12 8:29 ` Jeff Chang
2019-12-12 8:52 ` Matthias Brugger
2019-12-12 8:52 ` Matthias Brugger
2019-12-12 6:58 Jeff Chang
2019-12-12 6:58 ` Jeff Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191225174527.GB27497@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jeff_chang@richtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=richtek.jeff.chang@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.