All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mt76: fix LED link time failure
@ 2019-12-16 13:18 ` Arnd Bergmann
  0 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2019-12-16 13:18 UTC (permalink / raw)
  To: Felix Fietkau, Lorenzo Bianconi, Kalle Valo, David S. Miller,
	Matthias Brugger
  Cc: Arnd Bergmann, Ryder Lee, Roy Luo, Stanislaw Gruszka,
	linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
	linux-kernel

The mt76_led_cleanup() function is called unconditionally, which
leads to a link error when CONFIG_LEDS is a loadable module or
disabled but mt76 is built-in:

drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'

Use the same trick that is guarding the registration, using an
IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
whether LEDs can be used or not.

Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/mediatek/mt76/mac80211.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
index b9f2a401041a..96018fd65779 100644
--- a/drivers/net/wireless/mediatek/mt76/mac80211.c
+++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
@@ -378,7 +378,8 @@ void mt76_unregister_device(struct mt76_dev *dev)
 {
 	struct ieee80211_hw *hw = dev->hw;
 
-	mt76_led_cleanup(dev);
+	if (IS_ENABLED(CONFIG_MT76_LEDS))
+		mt76_led_cleanup(dev);
 	mt76_tx_status_check(dev, NULL, true);
 	ieee80211_unregister_hw(hw);
 }
-- 
2.20.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] mt76: fix LED link time failure
@ 2019-12-16 13:18 ` Arnd Bergmann
  0 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2019-12-16 13:18 UTC (permalink / raw)
  To: Felix Fietkau, Lorenzo Bianconi, Kalle Valo, David S. Miller,
	Matthias Brugger
  Cc: Ryder Lee, Stanislaw Gruszka, Arnd Bergmann, netdev,
	linux-wireless, linux-kernel, linux-mediatek, Roy Luo,
	linux-arm-kernel

The mt76_led_cleanup() function is called unconditionally, which
leads to a link error when CONFIG_LEDS is a loadable module or
disabled but mt76 is built-in:

drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'

Use the same trick that is guarding the registration, using an
IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
whether LEDs can be used or not.

Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/mediatek/mt76/mac80211.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
index b9f2a401041a..96018fd65779 100644
--- a/drivers/net/wireless/mediatek/mt76/mac80211.c
+++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
@@ -378,7 +378,8 @@ void mt76_unregister_device(struct mt76_dev *dev)
 {
 	struct ieee80211_hw *hw = dev->hw;
 
-	mt76_led_cleanup(dev);
+	if (IS_ENABLED(CONFIG_MT76_LEDS))
+		mt76_led_cleanup(dev);
 	mt76_tx_status_check(dev, NULL, true);
 	ieee80211_unregister_hw(hw);
 }
-- 
2.20.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] mt76: fix LED link time failure
@ 2019-12-16 13:18 ` Arnd Bergmann
  0 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2019-12-16 13:18 UTC (permalink / raw)
  To: Felix Fietkau, Lorenzo Bianconi, Kalle Valo, David S. Miller,
	Matthias Brugger
  Cc: Ryder Lee, Stanislaw Gruszka, Arnd Bergmann, netdev,
	linux-wireless, linux-kernel, linux-mediatek, Roy Luo,
	linux-arm-kernel

The mt76_led_cleanup() function is called unconditionally, which
leads to a link error when CONFIG_LEDS is a loadable module or
disabled but mt76 is built-in:

drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'

Use the same trick that is guarding the registration, using an
IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
whether LEDs can be used or not.

Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/mediatek/mt76/mac80211.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
index b9f2a401041a..96018fd65779 100644
--- a/drivers/net/wireless/mediatek/mt76/mac80211.c
+++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
@@ -378,7 +378,8 @@ void mt76_unregister_device(struct mt76_dev *dev)
 {
 	struct ieee80211_hw *hw = dev->hw;
 
-	mt76_led_cleanup(dev);
+	if (IS_ENABLED(CONFIG_MT76_LEDS))
+		mt76_led_cleanup(dev);
 	mt76_tx_status_check(dev, NULL, true);
 	ieee80211_unregister_hw(hw);
 }
-- 
2.20.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
  2019-12-16 13:18 ` Arnd Bergmann
  (?)
@ 2019-12-17 14:35   ` Kalle Valo
  -1 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2019-12-17 14:35 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Felix Fietkau, Lorenzo Bianconi, David S. Miller,
	Matthias Brugger, Ryder Lee, Roy Luo, Stanislaw Gruszka,
	linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
	linux-kernel

Arnd Bergmann <arnd@arndb.de> writes:

> The mt76_led_cleanup() function is called unconditionally, which
> leads to a link error when CONFIG_LEDS is a loadable module or
> disabled but mt76 is built-in:
>
> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
>
> Use the same trick that is guarding the registration, using an
> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
> whether LEDs can be used or not.
>
> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Felix, as this is a regression in v5.5-rc1 can I take this directly to
wireless-drivers?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
@ 2019-12-17 14:35   ` Kalle Valo
  0 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2019-12-17 14:35 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Ryder Lee, Stanislaw Gruszka, netdev, linux-wireless,
	linux-kernel, Matthias Brugger, linux-mediatek, Roy Luo,
	Lorenzo Bianconi, David S. Miller, linux-arm-kernel,
	Felix Fietkau

Arnd Bergmann <arnd@arndb.de> writes:

> The mt76_led_cleanup() function is called unconditionally, which
> leads to a link error when CONFIG_LEDS is a loadable module or
> disabled but mt76 is built-in:
>
> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
>
> Use the same trick that is guarding the registration, using an
> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
> whether LEDs can be used or not.
>
> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Felix, as this is a regression in v5.5-rc1 can I take this directly to
wireless-drivers?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
@ 2019-12-17 14:35   ` Kalle Valo
  0 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2019-12-17 14:35 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Ryder Lee, Stanislaw Gruszka, netdev, linux-wireless,
	linux-kernel, Matthias Brugger, linux-mediatek, Roy Luo,
	Lorenzo Bianconi, David S. Miller, linux-arm-kernel,
	Felix Fietkau

Arnd Bergmann <arnd@arndb.de> writes:

> The mt76_led_cleanup() function is called unconditionally, which
> leads to a link error when CONFIG_LEDS is a loadable module or
> disabled but mt76 is built-in:
>
> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
>
> Use the same trick that is guarding the registration, using an
> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
> whether LEDs can be used or not.
>
> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Felix, as this is a regression in v5.5-rc1 can I take this directly to
wireless-drivers?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
  2019-12-17 14:35   ` Kalle Valo
  (?)
@ 2019-12-17 14:59     ` Felix Fietkau
  -1 siblings, 0 replies; 12+ messages in thread
From: Felix Fietkau @ 2019-12-17 14:59 UTC (permalink / raw)
  To: Kalle Valo, Arnd Bergmann
  Cc: Lorenzo Bianconi, David S. Miller, Matthias Brugger, Ryder Lee,
	Roy Luo, Stanislaw Gruszka, linux-wireless, netdev,
	linux-arm-kernel, linux-mediatek, linux-kernel

On 2019-12-17 15:35, Kalle Valo wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> 
>> The mt76_led_cleanup() function is called unconditionally, which
>> leads to a link error when CONFIG_LEDS is a loadable module or
>> disabled but mt76 is built-in:
>>
>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
>> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
>>
>> Use the same trick that is guarding the registration, using an
>> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
>> whether LEDs can be used or not.
>>
>> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Felix, as this is a regression in v5.5-rc1 can I take this directly to
> wireless-drivers?
Yes. Please add:
Acked-by: Felix Fietkau <nbd@nbd.name>

- Felix

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
@ 2019-12-17 14:59     ` Felix Fietkau
  0 siblings, 0 replies; 12+ messages in thread
From: Felix Fietkau @ 2019-12-17 14:59 UTC (permalink / raw)
  To: Kalle Valo, Arnd Bergmann
  Cc: Ryder Lee, Stanislaw Gruszka, netdev, linux-wireless,
	linux-kernel, Matthias Brugger, linux-mediatek, Roy Luo,
	Lorenzo Bianconi, David S. Miller, linux-arm-kernel

On 2019-12-17 15:35, Kalle Valo wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> 
>> The mt76_led_cleanup() function is called unconditionally, which
>> leads to a link error when CONFIG_LEDS is a loadable module or
>> disabled but mt76 is built-in:
>>
>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
>> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
>>
>> Use the same trick that is guarding the registration, using an
>> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
>> whether LEDs can be used or not.
>>
>> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Felix, as this is a regression in v5.5-rc1 can I take this directly to
> wireless-drivers?
Yes. Please add:
Acked-by: Felix Fietkau <nbd@nbd.name>

- Felix

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
@ 2019-12-17 14:59     ` Felix Fietkau
  0 siblings, 0 replies; 12+ messages in thread
From: Felix Fietkau @ 2019-12-17 14:59 UTC (permalink / raw)
  To: Kalle Valo, Arnd Bergmann
  Cc: Ryder Lee, Stanislaw Gruszka, netdev, linux-wireless,
	linux-kernel, Matthias Brugger, linux-mediatek, Roy Luo,
	Lorenzo Bianconi, David S. Miller, linux-arm-kernel

On 2019-12-17 15:35, Kalle Valo wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> 
>> The mt76_led_cleanup() function is called unconditionally, which
>> leads to a link error when CONFIG_LEDS is a loadable module or
>> disabled but mt76 is built-in:
>>
>> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
>> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
>>
>> Use the same trick that is guarding the registration, using an
>> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
>> whether LEDs can be used or not.
>>
>> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Felix, as this is a regression in v5.5-rc1 can I take this directly to
> wireless-drivers?
Yes. Please add:
Acked-by: Felix Fietkau <nbd@nbd.name>

- Felix

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
  2019-12-16 13:18 ` Arnd Bergmann
                   ` (3 preceding siblings ...)
  (?)
@ 2019-12-18 18:25 ` Kalle Valo
  -1 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2019-12-18 18:25 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Felix Fietkau, Lorenzo Bianconi, David S. Miller,
	Matthias Brugger, Arnd Bergmann, Ryder Lee, Roy Luo,
	Stanislaw Gruszka, linux-wireless, netdev, linux-arm-kernel,
	linux-mediatek, linux-kernel

Arnd Bergmann <arnd@arndb.de> wrote:

> The mt76_led_cleanup() function is called unconditionally, which
> leads to a link error when CONFIG_LEDS is a loadable module or
> disabled but mt76 is built-in:
> 
> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
> 
> Use the same trick that is guarding the registration, using an
> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
> whether LEDs can be used or not.
> 
> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Felix Fietkau <nbd@nbd.name>

Patch applied to wireless-drivers.git, thanks.

d68f4e43a46f mt76: fix LED link time failure

-- 
https://patchwork.kernel.org/patch/11294195/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
  2019-12-16 13:18 ` Arnd Bergmann
@ 2019-12-18 18:25   ` Kalle Valo
  -1 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2019-12-18 18:25 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Ryder Lee, Stanislaw Gruszka, Arnd Bergmann, netdev,
	linux-wireless, linux-kernel, Matthias Brugger, linux-mediatek,
	Roy Luo, Lorenzo Bianconi, David S. Miller, linux-arm-kernel,
	Felix Fietkau

Arnd Bergmann <arnd@arndb.de> wrote:

> The mt76_led_cleanup() function is called unconditionally, which
> leads to a link error when CONFIG_LEDS is a loadable module or
> disabled but mt76 is built-in:
> 
> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
> 
> Use the same trick that is guarding the registration, using an
> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
> whether LEDs can be used or not.
> 
> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Felix Fietkau <nbd@nbd.name>

Patch applied to wireless-drivers.git, thanks.

d68f4e43a46f mt76: fix LED link time failure

-- 
https://patchwork.kernel.org/patch/11294195/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH] mt76: fix LED link time failure
@ 2019-12-18 18:25   ` Kalle Valo
  0 siblings, 0 replies; 12+ messages in thread
From: Kalle Valo @ 2019-12-18 18:25 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Ryder Lee, Stanislaw Gruszka, Arnd Bergmann, netdev,
	linux-wireless, linux-kernel, Matthias Brugger, linux-mediatek,
	Roy Luo, Lorenzo Bianconi, David S. Miller, linux-arm-kernel,
	Felix Fietkau

Arnd Bergmann <arnd@arndb.de> wrote:

> The mt76_led_cleanup() function is called unconditionally, which
> leads to a link error when CONFIG_LEDS is a loadable module or
> disabled but mt76 is built-in:
> 
> drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device':
> mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister'
> 
> Use the same trick that is guarding the registration, using an
> IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates
> whether LEDs can be used or not.
> 
> Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Felix Fietkau <nbd@nbd.name>

Patch applied to wireless-drivers.git, thanks.

d68f4e43a46f mt76: fix LED link time failure

-- 
https://patchwork.kernel.org/patch/11294195/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-12-18 18:25 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 13:18 [PATCH] mt76: fix LED link time failure Arnd Bergmann
2019-12-16 13:18 ` Arnd Bergmann
2019-12-16 13:18 ` Arnd Bergmann
2019-12-17 14:35 ` Kalle Valo
2019-12-17 14:35   ` Kalle Valo
2019-12-17 14:35   ` Kalle Valo
2019-12-17 14:59   ` Felix Fietkau
2019-12-17 14:59     ` Felix Fietkau
2019-12-17 14:59     ` Felix Fietkau
2019-12-18 18:25 ` Kalle Valo
2019-12-18 18:25   ` Kalle Valo
2019-12-18 18:25 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.