From: Remi Pommarel <repk@triplefau.lt> To: Kishon Vijay Abraham I <kishon@ti.com>, Yue Wang <yue.wang@amlogic.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Andrew Murray <andrew.murray@arm.com>, Neil Armstrong <narmstrong@baylibre.com>, Kevin Hilman <khilman@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Jerome Brunet <jbrunet@baylibre.com>, linux-amlogic@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 5/5] dt-bindings: Add AXG PCIE PHY bindings Date: Wed, 25 Dec 2019 20:02:20 +0100 [thread overview] Message-ID: <20191225190220.GF7304@voidbox> (raw) In-Reply-To: <20191224173942.18160-6-repk@triplefau.lt> On Tue, Dec 24, 2019 at 06:39:42PM +0100, Remi Pommarel wrote: > Add documentation for PCIE PHYs found in AXG SoCs. > > Signed-off-by: Remi Pommarel <repk@triplefau.lt> > --- > .../bindings/phy/amlogic,meson-axg-pcie.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > new file mode 100644 > index 000000000000..c622a1b38ffc > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-pcie.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic AXG PCIE PHY > + > +maintainers: > + - Remi Pommarel <repk@triplefau.lt> > + > +properties: > + compatible: > + enum: > + - amlogic,axg-pcie-phy > + > + reg: > + maxItems: 1 > + > + aml,hhi-gpr: > + maxItems: 1 My bad, I didn't know about devicetree schemas and their verification, I will fix the missing $ref: '/schemas/types.yaml#/definitions/phandle' here, add a description and add the missing include for reset in the example below in v4 along with upcoming comments on the other patches. Sorry about that. > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: phy > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - aml,hhi-gpr > + - resets > + - reset-names > + - "#phy-cells" > + > +examples: > + - | > + pcie_phy: pcie-phy@ff644000 { > + compatible = "amlogic,axg-pcie-phy"; > + reg = <0x0 0xff644000 0x0 0x2000>; > + aml,hhi-gpr = <&sysctrl>; > + resets = <&reset RESET_PCIE_PHY>; > + reset-names = "phy"; > + #phy-cells = <0>; > + }; > -- > 2.24.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Remi Pommarel <repk@triplefau.lt> To: Kishon Vijay Abraham I <kishon@ti.com>, Yue Wang <yue.wang@amlogic.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Andrew Murray <andrew.murray@arm.com>, Neil Armstrong <narmstrong@baylibre.com>, Kevin Hilman <khilman@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet <jbrunet@baylibre.com> Subject: Re: [PATCH v3 5/5] dt-bindings: Add AXG PCIE PHY bindings Date: Wed, 25 Dec 2019 20:02:20 +0100 [thread overview] Message-ID: <20191225190220.GF7304@voidbox> (raw) In-Reply-To: <20191224173942.18160-6-repk@triplefau.lt> On Tue, Dec 24, 2019 at 06:39:42PM +0100, Remi Pommarel wrote: > Add documentation for PCIE PHYs found in AXG SoCs. > > Signed-off-by: Remi Pommarel <repk@triplefau.lt> > --- > .../bindings/phy/amlogic,meson-axg-pcie.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > new file mode 100644 > index 000000000000..c622a1b38ffc > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-pcie.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic AXG PCIE PHY > + > +maintainers: > + - Remi Pommarel <repk@triplefau.lt> > + > +properties: > + compatible: > + enum: > + - amlogic,axg-pcie-phy > + > + reg: > + maxItems: 1 > + > + aml,hhi-gpr: > + maxItems: 1 My bad, I didn't know about devicetree schemas and their verification, I will fix the missing $ref: '/schemas/types.yaml#/definitions/phandle' here, add a description and add the missing include for reset in the example below in v4 along with upcoming comments on the other patches. Sorry about that. > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: phy > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - aml,hhi-gpr > + - resets > + - reset-names > + - "#phy-cells" > + > +examples: > + - | > + pcie_phy: pcie-phy@ff644000 { > + compatible = "amlogic,axg-pcie-phy"; > + reg = <0x0 0xff644000 0x0 0x2000>; > + aml,hhi-gpr = <&sysctrl>; > + resets = <&reset RESET_PCIE_PHY>; > + reset-names = "phy"; > + #phy-cells = <0>; > + }; > -- > 2.24.0 > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-25 18:54 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-24 17:39 [PATCH v3 0/5] PCI: amlogic: Make PCIe working reliably on AXG platforms Remi Pommarel 2019-12-24 17:39 ` Remi Pommarel 2019-12-24 17:39 ` [PATCH v3 1/5] phy: amlogic: Add Amlogic AXG PCIE PHY Driver Remi Pommarel 2019-12-24 17:39 ` Remi Pommarel 2019-12-24 17:39 ` [PATCH v3 2/5] PCI: amlogic: Use AXG PCIE PHY Remi Pommarel 2019-12-24 17:39 ` Remi Pommarel 2019-12-24 17:39 ` [PATCH v3 3/5] arm64: dts: meson-axg: Add PCIE PHY node Remi Pommarel 2019-12-24 17:39 ` Remi Pommarel 2019-12-24 17:39 ` [PATCH v3 4/5] dt-bindings: PCI: meson: Update PCIE bindings documentation Remi Pommarel 2019-12-24 17:39 ` Remi Pommarel 2020-01-04 0:21 ` Rob Herring 2020-01-04 0:21 ` Rob Herring 2019-12-24 17:39 ` [PATCH v3 5/5] dt-bindings: Add AXG PCIE PHY bindings Remi Pommarel 2019-12-24 17:39 ` Remi Pommarel 2019-12-25 19:02 ` Remi Pommarel [this message] 2019-12-25 19:02 ` Remi Pommarel 2019-12-26 20:10 ` Martin Blumenstingl 2019-12-26 20:10 ` Martin Blumenstingl 2020-01-04 0:24 ` Rob Herring 2020-01-04 0:24 ` Rob Herring 2019-12-26 9:57 ` [PATCH v3 0/5] PCI: amlogic: Make PCIe working reliably on AXG platforms Jerome Brunet 2019-12-26 9:57 ` Jerome Brunet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191225190220.GF7304@voidbox \ --to=repk@triplefau.lt \ --cc=andrew.murray@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=jbrunet@baylibre.com \ --cc=khilman@baylibre.com \ --cc=kishon@ti.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=martin.blumenstingl@googlemail.com \ --cc=narmstrong@baylibre.com \ --cc=yue.wang@amlogic.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.