From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org>, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings Date: Mon, 22 Aug 2022 21:57:44 +0300 [thread overview] Message-ID: <201ec2be-f8a0-066a-f7b3-2d6ac58fe674@linaro.org> (raw) In-Reply-To: <677d6387-6225-29c2-3190-8f443222019f@linaro.org> On 11/07/2022 14:37, Krzysztof Kozlowski wrote: > On 10/07/2022 11:00, Dmitry Baryshkov wrote: > > Thank you for your patch. There is something to discuss/improve. > >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + - interrupt-controller >> + - "#interrupt-cells" >> + - power-domains >> + - clocks >> + - clock-names >> + - "#address-cells" >> + - "#size-cells" >> + - ranges >> + >> +patternProperties: >> + "^mdp@(0|[1-9a-f][0-9a-f]*)$": > > You used some unusual pattern. It's just "[0-9a-f]+" - the device > schema's job is not to validate patterns in unit addresses. > > Another question - why do you allow "@0" alone? I think this was c&p from the other file. Dropped the @0 alternative. > >> + type: object >> + # TODO: add reference once the mdp5 is converted >> + >> + "^dsi@(0|[1-9a-f][0-9a-f]*)$": >> + $ref: dsi-controller-main.yaml# > > > Best regards, > Krzysztof -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Stephen Boyd <swboyd@chromium.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings Date: Mon, 22 Aug 2022 21:57:44 +0300 [thread overview] Message-ID: <201ec2be-f8a0-066a-f7b3-2d6ac58fe674@linaro.org> (raw) In-Reply-To: <677d6387-6225-29c2-3190-8f443222019f@linaro.org> On 11/07/2022 14:37, Krzysztof Kozlowski wrote: > On 10/07/2022 11:00, Dmitry Baryshkov wrote: > > Thank you for your patch. There is something to discuss/improve. > >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + - interrupt-controller >> + - "#interrupt-cells" >> + - power-domains >> + - clocks >> + - clock-names >> + - "#address-cells" >> + - "#size-cells" >> + - ranges >> + >> +patternProperties: >> + "^mdp@(0|[1-9a-f][0-9a-f]*)$": > > You used some unusual pattern. It's just "[0-9a-f]+" - the device > schema's job is not to validate patterns in unit addresses. > > Another question - why do you allow "@0" alone? I think this was c&p from the other file. Dropped the @0 alternative. > >> + type: object >> + # TODO: add reference once the mdp5 is converted >> + >> + "^dsi@(0|[1-9a-f][0-9a-f]*)$": >> + $ref: dsi-controller-main.yaml# > > > Best regards, > Krzysztof -- With best wishes Dmitry
next prev parent reply other threads:[~2022-08-22 18:58 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-10 9:00 [PATCH v2 00/11] dt-bindings: display/msm: rework MDSS and DPU bindings Dmitry Baryshkov 2022-07-10 9:00 ` Dmitry Baryshkov 2022-07-10 9:00 ` [PATCH v2 01/11] arm64: dts: qcom: sdm845: rename DPU device node Dmitry Baryshkov 2022-07-10 9:00 ` Dmitry Baryshkov 2022-07-11 8:39 ` Konrad Dybcio 2022-07-11 8:39 ` Konrad Dybcio 2022-07-10 9:00 ` [PATCH v2 02/11] arm64: dts: qcom: sc7180: " Dmitry Baryshkov 2022-07-10 9:00 ` Dmitry Baryshkov 2022-07-11 8:39 ` Konrad Dybcio 2022-07-11 8:39 ` Konrad Dybcio 2022-07-10 9:00 ` [PATCH v2 03/11] arm64: dts: qcom: sm8250: " Dmitry Baryshkov 2022-07-10 9:00 ` Dmitry Baryshkov 2022-07-11 8:40 ` Konrad Dybcio 2022-07-11 8:40 ` Konrad Dybcio 2022-07-10 9:00 ` [PATCH v2 04/11] dt-bindings: display/msm: split qcom, mdss bindings Dmitry Baryshkov 2022-07-10 9:00 ` Dmitry Baryshkov 2022-07-10 16:54 ` Rob Herring 2022-07-10 16:54 ` Rob Herring 2022-07-10 17:00 ` Dmitry Baryshkov 2022-07-10 17:00 ` Dmitry Baryshkov 2022-07-11 11:37 ` Krzysztof Kozlowski 2022-07-11 11:37 ` Krzysztof Kozlowski 2022-08-22 18:57 ` Dmitry Baryshkov [this message] 2022-08-22 18:57 ` Dmitry Baryshkov 2022-07-10 9:00 ` [PATCH v2 05/11] dt-bindings: display/msm: move qcom,sdm845-mdss schema to mdss.yaml Dmitry Baryshkov 2022-07-10 9:00 ` [PATCH v2 05/11] dt-bindings: display/msm: move qcom, sdm845-mdss " Dmitry Baryshkov 2022-07-18 17:53 ` [PATCH v2 05/11] dt-bindings: display/msm: move qcom,sdm845-mdss " Rob Herring 2022-07-18 17:53 ` [PATCH v2 05/11] dt-bindings: display/msm: move qcom, sdm845-mdss " Rob Herring 2022-07-10 9:00 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss " Dmitry Baryshkov 2022-07-10 9:00 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss " Dmitry Baryshkov 2022-07-18 17:56 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss " Rob Herring 2022-07-18 17:56 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss " Rob Herring 2022-08-11 8:25 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss " Krzysztof Kozlowski 2022-08-11 8:25 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss " Krzysztof Kozlowski 2022-08-22 19:04 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss " Dmitry Baryshkov 2022-08-22 19:04 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom, sc7180-mdss " Dmitry Baryshkov 2022-08-23 11:00 ` Krzysztof Kozlowski 2022-08-23 11:00 ` [PATCH v2 06/11] dt-bindings: display/msm: move qcom,sc7180-mdss " Krzysztof Kozlowski 2022-07-10 9:00 ` [PATCH v2 07/11] dt-bindings: display/msm: move qcom,sc7280-mdss " Dmitry Baryshkov 2022-07-10 9:00 ` [PATCH v2 07/11] dt-bindings: display/msm: move qcom, sc7280-mdss " Dmitry Baryshkov 2022-07-18 17:56 ` [PATCH v2 07/11] dt-bindings: display/msm: move qcom,sc7280-mdss " Rob Herring 2022-07-18 17:56 ` [PATCH v2 07/11] dt-bindings: display/msm: move qcom, sc7280-mdss " Rob Herring 2022-07-10 9:00 ` [PATCH v2 08/11] dt-bindings: display/msm: move qcom,qcm2290-mdss " Dmitry Baryshkov 2022-07-10 9:00 ` [PATCH v2 08/11] dt-bindings: display/msm: move qcom, qcm2290-mdss " Dmitry Baryshkov 2022-07-18 17:57 ` [PATCH v2 08/11] dt-bindings: display/msm: move qcom,qcm2290-mdss " Rob Herring 2022-07-18 17:57 ` Rob Herring 2022-07-10 9:00 ` [PATCH v2 09/11] dt-bindings: display/msm: move qcom,msm8998-mdss " Dmitry Baryshkov 2022-07-10 9:00 ` [PATCH v2 09/11] dt-bindings: display/msm: move qcom, msm8998-mdss " Dmitry Baryshkov 2022-07-18 17:58 ` [PATCH v2 09/11] dt-bindings: display/msm: move qcom,msm8998-mdss " Rob Herring 2022-07-18 17:58 ` Rob Herring 2022-07-10 9:00 ` [PATCH v2 10/11] dt-bindings: display/mdm: add gcc-bus clock to dpu-smd845 Dmitry Baryshkov 2022-07-10 9:00 ` Dmitry Baryshkov 2022-07-18 17:58 ` Rob Herring 2022-07-18 17:58 ` Rob Herring 2022-07-10 9:00 ` [PATCH v2 11/11] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml Dmitry Baryshkov 2022-07-10 9:00 ` Dmitry Baryshkov 2022-07-18 17:50 ` Rob Herring 2022-07-18 17:50 ` Rob Herring 2022-08-22 20:13 ` Dmitry Baryshkov 2022-08-22 20:13 ` Dmitry Baryshkov 2022-07-16 15:18 ` (subset) [PATCH v2 00/11] dt-bindings: display/msm: rework MDSS and DPU bindings Bjorn Andersson 2022-07-16 15:18 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201ec2be-f8a0-066a-f7b3-2d6ac58fe674@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=agross@kernel.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@somainline.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.