All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Vineet Gupta <vgupta@synopsys.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, Dave Airlie <airlied@redhat.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Ben Skeggs <bskeggs@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Jiri Slaby <jirislaby@gmail.com>,
	Nick Kossifidis <mickflemm@gmail.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	Dave Jiang <dave.jiang@intel.com>
Subject: [PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implementation)
Date: Wed,  8 Jan 2020 21:05:27 +0100	[thread overview]
Message-ID: <20200108200528.4614-9-krzk__45515.6877332897$1578514071$gmane$org@kernel.org> (raw)
In-Reply-To: <20200108200528.4614-1-krzk@kernel.org>

The ioreadX() helpers have inconsistent interface.  On some architectures
void *__iomem address argument is a pointer to const, on some not.

Implementations of ioreadX() do not modify the memory under the address
so they can be converted to a "const" version for const-safety and
consistency among architectures.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/media/platform/fsl-viu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c
index 81a8faedbba6..991d9dc82749 100644
--- a/drivers/media/platform/fsl-viu.c
+++ b/drivers/media/platform/fsl-viu.c
@@ -34,7 +34,7 @@
 /* Allow building this driver with COMPILE_TEST */
 #if !defined(CONFIG_PPC) && !defined(CONFIG_MICROBLAZE)
 #define out_be32(v, a)	iowrite32be(a, (void __iomem *)v)
-#define in_be32(a)	ioread32be((void __iomem *)a)
+#define in_be32(a)	ioread32be((const void __iomem *)a)
 #endif
 
 #define BUFFER_TIMEOUT		msecs_to_jiffies(500)  /* 0.5 seconds */
-- 
2.17.1

  parent reply	other threads:[~2020-01-08 20:05 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 20:05 [PATCH v2 0/9] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:53   ` Arnd Bergmann
2020-01-08 20:53   ` Arnd Bergmann
2020-01-08 20:53     ` Arnd Bergmann
2020-01-08 20:53     ` Arnd Bergmann
2020-01-08 20:53     ` Arnd Bergmann
2020-01-08 20:53     ` Arnd Bergmann
2020-01-09 12:00   ` Geert Uytterhoeven
2020-01-09 12:00   ` Geert Uytterhoeven
2020-01-09 12:00     ` Geert Uytterhoeven
2020-01-09 12:00     ` Geert Uytterhoeven
2020-01-09 12:00     ` Geert Uytterhoeven
2020-01-09 12:00     ` Geert Uytterhoeven
2020-01-08 20:05 ` [PATCH v2 2/9] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementati Krzysztof Kozlowski
2020-01-10 13:32   ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) Kalle Valo
2020-01-10 13:32     ` Kalle Valo
2020-01-10 13:32     ` Kalle Valo
2020-01-10 13:32     ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-26 15:11     ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implemen Kalle Valo
2020-01-26 15:11     ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-08 20:05 ` Krzysztof Kozlowski
     [not found] ` <20200108200528.4614-1-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-08 20:05   ` [PATCH v2 1/9] iomap: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 2/9] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 9/9] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
     [not found]   ` <20200108200528.4614-4-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-08 20:29     ` Dave Jiang
2020-01-08 20:29   ` Dave Jiang
2020-01-08 20:29     ` Dave Jiang
2020-01-08 20:29     ` Dave Jiang
2020-01-08 20:29     ` Dave Jiang
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-09  6:59   ` Alexey Brodkin
2020-01-09  6:59     ` Alexey Brodkin
2020-01-09  6:59     ` Alexey Brodkin
2020-01-09  6:59     ` Alexey Brodkin
2020-01-09  6:59     ` Alexey Brodkin
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
     [not found]   ` <20200108200528.4614-7-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-09  6:04     ` Thomas Zimmermann
2020-01-09  6:04   ` Thomas Zimmermann
2020-01-09  6:04   ` Thomas Zimmermann
2020-01-09  6:04     ` Thomas Zimmermann
2020-01-09  6:04     ` Thomas Zimmermann
2020-01-09  6:04     ` Thomas Zimmermann
2020-01-09  6:04   ` Thomas Zimmermann
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski [this message]
2020-01-08 20:05 ` [PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation Krzysztof Kozlowski
2020-01-10 13:33   ` [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation) Kalle Valo
2020-01-10 13:33     ` Kalle Valo
2020-01-10 13:33     ` Kalle Valo
2020-01-10 13:33     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20200108200528.4614-9-krzk__45515.6877332897$1578514071$gmane$org@kernel.org' \
    --to=krzk@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=abrodkin@synopsys.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=bskeggs@redhat.com \
    --cc=dalias@libc.org \
    --cc=daniel@ffwll.ch \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jirislaby@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=mattst88@gmail.com \
    --cc=mcgrof@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mickflemm@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=rth@twiddle.net \
    --cc=vgupta@synopsys.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.