All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rich Felker <dalias@libc.org>, Jiri Slaby <jirislaby@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	David Airlie <airlied@linux.ie>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	virtualization@lists.linux-foundation.org,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Networking <netdev@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	Dave Jiang <dave.jiang@intel.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Helge Deller <deller@gmx.de>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Ben Skeggs <bskeggs@redhat.com>,
	ML nouveau <nouveau@lists.freedesktop.org>,
	Dave Airlie <airlied@redhat.com>,
	Matt Turner <mattst88@gmail.com>,
	open
Subject: Re: [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)
Date: Wed, 8 Jan 2020 21:53:54 +0100	[thread overview]
Message-ID: <CAK8P3a2ieH2G5GJvWMev39QkmSFvWSb0sYZ_0L5McR6AZFiayA__23886.1976935127$1578516915$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <20200108200528.4614-2-krzk@kernel.org>

On Wed, Jan 8, 2020 at 9:05 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The ioreadX() and ioreadX_rep() helpers have inconsistent interface.  On
> some architectures void *__iomem address argument is a pointer to const,
> on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for getting this done!

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

> Changes since v1:
> 1. Constify also ioreadX_rep() and mmio_insX(),
> 2. Squash lib+alpha+powerpc+parisc+sh into one patch for bisectability,

The alpha and parisc versions should be independent, I was thinking
you leave them as separate patches, but this work for me too.

I have no real opinion on the other 8 patches, I would have left
them out completely, but they don't hurt either.

         Arnd

  reply	other threads:[~2020-01-08 20:53 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 20:05 [PATCH v2 0/9] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:53   ` Arnd Bergmann [this message]
2020-01-08 20:53   ` Arnd Bergmann
2020-01-08 20:53     ` Arnd Bergmann
2020-01-08 20:53     ` Arnd Bergmann
2020-01-08 20:53     ` Arnd Bergmann
2020-01-08 20:53     ` Arnd Bergmann
2020-01-09 12:00   ` Geert Uytterhoeven
2020-01-09 12:00   ` Geert Uytterhoeven
2020-01-09 12:00     ` Geert Uytterhoeven
2020-01-09 12:00     ` Geert Uytterhoeven
2020-01-09 12:00     ` Geert Uytterhoeven
2020-01-09 12:00     ` Geert Uytterhoeven
2020-01-08 20:05 ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementati Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-10 13:32   ` Kalle Valo
2020-01-10 13:32     ` Kalle Valo
2020-01-10 13:32     ` Kalle Valo
2020-01-10 13:32     ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11   ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implemen Kalle Valo
2020-01-26 15:11     ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11     ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-26 15:11   ` Kalle Valo
2020-01-08 20:05 ` Krzysztof Kozlowski
     [not found] ` <20200108200528.4614-1-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-08 20:05   ` [PATCH v2 1/9] iomap: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 2/9] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 9/9] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
     [not found]   ` <20200108200528.4614-4-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-08 20:29     ` Dave Jiang
2020-01-08 20:29   ` Dave Jiang
2020-01-08 20:29     ` Dave Jiang
2020-01-08 20:29     ` Dave Jiang
2020-01-08 20:29     ` Dave Jiang
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-09  6:59   ` Alexey Brodkin
2020-01-09  6:59     ` Alexey Brodkin
2020-01-09  6:59     ` Alexey Brodkin
2020-01-09  6:59     ` Alexey Brodkin
2020-01-09  6:59     ` Alexey Brodkin
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
     [not found]   ` <20200108200528.4614-7-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-09  6:04     ` Thomas Zimmermann
2020-01-09  6:04   ` Thomas Zimmermann
2020-01-09  6:04   ` Thomas Zimmermann
2020-01-09  6:04     ` Thomas Zimmermann
2020-01-09  6:04     ` Thomas Zimmermann
2020-01-09  6:04     ` Thomas Zimmermann
2020-01-09  6:04   ` Thomas Zimmermann
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation Krzysztof Kozlowski
2020-01-08 20:05   ` [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-08 20:05   ` Krzysztof Kozlowski
2020-01-10 13:33   ` Kalle Valo
2020-01-10 13:33     ` Kalle Valo
2020-01-10 13:33     ` Kalle Valo
2020-01-10 13:33     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a2ieH2G5GJvWMev39QkmSFvWSb0sYZ_0L5McR6AZFiayA__23886.1976935127$1578516915$gmane$org@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=abrodkin@synopsys.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=benh@kernel.crashing.org \
    --cc=bskeggs@redhat.com \
    --cc=dalias@libc.org \
    --cc=dave.jiang@intel.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=jirislaby@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=paulus@samba.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.