From: Thomas Zimmermann <tzimmermann@suse.de>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Vineet Gupta <vgupta@synopsys.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Dave Airlie <airlied@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Ben Skeggs <bskeggs@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jiri Slaby <jirislaby@gmail.com>,
Nick
Subject: Re: [PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation)
Date: Thu, 9 Jan 2020 07:04:36 +0100 [thread overview]
Message-ID: <ff03b149-b825-47f3-f92e-100899bb05fd__25525.0397649192$1578550077$gmane$org@suse.de> (raw)
In-Reply-To: <20200108200528.4614-7-krzk@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1609 bytes --]
Hi
Am 08.01.20 um 21:05 schrieb Krzysztof Kozlowski:
> The ioreadX() helpers have inconsistent interface. On some architectures
> void *__iomem address argument is a pointer to const, on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h
> index aa32aad222c2..6512b3af4fb7 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.h
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h
> @@ -34,9 +34,9 @@
>
> #define MGAG200FB_CONN_LIMIT 1
>
> -#define RREG8(reg) ioread8(((void __iomem *)mdev->rmmio) + (reg))
> +#define RREG8(reg) ioread8(((const void __iomem *)mdev->rmmio) + (reg))
> #define WREG8(reg, v) iowrite8(v, ((void __iomem *)mdev->rmmio) + (reg))
> -#define RREG32(reg) ioread32(((void __iomem *)mdev->rmmio) + (reg))
> +#define RREG32(reg) ioread32(((const void __iomem *)mdev->rmmio) + (reg))
> #define WREG32(reg, v) iowrite32(v, ((void __iomem *)mdev->rmmio) + (reg))
>
> #define ATTR_INDEX 0x1fc0
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-09 6:04 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 20:05 [PATCH v2 0/9] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:53 ` Arnd Bergmann
2020-01-08 20:53 ` Arnd Bergmann
2020-01-08 20:53 ` Arnd Bergmann
2020-01-08 20:53 ` Arnd Bergmann
2020-01-08 20:53 ` Arnd Bergmann
2020-01-08 20:53 ` Arnd Bergmann
2020-01-09 12:00 ` Geert Uytterhoeven
2020-01-09 12:00 ` Geert Uytterhoeven
2020-01-09 12:00 ` Geert Uytterhoeven
2020-01-09 12:00 ` Geert Uytterhoeven
2020-01-09 12:00 ` Geert Uytterhoeven
2020-01-09 12:00 ` Geert Uytterhoeven
2020-01-08 20:05 ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementati Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-10 13:32 ` Kalle Valo
2020-01-10 13:32 ` Kalle Valo
2020-01-10 13:32 ` Kalle Valo
2020-01-10 13:32 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implemen Kalle Valo
2020-01-26 15:11 ` [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-08 20:05 ` Krzysztof Kozlowski
[not found] ` <20200108200528.4614-1-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-08 20:05 ` [PATCH v2 1/9] iomap: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 2/9] net: wireless: rtl818x: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
[not found] ` <20200108200528.4614-4-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-08 20:29 ` Dave Jiang
2020-01-08 20:29 ` Dave Jiang
2020-01-08 20:29 ` Dave Jiang
2020-01-08 20:29 ` Dave Jiang
2020-01-08 20:29 ` Dave Jiang
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-09 6:59 ` Alexey Brodkin
2020-01-09 6:59 ` Alexey Brodkin
2020-01-09 6:59 ` Alexey Brodkin
2020-01-09 6:59 ` Alexey Brodkin
2020-01-09 6:59 ` Alexey Brodkin
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
[not found] ` <20200108200528.4614-7-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-09 6:04 ` Thomas Zimmermann
2020-01-09 6:04 ` Thomas Zimmermann
2020-01-09 6:04 ` Thomas Zimmermann
2020-01-09 6:04 ` Thomas Zimmermann
2020-01-09 6:04 ` Thomas Zimmermann
2020-01-09 6:04 ` Thomas Zimmermann
2020-01-09 6:04 ` Thomas Zimmermann [this message]
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: " Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation Krzysztof Kozlowski
2020-01-08 20:05 ` [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-08 20:05 ` Krzysztof Kozlowski
2020-01-10 13:33 ` Kalle Valo
2020-01-10 13:33 ` Kalle Valo
2020-01-10 13:33 ` Kalle Valo
2020-01-10 13:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ff03b149-b825-47f3-f92e-100899bb05fd__25525.0397649192$1578550077$gmane$org@suse.de' \
--to=tzimmermann@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bskeggs@redhat.com \
--cc=dalias@libc.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=ink@jurassic.park.msu.ru \
--cc=jirislaby@gmail.com \
--cc=krzk@kernel.org \
--cc=mattst88@gmail.com \
--cc=mchehab@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=vgupta@synopsys.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.