All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: miquel.raynal@bootlin.com, richard@nod.at, marek.vasut@gmail.com,
	dwmw2@infradead.org, bbrezillon@kernel.org,
	computersforpeace@gmail.com, vigneshr@ti.com,
	juliensu@mxic.com.tw, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin
Date: Thu, 9 Jan 2020 20:30:55 +0100	[thread overview]
Message-ID: <20200109203055.2370a358@collabora.com> (raw)
In-Reply-To: <1572256527-5074-2-git-send-email-masonccyang@mxic.com.tw>

On Mon, 28 Oct 2019 17:55:24 +0800
Mason Yang <masonccyang@mxic.com.tw> wrote:

>  /* Set default functions */
>  static void nand_set_defaults(struct nand_chip *chip)
>  {
> @@ -5782,8 +5810,8 @@ static int nand_scan_tail(struct nand_chip *chip)
>  	mtd->_read_oob = nand_read_oob;
>  	mtd->_write_oob = nand_write_oob;
>  	mtd->_sync = nand_sync;
> -	mtd->_lock = NULL;
> -	mtd->_unlock = NULL;
> +	mtd->_lock = nand_lock;
> +	mtd->_unlock = nand_unlock;
>  	mtd->_suspend = nand_suspend;
>  	mtd->_resume = nand_resume;
>  	mtd->_reboot = nand_shutdown;
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 4ab9bcc..2430ecd 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -1136,6 +1136,9 @@ struct nand_chip {
>  		const struct nand_manufacturer *desc;
>  		void *priv;
>  	} manufacturer;
> +
> +	int (*_lock)(struct nand_chip *chip, loff_t ofs, uint64_t len);
> +	int (*_unlock)(struct nand_chip *chip, loff_t ofs, uint64_t len);

Please drop this _ prefix.

>  };

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw,
	richard@nod.at, linux-kernel@vger.kernel.org,
	marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
	miquel.raynal@bootlin.com, computersforpeace@gmail.com,
	dwmw2@infradead.org
Subject: Re: [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin
Date: Thu, 9 Jan 2020 20:30:55 +0100	[thread overview]
Message-ID: <20200109203055.2370a358@collabora.com> (raw)
In-Reply-To: <1572256527-5074-2-git-send-email-masonccyang@mxic.com.tw>

On Mon, 28 Oct 2019 17:55:24 +0800
Mason Yang <masonccyang@mxic.com.tw> wrote:

>  /* Set default functions */
>  static void nand_set_defaults(struct nand_chip *chip)
>  {
> @@ -5782,8 +5810,8 @@ static int nand_scan_tail(struct nand_chip *chip)
>  	mtd->_read_oob = nand_read_oob;
>  	mtd->_write_oob = nand_write_oob;
>  	mtd->_sync = nand_sync;
> -	mtd->_lock = NULL;
> -	mtd->_unlock = NULL;
> +	mtd->_lock = nand_lock;
> +	mtd->_unlock = nand_unlock;
>  	mtd->_suspend = nand_suspend;
>  	mtd->_resume = nand_resume;
>  	mtd->_reboot = nand_shutdown;
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 4ab9bcc..2430ecd 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -1136,6 +1136,9 @@ struct nand_chip {
>  		const struct nand_manufacturer *desc;
>  		void *priv;
>  	} manufacturer;
> +
> +	int (*_lock)(struct nand_chip *chip, loff_t ofs, uint64_t len);
> +	int (*_unlock)(struct nand_chip *chip, loff_t ofs, uint64_t len);

Please drop this _ prefix.

>  };

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2020-01-09 19:31 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28  9:55 [PATCH v2 0/4] mtd: rawnand: Add support Macronix Block Protection & deep power down mode Mason Yang
2019-10-28  9:55 ` Mason Yang
2019-10-28  9:55 ` [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin Mason Yang
2019-10-28  9:55   ` Mason Yang
2019-10-30  3:22   ` kbuild test robot
2019-10-30  3:22     ` kbuild test robot
2019-10-30  3:22     ` kbuild test robot
2020-01-09 16:41   ` Miquel Raynal
2020-01-09 16:41     ` Miquel Raynal
2020-02-17  8:05     ` masonccyang
2020-02-17  8:05       ` masonccyang
2020-01-09 19:30   ` Boris Brezillon [this message]
2020-01-09 19:30     ` Boris Brezillon
2020-02-17  8:14     ` masonccyang
2020-02-17  8:14       ` masonccyang
2020-02-17  9:01       ` Miquel Raynal
2020-02-17  9:01         ` Miquel Raynal
2020-02-17  9:22         ` Boris Brezillon
2020-02-17  9:22           ` Boris Brezillon
2020-02-18  3:13         ` masonccyang
2020-02-18  3:13           ` masonccyang
2019-10-28  9:55 ` [PATCH v2 2/4] mtd: rawnand: Add support Macronix Block Protection function Mason Yang
2019-10-28  9:55   ` Mason Yang
2020-01-09 16:47   ` Miquel Raynal
2020-01-09 16:47     ` Miquel Raynal
2020-02-17  8:24     ` masonccyang
2020-02-17  8:24       ` masonccyang
2019-10-28  9:55 ` [PATCH v2 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation Mason Yang
2019-10-28  9:55   ` Mason Yang
2019-10-30  5:56   ` kbuild test robot
2019-10-30  5:56     ` kbuild test robot
2019-10-30  5:56     ` kbuild test robot
2020-01-09 16:53   ` Miquel Raynal
2020-01-09 16:53     ` Miquel Raynal
2019-10-28  9:55 ` [PATCH v2 4/4] mtd: rawnand: Add support Macronix deep power down mode Mason Yang
2019-10-28  9:55   ` Mason Yang
2019-10-31  7:36   ` kbuild test robot
2019-10-31  7:36     ` kbuild test robot
2019-10-31  7:36     ` kbuild test robot
2019-10-31  7:36   ` [RFC PATCH] mtd: rawnand: nand_power_down_op() can be static kbuild test robot
2019-10-31  7:36     ` kbuild test robot
2019-10-31  7:36     ` kbuild test robot
2020-01-09 17:01   ` [PATCH v2 4/4] mtd: rawnand: Add support Macronix deep power down mode Miquel Raynal
2020-01-09 17:01     ` Miquel Raynal
2020-02-21  2:44     ` masonccyang
2020-02-21  2:44       ` masonccyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200109203055.2370a358@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=juliensu@mxic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.