From: Miquel Raynal <miquel.raynal@bootlin.com> To: masonccyang@mxic.com.tw Cc: "Boris Brezillon" <boris.brezillon@collabora.com>, bbrezillon@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, juliensu@mxic.com.tw, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, marek.vasut@gmail.com, richard@nod.at, vigneshr@ti.com Subject: Re: [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin Date: Mon, 17 Feb 2020 10:01:24 +0100 [thread overview] Message-ID: <20200217100124.6ff71191@xps13> (raw) In-Reply-To: <OF505D0437.0130F15A-ON48258511.002C7F75-48258511.002D4341@mxic.com.tw> Hi Mason, masonccyang@mxic.com.tw wrote on Mon, 17 Feb 2020 16:14:23 +0800: > Hi Boris, > > > > > > /* Set default functions */ > > > static void nand_set_defaults(struct nand_chip *chip) > > > { > > > @@ -5782,8 +5810,8 @@ static int nand_scan_tail(struct nand_chip > *chip) > > > mtd->_read_oob = nand_read_oob; > > > mtd->_write_oob = nand_write_oob; > > > mtd->_sync = nand_sync; > > > - mtd->_lock = NULL; > > > - mtd->_unlock = NULL; > > > + mtd->_lock = nand_lock; > > > + mtd->_unlock = nand_unlock; > > > mtd->_suspend = nand_suspend; > > > mtd->_resume = nand_resume; > > > mtd->_reboot = nand_shutdown; > > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > > index 4ab9bcc..2430ecd 100644 > > > --- a/include/linux/mtd/rawnand.h > > > +++ b/include/linux/mtd/rawnand.h > > > @@ -1136,6 +1136,9 @@ struct nand_chip { > > > const struct nand_manufacturer *desc; > > > void *priv; > > > } manufacturer; > > > + > > > + int (*_lock)(struct nand_chip *chip, loff_t ofs, uint64_t len); > > > + int (*_unlock)(struct nand_chip *chip, loff_t ofs, uint64_t len); > > > > Please drop this _ prefix. > > Drop _ prefix of _lock will get compile error due to there is already > defined "struct mutex lock" in struct nand_chip. Right! > > What about keep this _ prefix or patch it to blocklock/blockunlock, > i.e., > int (*blocklock)(struct nand_chip *chip, loff_t ofs, uint64_t len); > int (*blockunlock)(struct nand_chip *chip, loff_t ofs, uint64_t len); What about lock_area() unlock_area() ? Seems more accurate to me, tell me if I'm wrong. > > > thanks for your time & comments. > Mason Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: masonccyang@mxic.com.tw Cc: vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw, richard@nod.at, linux-kernel@vger.kernel.org, marek.vasut@gmail.com, Boris Brezillon <boris.brezillon@collabora.com>, linux-mtd@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org Subject: Re: [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin Date: Mon, 17 Feb 2020 10:01:24 +0100 [thread overview] Message-ID: <20200217100124.6ff71191@xps13> (raw) In-Reply-To: <OF505D0437.0130F15A-ON48258511.002C7F75-48258511.002D4341@mxic.com.tw> Hi Mason, masonccyang@mxic.com.tw wrote on Mon, 17 Feb 2020 16:14:23 +0800: > Hi Boris, > > > > > > /* Set default functions */ > > > static void nand_set_defaults(struct nand_chip *chip) > > > { > > > @@ -5782,8 +5810,8 @@ static int nand_scan_tail(struct nand_chip > *chip) > > > mtd->_read_oob = nand_read_oob; > > > mtd->_write_oob = nand_write_oob; > > > mtd->_sync = nand_sync; > > > - mtd->_lock = NULL; > > > - mtd->_unlock = NULL; > > > + mtd->_lock = nand_lock; > > > + mtd->_unlock = nand_unlock; > > > mtd->_suspend = nand_suspend; > > > mtd->_resume = nand_resume; > > > mtd->_reboot = nand_shutdown; > > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > > index 4ab9bcc..2430ecd 100644 > > > --- a/include/linux/mtd/rawnand.h > > > +++ b/include/linux/mtd/rawnand.h > > > @@ -1136,6 +1136,9 @@ struct nand_chip { > > > const struct nand_manufacturer *desc; > > > void *priv; > > > } manufacturer; > > > + > > > + int (*_lock)(struct nand_chip *chip, loff_t ofs, uint64_t len); > > > + int (*_unlock)(struct nand_chip *chip, loff_t ofs, uint64_t len); > > > > Please drop this _ prefix. > > Drop _ prefix of _lock will get compile error due to there is already > defined "struct mutex lock" in struct nand_chip. Right! > > What about keep this _ prefix or patch it to blocklock/blockunlock, > i.e., > int (*blocklock)(struct nand_chip *chip, loff_t ofs, uint64_t len); > int (*blockunlock)(struct nand_chip *chip, loff_t ofs, uint64_t len); What about lock_area() unlock_area() ? Seems more accurate to me, tell me if I'm wrong. > > > thanks for your time & comments. > Mason Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-17 9:01 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-28 9:55 [PATCH v2 0/4] mtd: rawnand: Add support Macronix Block Protection & deep power down mode Mason Yang 2019-10-28 9:55 ` Mason Yang 2019-10-28 9:55 ` [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin Mason Yang 2019-10-28 9:55 ` Mason Yang 2019-10-30 3:22 ` kbuild test robot 2019-10-30 3:22 ` kbuild test robot 2019-10-30 3:22 ` kbuild test robot 2020-01-09 16:41 ` Miquel Raynal 2020-01-09 16:41 ` Miquel Raynal 2020-02-17 8:05 ` masonccyang 2020-02-17 8:05 ` masonccyang 2020-01-09 19:30 ` Boris Brezillon 2020-01-09 19:30 ` Boris Brezillon 2020-02-17 8:14 ` masonccyang 2020-02-17 8:14 ` masonccyang 2020-02-17 9:01 ` Miquel Raynal [this message] 2020-02-17 9:01 ` Miquel Raynal 2020-02-17 9:22 ` Boris Brezillon 2020-02-17 9:22 ` Boris Brezillon 2020-02-18 3:13 ` masonccyang 2020-02-18 3:13 ` masonccyang 2019-10-28 9:55 ` [PATCH v2 2/4] mtd: rawnand: Add support Macronix Block Protection function Mason Yang 2019-10-28 9:55 ` Mason Yang 2020-01-09 16:47 ` Miquel Raynal 2020-01-09 16:47 ` Miquel Raynal 2020-02-17 8:24 ` masonccyang 2020-02-17 8:24 ` masonccyang 2019-10-28 9:55 ` [PATCH v2 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation Mason Yang 2019-10-28 9:55 ` Mason Yang 2019-10-30 5:56 ` kbuild test robot 2019-10-30 5:56 ` kbuild test robot 2019-10-30 5:56 ` kbuild test robot 2020-01-09 16:53 ` Miquel Raynal 2020-01-09 16:53 ` Miquel Raynal 2019-10-28 9:55 ` [PATCH v2 4/4] mtd: rawnand: Add support Macronix deep power down mode Mason Yang 2019-10-28 9:55 ` Mason Yang 2019-10-31 7:36 ` kbuild test robot 2019-10-31 7:36 ` kbuild test robot 2019-10-31 7:36 ` kbuild test robot 2019-10-31 7:36 ` [RFC PATCH] mtd: rawnand: nand_power_down_op() can be static kbuild test robot 2019-10-31 7:36 ` kbuild test robot 2019-10-31 7:36 ` kbuild test robot 2020-01-09 17:01 ` [PATCH v2 4/4] mtd: rawnand: Add support Macronix deep power down mode Miquel Raynal 2020-01-09 17:01 ` Miquel Raynal 2020-02-21 2:44 ` masonccyang 2020-02-21 2:44 ` masonccyang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200217100124.6ff71191@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=bbrezillon@kernel.org \ --cc=boris.brezillon@collabora.com \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=juliensu@mxic.com.tw \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=masonccyang@mxic.com.tw \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.