All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Steven Price <steven.price@arm.com>
Cc: Qian Cai <cai@lca.pw>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: Re: [PATCH -next] arm64/mm/dump: fix a compilation error
Date: Fri, 10 Jan 2020 16:07:34 +0000	[thread overview]
Message-ID: <20200110160734.GA25891@willie-the-truck> (raw)
In-Reply-To: <20200110153447.GA30104@arm.com>

On Fri, Jan 10, 2020 at 03:34:48PM +0000, Steven Price wrote:
> On Fri, Jan 10, 2020 at 02:51:12PM +0000, Qian Cai wrote:
> > The linux-next commit "x86: mm: avoid allocating struct mm_struct on the
> > stack" [1] introduced a compilation error with "arm64: mm: convert
> > mm/dump.c to use walk_page_range()" [2]. Fixed it by using the new API.
> > 
> > arch/arm64/mm/dump.c:326:38: error: too few arguments to function call,
> > expected 3, have 2
> >         ptdump_walk_pgd(&st.ptdump, info->mm);
> >         ~~~~~~~~~~~~~~~                     ^
> > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> > pgd_t *pgd);
> > ^
> > arch/arm64/mm/dump.c:364:38: error: too few arguments to function call,
> > expected 3, have 2
> >         ptdump_walk_pgd(&st.ptdump, &init_mm);
> >         ~~~~~~~~~~~~~~~                     ^
> > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> > pgd_t *pgd);
> > ^
> > 2 errors generated.
> > 
> > [1] http://lkml.kernel.org/r/20200108145710.34314-1-steven.price@arm.com
> 
> Actually this was in the patch I originally posted - somehow it got
> lost when Andrew picked it up.
> 
> > [2] http://lkml.kernel.org/r/20191218162402.45610-22-steven.price@arm.com
> > 
> > Signed-off-by: Qian Cai <cai@lca.pw>
> 
> Since this matches what I originally wrote... ;)
> 
> Reviewed-by: Steven Price <steven.price@arm.com>

Acked-by: Will Deacon <will@kernel.org>

I'm assuming Andrew will queue this alongside the others.

Thanks,

Will

WARNING: multiple messages have this Message-ID
From: Will Deacon <will@kernel.org>
To: Steven Price <steven.price@arm.com>
Cc: "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>, Qian Cai <cai@lca.pw>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] arm64/mm/dump: fix a compilation error
Date: Fri, 10 Jan 2020 16:07:34 +0000	[thread overview]
Message-ID: <20200110160734.GA25891@willie-the-truck> (raw)
In-Reply-To: <20200110153447.GA30104@arm.com>

On Fri, Jan 10, 2020 at 03:34:48PM +0000, Steven Price wrote:
> On Fri, Jan 10, 2020 at 02:51:12PM +0000, Qian Cai wrote:
> > The linux-next commit "x86: mm: avoid allocating struct mm_struct on the
> > stack" [1] introduced a compilation error with "arm64: mm: convert
> > mm/dump.c to use walk_page_range()" [2]. Fixed it by using the new API.
> > 
> > arch/arm64/mm/dump.c:326:38: error: too few arguments to function call,
> > expected 3, have 2
> >         ptdump_walk_pgd(&st.ptdump, info->mm);
> >         ~~~~~~~~~~~~~~~                     ^
> > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> > pgd_t *pgd);
> > ^
> > arch/arm64/mm/dump.c:364:38: error: too few arguments to function call,
> > expected 3, have 2
> >         ptdump_walk_pgd(&st.ptdump, &init_mm);
> >         ~~~~~~~~~~~~~~~                     ^
> > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> > pgd_t *pgd);
> > ^
> > 2 errors generated.
> > 
> > [1] http://lkml.kernel.org/r/20200108145710.34314-1-steven.price@arm.com
> 
> Actually this was in the patch I originally posted - somehow it got
> lost when Andrew picked it up.
> 
> > [2] http://lkml.kernel.org/r/20191218162402.45610-22-steven.price@arm.com
> > 
> > Signed-off-by: Qian Cai <cai@lca.pw>
> 
> Since this matches what I originally wrote... ;)
> 
> Reviewed-by: Steven Price <steven.price@arm.com>

Acked-by: Will Deacon <will@kernel.org>

I'm assuming Andrew will queue this alongside the others.

Thanks,

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-10 16:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 14:51 Qian Cai
2020-01-10 14:51 ` Qian Cai
2020-01-10 15:34 ` Steven Price
2020-01-10 15:34   ` Steven Price
2020-01-10 15:34   ` Steven Price
2020-01-10 16:07   ` Will Deacon [this message]
2020-01-10 16:07     ` Will Deacon
2020-01-10 16:07     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110160734.GA25891@willie-the-truck \
    --to=will@kernel.org \
    --cc=Catalin.Marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sfr@canb.auug.org.au \
    --cc=steven.price@arm.com \
    --subject='Re: [PATCH -next] arm64/mm/dump: fix a compilation error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.