From: Thomas Zimmermann <tzimmermann@suse.de> To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Cc: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.or, Thomas Zimmermann <tzimmermann@suse.de>, virtualization@lists.linux-foundation.org Subject: [PATCH v2 0/4] Use no_vblank property for drivers without VBLANK Date: Mon, 13 Jan 2020 11:38:18 +0100 [thread overview] Message-ID: <20200113103822.24473-1-tzimmermann@suse.de> (raw) Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over several drivers. Ast already uses the functionality and just needs a cleanup. Cirrus can be converted easily by setting the field in the check() callback and removing the existing VBLANK code. For most other simple-KMS drivers without enable_vblank() and check(), simple-KMS helpers can enable the faked VBLANK by default. The only exception is Xen, which comes with its own VBLANK logic and should rather to disable no_vblank. v2: * document functionality (Daniel) * cleanup ast (Daniel) * let simple-kms handle no_vblank where possible Thomas Zimmermann (4): drm: Document struct drm_crtc_state.no_vblank for faking VBLANK events drm/ast: Set struct drm_crtc_state.no_vblank in atomic_check() drm/cirrus: Let DRM core send VBLANK events drm/simple-kms: Let DRM core send VBLANK events by default drivers/gpu/drm/ast/ast_mode.c | 4 ++-- drivers/gpu/drm/bochs/bochs_kms.c | 9 --------- drivers/gpu/drm/cirrus/cirrus.c | 10 ++-------- drivers/gpu/drm/drm_atomic_helper.c | 4 +++- drivers/gpu/drm/drm_mipi_dbi.c | 9 --------- drivers/gpu/drm/drm_simple_kms_helper.c | 19 +++++++++++++++---- drivers/gpu/drm/tiny/gm12u320.c | 9 --------- drivers/gpu/drm/tiny/ili9225.c | 9 --------- drivers/gpu/drm/tiny/repaper.c | 9 --------- drivers/gpu/drm/tiny/st7586.c | 9 --------- drivers/gpu/drm/udl/udl_modeset.c | 11 ----------- drivers/gpu/drm/xen/xen_drm_front_kms.c | 13 +++++++++++++ include/drm/drm_crtc.h | 9 +++++++-- include/drm/drm_simple_kms_helper.h | 7 +++++-- 14 files changed, 47 insertions(+), 84 deletions(-) -- 2.24.1
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de> To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Cc: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.or, Thomas Zimmermann <tzimmermann@suse.de>, virtualization@lists.linux-foundation.org Subject: [Xen-devel] [PATCH v2 0/4] Use no_vblank property for drivers without VBLANK Date: Mon, 13 Jan 2020 11:38:18 +0100 [thread overview] Message-ID: <20200113103822.24473-1-tzimmermann@suse.de> (raw) Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over several drivers. Ast already uses the functionality and just needs a cleanup. Cirrus can be converted easily by setting the field in the check() callback and removing the existing VBLANK code. For most other simple-KMS drivers without enable_vblank() and check(), simple-KMS helpers can enable the faked VBLANK by default. The only exception is Xen, which comes with its own VBLANK logic and should rather to disable no_vblank. v2: * document functionality (Daniel) * cleanup ast (Daniel) * let simple-kms handle no_vblank where possible Thomas Zimmermann (4): drm: Document struct drm_crtc_state.no_vblank for faking VBLANK events drm/ast: Set struct drm_crtc_state.no_vblank in atomic_check() drm/cirrus: Let DRM core send VBLANK events drm/simple-kms: Let DRM core send VBLANK events by default drivers/gpu/drm/ast/ast_mode.c | 4 ++-- drivers/gpu/drm/bochs/bochs_kms.c | 9 --------- drivers/gpu/drm/cirrus/cirrus.c | 10 ++-------- drivers/gpu/drm/drm_atomic_helper.c | 4 +++- drivers/gpu/drm/drm_mipi_dbi.c | 9 --------- drivers/gpu/drm/drm_simple_kms_helper.c | 19 +++++++++++++++---- drivers/gpu/drm/tiny/gm12u320.c | 9 --------- drivers/gpu/drm/tiny/ili9225.c | 9 --------- drivers/gpu/drm/tiny/repaper.c | 9 --------- drivers/gpu/drm/tiny/st7586.c | 9 --------- drivers/gpu/drm/udl/udl_modeset.c | 11 ----------- drivers/gpu/drm/xen/xen_drm_front_kms.c | 13 +++++++++++++ include/drm/drm_crtc.h | 9 +++++++-- include/drm/drm_simple_kms_helper.h | 7 +++++-- 14 files changed, 47 insertions(+), 84 deletions(-) -- 2.24.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2020-01-13 10:38 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-13 10:38 Thomas Zimmermann [this message] 2020-01-13 10:38 ` [Xen-devel] [PATCH v2 0/4] Use no_vblank property for drivers without VBLANK Thomas Zimmermann 2020-01-13 10:38 ` [PATCH v2 1/4] drm: Document struct drm_crtc_state.no_vblank for faking VBLANK events Thomas Zimmermann 2020-01-13 10:38 ` [Xen-devel] " Thomas Zimmermann 2020-01-13 10:38 ` [PATCH v2 2/4] drm/ast: Set struct drm_crtc_state.no_vblank in atomic_check() Thomas Zimmermann 2020-01-13 10:38 ` [Xen-devel] " Thomas Zimmermann 2020-01-13 10:38 ` [PATCH v2 3/4] drm/cirrus: Let DRM core send VBLANK events Thomas Zimmermann 2020-01-13 10:38 ` [Xen-devel] " Thomas Zimmermann 2020-01-13 10:38 ` [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default Thomas Zimmermann 2020-01-13 10:38 ` [Xen-devel] " Thomas Zimmermann 2020-01-15 12:52 [PATCH v2 0/4] Use no_vblank property for drivers without VBLANK Thomas Zimmermann 2020-01-15 12:52 ` Thomas Zimmermann 2020-01-15 13:04 ` Hans de Goede 2020-01-15 13:04 ` Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200113103822.24473-1-tzimmermann@suse.de \ --to=tzimmermann@suse.de \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=david@lechnology.com \ --cc=dri-devel@lists.freedesktop.or \ --cc=emil.velikov@collabora.com \ --cc=hdegoede@redhat.com \ --cc=kraxel@redhat.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=noralf@tronnes.org \ --cc=oleksandr_andrushchenko@epam.com \ --cc=sam@ravnborg.org \ --cc=sean@poorly.run \ --cc=virtualization@lists.linux-foundation.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.