* [PATCH] drm/i915: Fix i915_error_state_store error defination
@ 2020-01-17 7:34 ` Zhang Xiaoxu
0 siblings, 0 replies; 11+ messages in thread
From: Zhang Xiaoxu @ 2020-01-17 7:34 UTC (permalink / raw)
To: chris, andi.shyti, zhangxiaoxu5, jani.nikula, joonas.lahtinen,
rodrigo.vivi, airlied, daniel
Cc: intel-gfx, dri-devel
Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
capture"), function 'i915_error_state_store' was defined and used with
only one parameter.
But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
with two parameter.
This may lead compile error. This patch fix it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
---
drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
index 9109004956bd..41c1475e1500 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.h
+++ b/drivers/gpu/drm/i915/i915_gpu_error.h
@@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
}
static inline void
-i915_error_state_store(struct drm_i915_private *i915,
- struct i915_gpu_coredump *error)
+i915_error_state_store(struct i915_gpu_coredump *error)
{
}
--
2.17.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [Intel-gfx] [PATCH] drm/i915: Fix i915_error_state_store error defination
@ 2020-01-17 7:34 ` Zhang Xiaoxu
0 siblings, 0 replies; 11+ messages in thread
From: Zhang Xiaoxu @ 2020-01-17 7:34 UTC (permalink / raw)
To: chris, andi.shyti, zhangxiaoxu5, jani.nikula, joonas.lahtinen,
rodrigo.vivi, airlied, daniel
Cc: intel-gfx, dri-devel
Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
capture"), function 'i915_error_state_store' was defined and used with
only one parameter.
But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
with two parameter.
This may lead compile error. This patch fix it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
---
drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
index 9109004956bd..41c1475e1500 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.h
+++ b/drivers/gpu/drm/i915/i915_gpu_error.h
@@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
}
static inline void
-i915_error_state_store(struct drm_i915_private *i915,
- struct i915_gpu_coredump *error)
+i915_error_state_store(struct i915_gpu_coredump *error)
{
}
--
2.17.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] drm/i915: Fix i915_error_state_store error defination
2020-01-17 7:34 ` [Intel-gfx] " Zhang Xiaoxu
@ 2020-01-17 12:15 ` Andi Shyti
-1 siblings, 0 replies; 11+ messages in thread
From: Andi Shyti @ 2020-01-17 12:15 UTC (permalink / raw)
To: Zhang Xiaoxu; +Cc: airlied, intel-gfx, dri-devel, rodrigo.vivi
Hi Zhang,
On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote:
> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
> capture"), function 'i915_error_state_store' was defined and used with
> only one parameter.
>
> But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
> with two parameter.
>
> This may lead compile error. This patch fix it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
I've never been a fan of non human accounts, we had this discussion
already in a different mailing list. Could you please find a
different way of giving credit to your CI system?
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
> drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
> index 9109004956bd..41c1475e1500 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.h
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.h
> @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
> }
>
> static inline void
> -i915_error_state_store(struct drm_i915_private *i915,
> - struct i915_gpu_coredump *error)
> +i915_error_state_store(struct i915_gpu_coredump *error)
ouch! that's an oversight.
Thanks for your patch,
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_error_state_store error defination
@ 2020-01-17 12:15 ` Andi Shyti
0 siblings, 0 replies; 11+ messages in thread
From: Andi Shyti @ 2020-01-17 12:15 UTC (permalink / raw)
To: Zhang Xiaoxu; +Cc: airlied, intel-gfx, dri-devel
Hi Zhang,
On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote:
> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
> capture"), function 'i915_error_state_store' was defined and used with
> only one parameter.
>
> But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
> with two parameter.
>
> This may lead compile error. This patch fix it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
I've never been a fan of non human accounts, we had this discussion
already in a different mailing list. Could you please find a
different way of giving credit to your CI system?
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
> drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
> index 9109004956bd..41c1475e1500 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.h
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.h
> @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
> }
>
> static inline void
> -i915_error_state_store(struct drm_i915_private *i915,
> - struct i915_gpu_coredump *error)
> +i915_error_state_store(struct i915_gpu_coredump *error)
ouch! that's an oversight.
Thanks for your patch,
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drm/i915: Fix i915_error_state_store error defination
2020-01-17 12:15 ` [Intel-gfx] " Andi Shyti
@ 2020-01-17 13:14 ` Jani Nikula
-1 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2020-01-17 13:14 UTC (permalink / raw)
To: Andi Shyti, Zhang Xiaoxu; +Cc: airlied, intel-gfx, dri-devel, rodrigo.vivi
On Fri, 17 Jan 2020, Andi Shyti <andi.shyti@intel.com> wrote:
> Hi Zhang,
>
> On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote:
>> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
>> capture"), function 'i915_error_state_store' was defined and used with
>> only one parameter.
>>
>> But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
>> with two parameter.
>>
>> This may lead compile error. This patch fix it.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>
> I've never been a fan of non human accounts, we had this discussion
> already in a different mailing list. Could you please find a
> different way of giving credit to your CI system?
I don't actually mind for Reported-by credits. The history is full of
things like:
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: syzbot+ec24e95ea483de0a24da@syzkaller.appspotmail.com
Care to reference the discussion?
BR,
Janid.
>
>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>> ---
>> drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
>> index 9109004956bd..41c1475e1500 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.h
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.h
>> @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
>> }
>>
>> static inline void
>> -i915_error_state_store(struct drm_i915_private *i915,
>> - struct i915_gpu_coredump *error)
>> +i915_error_state_store(struct i915_gpu_coredump *error)
>
> ouch! that's an oversight.
>
> Thanks for your patch,
>
> Reviewed-by: Andi Shyti <andi.shyti@intel.com>
>
> Andi
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_error_state_store error defination
@ 2020-01-17 13:14 ` Jani Nikula
0 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2020-01-17 13:14 UTC (permalink / raw)
To: Andi Shyti, Zhang Xiaoxu; +Cc: airlied, intel-gfx, dri-devel
On Fri, 17 Jan 2020, Andi Shyti <andi.shyti@intel.com> wrote:
> Hi Zhang,
>
> On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote:
>> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
>> capture"), function 'i915_error_state_store' was defined and used with
>> only one parameter.
>>
>> But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
>> with two parameter.
>>
>> This may lead compile error. This patch fix it.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>
> I've never been a fan of non human accounts, we had this discussion
> already in a different mailing list. Could you please find a
> different way of giving credit to your CI system?
I don't actually mind for Reported-by credits. The history is full of
things like:
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: syzbot+ec24e95ea483de0a24da@syzkaller.appspotmail.com
Care to reference the discussion?
BR,
Janid.
>
>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>> ---
>> drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
>> index 9109004956bd..41c1475e1500 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.h
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.h
>> @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
>> }
>>
>> static inline void
>> -i915_error_state_store(struct drm_i915_private *i915,
>> - struct i915_gpu_coredump *error)
>> +i915_error_state_store(struct i915_gpu_coredump *error)
>
> ouch! that's an oversight.
>
> Thanks for your patch,
>
> Reviewed-by: Andi Shyti <andi.shyti@intel.com>
>
> Andi
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drm/i915: Fix i915_error_state_store error defination
2020-01-17 13:14 ` [Intel-gfx] " Jani Nikula
@ 2020-01-17 14:05 ` Andi Shyti
-1 siblings, 0 replies; 11+ messages in thread
From: Andi Shyti @ 2020-01-17 14:05 UTC (permalink / raw)
To: Jani Nikula; +Cc: airlied, intel-gfx, dri-devel, rodrigo.vivi, Zhang Xiaoxu
Hi Jani,
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >
> > I've never been a fan of non human accounts, we had this discussion
> > already in a different mailing list. Could you please find a
> > different way of giving credit to your CI system?
>
> I don't actually mind for Reported-by credits. The history is full of
> things like:
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: syzbot+ec24e95ea483de0a24da@syzkaller.appspotmail.com
That's just commit log unnecessary pollution, unwanted mail
reference... no one will ever answer at lkp@intel.com, why
reference it, then?
> Care to reference the discussion?
Here in the Samsung list we had a discussion with another Huawei
developer about the Hulk Robot:
https://lkml.org/lkml/2019/9/4/635
Andi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_error_state_store error defination
@ 2020-01-17 14:05 ` Andi Shyti
0 siblings, 0 replies; 11+ messages in thread
From: Andi Shyti @ 2020-01-17 14:05 UTC (permalink / raw)
To: Jani Nikula; +Cc: airlied, intel-gfx, dri-devel, Zhang Xiaoxu
Hi Jani,
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >
> > I've never been a fan of non human accounts, we had this discussion
> > already in a different mailing list. Could you please find a
> > different way of giving credit to your CI system?
>
> I don't actually mind for Reported-by credits. The history is full of
> things like:
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: syzbot+ec24e95ea483de0a24da@syzkaller.appspotmail.com
That's just commit log unnecessary pollution, unwanted mail
reference... no one will ever answer at lkp@intel.com, why
reference it, then?
> Care to reference the discussion?
Here in the Samsung list we had a discussion with another Huawei
developer about the Hulk Robot:
https://lkml.org/lkml/2019/9/4/635
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Fix i915_error_state_store error defination
2020-01-17 14:05 ` [Intel-gfx] " Andi Shyti
@ 2020-01-17 14:13 ` Jani Nikula
-1 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2020-01-17 14:13 UTC (permalink / raw)
To: Andi Shyti; +Cc: airlied, intel-gfx, dri-devel, rodrigo.vivi, Zhang Xiaoxu
On Fri, 17 Jan 2020, Andi Shyti <andi.shyti@intel.com> wrote:
> Hi Jani,
>
>> >> Reported-by: Hulk Robot <hulkci@huawei.com>
>> >
>> > I've never been a fan of non human accounts, we had this discussion
>> > already in a different mailing list. Could you please find a
>> > different way of giving credit to your CI system?
>>
>> I don't actually mind for Reported-by credits. The history is full of
>> things like:
>>
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Reported-by: syzbot+ec24e95ea483de0a24da@syzkaller.appspotmail.com
>
> That's just commit log unnecessary pollution, unwanted mail
> reference... no one will ever answer at lkp@intel.com, why
> reference it, then?
It's not about that, it's about giving credit to whom credit is due.
>> Care to reference the discussion?
>
> Here in the Samsung list we had a discussion with another Huawei
> developer about the Hulk Robot:
>
> https://lkml.org/lkml/2019/9/4/635
Well, there's no consensus there either.
Again, if they want to use that Reported-by: line, I'm fine with it.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_error_state_store error defination
@ 2020-01-17 14:13 ` Jani Nikula
0 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2020-01-17 14:13 UTC (permalink / raw)
To: Andi Shyti; +Cc: airlied, intel-gfx, dri-devel, Zhang Xiaoxu
On Fri, 17 Jan 2020, Andi Shyti <andi.shyti@intel.com> wrote:
> Hi Jani,
>
>> >> Reported-by: Hulk Robot <hulkci@huawei.com>
>> >
>> > I've never been a fan of non human accounts, we had this discussion
>> > already in a different mailing list. Could you please find a
>> > different way of giving credit to your CI system?
>>
>> I don't actually mind for Reported-by credits. The history is full of
>> things like:
>>
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Reported-by: syzbot+ec24e95ea483de0a24da@syzkaller.appspotmail.com
>
> That's just commit log unnecessary pollution, unwanted mail
> reference... no one will ever answer at lkp@intel.com, why
> reference it, then?
It's not about that, it's about giving credit to whom credit is due.
>> Care to reference the discussion?
>
> Here in the Samsung list we had a discussion with another Huawei
> developer about the Hulk Robot:
>
> https://lkml.org/lkml/2019/9/4/635
Well, there's no consensus there either.
Again, if they want to use that Reported-by: line, I'm fine with it.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix i915_error_state_store error defination
2020-01-17 7:34 ` [Intel-gfx] " Zhang Xiaoxu
(?)
(?)
@ 2020-01-18 2:31 ` Patchwork
-1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-01-18 2:31 UTC (permalink / raw)
To: Zhang Xiaoxu; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix i915_error_state_store error defination
URL : https://patchwork.freedesktop.org/series/72220/
State : failure
== Summary ==
Applying: drm/i915: Fix i915_error_state_store error defination
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/i915_gpu_error.h
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-01-18 2:31 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 7:34 [PATCH] drm/i915: Fix i915_error_state_store error defination Zhang Xiaoxu
2020-01-17 7:34 ` [Intel-gfx] " Zhang Xiaoxu
2020-01-17 12:15 ` Andi Shyti
2020-01-17 12:15 ` [Intel-gfx] " Andi Shyti
2020-01-17 13:14 ` Jani Nikula
2020-01-17 13:14 ` [Intel-gfx] " Jani Nikula
2020-01-17 14:05 ` Andi Shyti
2020-01-17 14:05 ` [Intel-gfx] " Andi Shyti
2020-01-17 14:13 ` Jani Nikula
2020-01-17 14:13 ` [Intel-gfx] " Jani Nikula
2020-01-18 2:31 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.