* [PATCH] arm: Enable VIDEO_BPP32 on pinebook.
@ 2020-01-18 11:15 Vagrant Cascadian
2020-01-18 11:27 ` Anatolij Gustschin
2020-01-18 11:29 ` Maxime Ripard
0 siblings, 2 replies; 6+ messages in thread
From: Vagrant Cascadian @ 2020-01-18 11:15 UTC (permalink / raw)
To: u-boot
Video output on the pinebook LCD screen was broken by:
commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional").
Enable VIDEO_BPP32 which was previously enabled by default when
DM_VIDEO was set.
Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
---
configs/pinebook_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/pinebook_defconfig b/configs/pinebook_defconfig
index 929434e25a..306a6bc6b9 100644
--- a/configs/pinebook_defconfig
+++ b/configs/pinebook_defconfig
@@ -22,3 +22,4 @@ CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
# CONFIG_USB_GADGET is not set
CONFIG_VIDEO_BRIDGE=y
CONFIG_VIDEO_BRIDGE_ANALOGIX_ANX6345=y
+CONFIG_VIDEO_BPP32=y
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm: Enable VIDEO_BPP32 on pinebook. 2020-01-18 11:15 [PATCH] arm: Enable VIDEO_BPP32 on pinebook Vagrant Cascadian @ 2020-01-18 11:27 ` Anatolij Gustschin 2020-01-18 11:29 ` Maxime Ripard 1 sibling, 0 replies; 6+ messages in thread From: Anatolij Gustschin @ 2020-01-18 11:27 UTC (permalink / raw) To: u-boot On Sat, 18 Jan 2020 03:15:15 -0800 Vagrant Cascadian vagrant at debian.org wrote: ... > configs/pinebook_defconfig | 1 + > 1 file changed, 1 insertion(+) Applied to u-boot-video/master, thanks! -- Anatolij ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: Enable VIDEO_BPP32 on pinebook. 2020-01-18 11:15 [PATCH] arm: Enable VIDEO_BPP32 on pinebook Vagrant Cascadian 2020-01-18 11:27 ` Anatolij Gustschin @ 2020-01-18 11:29 ` Maxime Ripard 2020-01-18 20:03 ` Vagrant Cascadian 1 sibling, 1 reply; 6+ messages in thread From: Maxime Ripard @ 2020-01-18 11:29 UTC (permalink / raw) To: u-boot Hi, On Sat, Jan 18, 2020 at 03:15:15AM -0800, Vagrant Cascadian wrote: > Video output on the pinebook LCD screen was broken by: > > commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional"). > > Enable VIDEO_BPP32 which was previously enabled by default when > DM_VIDEO was set. > > Signed-off-by: Vagrant Cascadian <vagrant@debian.org> There's nothing really specific about the pinebook here, but it's needed for pretty much all the boards using DM_VIDEO (on Allwinner at least). You should add a kconfig select / default instead Maxime ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: Enable VIDEO_BPP32 on pinebook. 2020-01-18 11:29 ` Maxime Ripard @ 2020-01-18 20:03 ` Vagrant Cascadian 2020-01-18 22:00 ` Tom Rini 0 siblings, 1 reply; 6+ messages in thread From: Vagrant Cascadian @ 2020-01-18 20:03 UTC (permalink / raw) To: u-boot On 2020-01-18, Maxime Ripard wrote: > On Sat, Jan 18, 2020 at 03:15:15AM -0800, Vagrant Cascadian wrote: >> Video output on the pinebook LCD screen was broken by: >> >> commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional"). >> >> Enable VIDEO_BPP32 which was previously enabled by default when >> DM_VIDEO was set. >> >> Signed-off-by: Vagrant Cascadian <vagrant@debian.org> > > There's nothing really specific about the pinebook here, but it's > needed for pretty much all the boards using DM_VIDEO (on Allwinner at > least). > > You should add a kconfig select / default instead That would basically revert 2cc393f32fd9, and I figured there was a reason for it... It wouldn't surprise me that other systems are affected, but I only notice this issue on the pinebook (most of the systems I use are headless), where it definitely needed to be fixed somehow. If there's a correct and more general fix, please propose it! live well, vagrant ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: Enable VIDEO_BPP32 on pinebook. 2020-01-18 20:03 ` Vagrant Cascadian @ 2020-01-18 22:00 ` Tom Rini 2020-01-22 17:43 ` Maxime Ripard 0 siblings, 1 reply; 6+ messages in thread From: Tom Rini @ 2020-01-18 22:00 UTC (permalink / raw) To: u-boot On Sat, Jan 18, 2020 at 12:03:02PM -0800, Vagrant Cascadian wrote: > On 2020-01-18, Maxime Ripard wrote: > > On Sat, Jan 18, 2020 at 03:15:15AM -0800, Vagrant Cascadian wrote: > >> Video output on the pinebook LCD screen was broken by: > >> > >> commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional"). > >> > >> Enable VIDEO_BPP32 which was previously enabled by default when > >> DM_VIDEO was set. > >> > >> Signed-off-by: Vagrant Cascadian <vagrant@debian.org> > > > > There's nothing really specific about the pinebook here, but it's > > needed for pretty much all the boards using DM_VIDEO (on Allwinner at > > least). > > > > You should add a kconfig select / default instead > > That would basically revert 2cc393f32fd9, and I figured there was a > reason for it... > > It wouldn't surprise me that other systems are affected, but I only > notice this issue on the pinebook (most of the systems I use are > headless), where it definitely needed to be fixed somehow. > > If there's a correct and more general fix, please propose it! Well, looking at 2cc393f32fd9 there are a number of platforms that enable more than one mode. But maybe we should always have at least one mode? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200118/337687df/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: Enable VIDEO_BPP32 on pinebook. 2020-01-18 22:00 ` Tom Rini @ 2020-01-22 17:43 ` Maxime Ripard 0 siblings, 0 replies; 6+ messages in thread From: Maxime Ripard @ 2020-01-22 17:43 UTC (permalink / raw) To: u-boot On Sat, Jan 18, 2020 at 05:00:52PM -0500, Tom Rini wrote: > On Sat, Jan 18, 2020 at 12:03:02PM -0800, Vagrant Cascadian wrote: > > On 2020-01-18, Maxime Ripard wrote: > > > On Sat, Jan 18, 2020 at 03:15:15AM -0800, Vagrant Cascadian wrote: > > >> Video output on the pinebook LCD screen was broken by: > > >> > > >> commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional"). > > >> > > >> Enable VIDEO_BPP32 which was previously enabled by default when > > >> DM_VIDEO was set. > > >> > > >> Signed-off-by: Vagrant Cascadian <vagrant@debian.org> > > > > > > There's nothing really specific about the pinebook here, but it's > > > needed for pretty much all the boards using DM_VIDEO (on Allwinner at > > > least). > > > > > > You should add a kconfig select / default instead > > > > That would basically revert 2cc393f32fd9, and I figured there was a > > reason for it... > > > > It wouldn't surprise me that other systems are affected, but I only > > notice this issue on the pinebook (most of the systems I use are > > headless), where it definitely needed to be fixed somehow. > > > > If there's a correct and more general fix, please propose it! > > Well, looking at 2cc393f32fd9 there are a number of platforms that > enable more than one mode. But maybe we should always have at least one > mode? Yeah, I guess that would make the most sense. My suggestions was actually to enable it platform by platform, which wouldn't be a revert and would fix all the sunxi boards at once. Maxime -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200122/02e543a8/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-22 17:43 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-01-18 11:15 [PATCH] arm: Enable VIDEO_BPP32 on pinebook Vagrant Cascadian 2020-01-18 11:27 ` Anatolij Gustschin 2020-01-18 11:29 ` Maxime Ripard 2020-01-18 20:03 ` Vagrant Cascadian 2020-01-18 22:00 ` Tom Rini 2020-01-22 17:43 ` Maxime Ripard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.