* [PATCH] usb: host: fix implicit declaration error
@ 2020-01-18 23:58 Ansuel Smith
2020-01-19 12:53 ` Greg KH
2020-01-19 15:45 ` Alan Stern
0 siblings, 2 replies; 5+ messages in thread
From: Ansuel Smith @ 2020-01-18 23:58 UTC (permalink / raw)
To: mathias.nyman, gregkh, linux-usb; +Cc: Ansuel Smith
If USB_PCI is not enabled, this error is triggered.
drivers/usb/host/ehci-pci.c:152:7:
error: implicit declaration of function 'usb_amd_quirk_pll_check';
152 | if (usb_amd_quirk_pll_check())
| ^~~~~~~~~~~~~~~~~~~~~~~
| usb_amd_quirk_pll_enable
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
drivers/usb/host/pci-quirks.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/host/pci-quirks.h b/drivers/usb/host/pci-quirks.h
index e729de21f..78dd0fce2 100644
--- a/drivers/usb/host/pci-quirks.h
+++ b/drivers/usb/host/pci-quirks.h
@@ -29,6 +29,10 @@ static inline bool usb_amd_pt_check_port(struct device *device, int port)
{
return false;
}
+static inline bool usb_amd_quirk_pll_check(void)
+{
+ return false;
+}
#endif /* CONFIG_USB_PCI */
#endif /* __LINUX_USB_PCI_QUIRKS_H */
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: host: fix implicit declaration error
2020-01-18 23:58 [PATCH] usb: host: fix implicit declaration error Ansuel Smith
@ 2020-01-19 12:53 ` Greg KH
2020-01-19 13:19 ` ansuelsmth
2020-01-19 15:45 ` Alan Stern
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2020-01-19 12:53 UTC (permalink / raw)
To: Ansuel Smith; +Cc: mathias.nyman, linux-usb
On Sun, Jan 19, 2020 at 12:58:28AM +0100, Ansuel Smith wrote:
> If USB_PCI is not enabled, this error is triggered.
> drivers/usb/host/ehci-pci.c:152:7:
> error: implicit declaration of function 'usb_amd_quirk_pll_check';
> 152 | if (usb_amd_quirk_pll_check())
> | ^~~~~~~~~~~~~~~~~~~~~~~
> | usb_amd_quirk_pll_enable
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Is this a new issue? What commit caused this problem?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] usb: host: fix implicit declaration error
2020-01-19 12:53 ` Greg KH
@ 2020-01-19 13:19 ` ansuelsmth
2020-01-22 7:01 ` 'Greg KH'
0 siblings, 1 reply; 5+ messages in thread
From: ansuelsmth @ 2020-01-19 13:19 UTC (permalink / raw)
To: 'Greg KH'; +Cc: mathias.nyman, linux-usb
> On Sun, Jan 19, 2020 at 12:58:28AM +0100, Ansuel Smith wrote:
> > If USB_PCI is not enabled, this error is triggered.
> > drivers/usb/host/ehci-pci.c:152:7:
> > error: implicit declaration of function 'usb_amd_quirk_pll_check';
> > 152 | if (usb_amd_quirk_pll_check())
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > | usb_amd_quirk_pll_enable
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
>
> Is this a new issue? What commit caused this problem?
>
> thanks,
>
> greg k-h
Looks like this is caused by 4fbb8aa75836c3361987f431d9451aecc1830bdd
and ad93562bdeecdded7d02eaaaf1aa5705ab57b1b7.
Looks like it was never added to the header file else condition.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: host: fix implicit declaration error
2020-01-18 23:58 [PATCH] usb: host: fix implicit declaration error Ansuel Smith
2020-01-19 12:53 ` Greg KH
@ 2020-01-19 15:45 ` Alan Stern
1 sibling, 0 replies; 5+ messages in thread
From: Alan Stern @ 2020-01-19 15:45 UTC (permalink / raw)
To: Ansuel Smith; +Cc: mathias.nyman, gregkh, linux-usb
On Sun, 19 Jan 2020, Ansuel Smith wrote:
> If USB_PCI is not enabled, this error is triggered.
> drivers/usb/host/ehci-pci.c:152:7:
> error: implicit declaration of function 'usb_amd_quirk_pll_check';
> 152 | if (usb_amd_quirk_pll_check())
> | ^~~~~~~~~~~~~~~~~~~~~~~
> | usb_amd_quirk_pll_enable
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
I'm a little confused by this. ehci-pci.c doesn't get compiled
unless CONFIG_USB_EHCI_PCI is set, and that symbol depends on
CONFIG_USB_PCI. So how can this situation ever occur?
Alan Stern
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: host: fix implicit declaration error
2020-01-19 13:19 ` ansuelsmth
@ 2020-01-22 7:01 ` 'Greg KH'
0 siblings, 0 replies; 5+ messages in thread
From: 'Greg KH' @ 2020-01-22 7:01 UTC (permalink / raw)
To: ansuelsmth; +Cc: mathias.nyman, linux-usb
On Sun, Jan 19, 2020 at 02:19:45PM +0100, ansuelsmth@gmail.com wrote:
> > On Sun, Jan 19, 2020 at 12:58:28AM +0100, Ansuel Smith wrote:
> > > If USB_PCI is not enabled, this error is triggered.
> > > drivers/usb/host/ehci-pci.c:152:7:
> > > error: implicit declaration of function 'usb_amd_quirk_pll_check';
> > > 152 | if (usb_amd_quirk_pll_check())
> > > | ^~~~~~~~~~~~~~~~~~~~~~~
> > > | usb_amd_quirk_pll_enable
> > >
> > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> >
> > Is this a new issue? What commit caused this problem?
> >
> > thanks,
> >
> > greg k-h
>
> Looks like this is caused by 4fbb8aa75836c3361987f431d9451aecc1830bdd
> and ad93562bdeecdded7d02eaaaf1aa5705ab57b1b7.
> Looks like it was never added to the header file else condition.
>
So this has been a problem since 2011? What config actually causes this
build problem to occur?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-22 7:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-18 23:58 [PATCH] usb: host: fix implicit declaration error Ansuel Smith
2020-01-19 12:53 ` Greg KH
2020-01-19 13:19 ` ansuelsmth
2020-01-22 7:01 ` 'Greg KH'
2020-01-19 15:45 ` Alan Stern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.