* [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h
@ 2020-02-02 11:00 Heyi Guo
2020-02-03 6:08 ` Thomas Huth
2020-02-03 8:06 ` Igor Mammedov
0 siblings, 2 replies; 3+ messages in thread
From: Heyi Guo @ 2020-02-02 11:00 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Thomas Huth, Michael S. Tsirkin, Paolo Bonzini,
Igor Mammedov, Heyi Guo, wanghaibin.wang
Update comments in tests/qtest/bios-tables-test.c to reflect the
current path of bios-tables-test-allowed-diff.h, which is now under
tests/qtest/ as well.
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
---
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
---
tests/qtest/bios-tables-test.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 3ab4872bd7..b4752c644c 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -14,14 +14,14 @@
* How to add or update the tests:
* Contributor:
* 1. add empty files for new tables, if any, under tests/data/acpi
- * 2. list any changed files in tests/bios-tables-test-allowed-diff.h
+ * 2. list any changed files in tests/qtest/bios-tables-test-allowed-diff.h
* 3. commit the above *before* making changes that affect the tables
*
* Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve conflicts
* in binary commit created in step 6):
*
* After 1-3 above tests will pass but ignore differences with the expected files.
- * You will also notice that tests/bios-tables-test-allowed-diff.h lists
+ * You will also notice that tests/qtest/bios-tables-test-allowed-diff.h lists
* a bunch of files. This is your hint that you need to do the below:
* 4. Run
* make check V=1
@@ -40,14 +40,14 @@
* in commit log.
* 7. Before sending patches to the list (Contributor)
* or before doing a pull request (Maintainer), make sure
- * tests/bios-tables-test-allowed-diff.h is empty - this will ensure
+ * tests/qtest/bios-tables-test-allowed-diff.h is empty - this will ensure
* following changes to ACPI tables will be noticed.
*
* The resulting patchset/pull request then looks like this:
- * - patch 1: list changed files in tests/bios-tables-test-allowed-diff.h.
+ * - patch 1: list changed files in tests/qtest/bios-tables-test-allowed-diff.h.
* - patches 2 - n: real changes, may contain multiple patches.
* - patch n + 1: update golden master binaries and empty
- * tests/bios-tables-test-allowed-diff.h
+ * tests/qtest/bios-tables-test-allowed-diff.h
*/
#include "qemu/osdep.h"
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h
2020-02-02 11:00 [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h Heyi Guo
@ 2020-02-03 6:08 ` Thomas Huth
2020-02-03 8:06 ` Igor Mammedov
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2020-02-03 6:08 UTC (permalink / raw)
To: Heyi Guo, qemu-devel
Cc: Laurent Vivier, wanghaibin.wang, Igor Mammedov, Paolo Bonzini,
Michael S. Tsirkin
On 02/02/2020 12.00, Heyi Guo wrote:
> Update comments in tests/qtest/bios-tables-test.c to reflect the
> current path of bios-tables-test-allowed-diff.h, which is now under
> tests/qtest/ as well.
>
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>
>
> ---
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Laurent Vivier <lvivier@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 3ab4872bd7..b4752c644c 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -14,14 +14,14 @@
> * How to add or update the tests:
> * Contributor:
> * 1. add empty files for new tables, if any, under tests/data/acpi
> - * 2. list any changed files in tests/bios-tables-test-allowed-diff.h
> + * 2. list any changed files in tests/qtest/bios-tables-test-allowed-diff.h
> * 3. commit the above *before* making changes that affect the tables
> *
> * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve conflicts
> * in binary commit created in step 6):
> *
> * After 1-3 above tests will pass but ignore differences with the expected files.
> - * You will also notice that tests/bios-tables-test-allowed-diff.h lists
> + * You will also notice that tests/qtest/bios-tables-test-allowed-diff.h lists
> * a bunch of files. This is your hint that you need to do the below:
> * 4. Run
> * make check V=1
> @@ -40,14 +40,14 @@
> * in commit log.
> * 7. Before sending patches to the list (Contributor)
> * or before doing a pull request (Maintainer), make sure
> - * tests/bios-tables-test-allowed-diff.h is empty - this will ensure
> + * tests/qtest/bios-tables-test-allowed-diff.h is empty - this will ensure
> * following changes to ACPI tables will be noticed.
> *
> * The resulting patchset/pull request then looks like this:
> - * - patch 1: list changed files in tests/bios-tables-test-allowed-diff.h.
> + * - patch 1: list changed files in tests/qtest/bios-tables-test-allowed-diff.h.
> * - patches 2 - n: real changes, may contain multiple patches.
> * - patch n + 1: update golden master binaries and empty
> - * tests/bios-tables-test-allowed-diff.h
> + * tests/qtest/bios-tables-test-allowed-diff.h
> */
>
> #include "qemu/osdep.h"
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h
2020-02-02 11:00 [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h Heyi Guo
2020-02-03 6:08 ` Thomas Huth
@ 2020-02-03 8:06 ` Igor Mammedov
1 sibling, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2020-02-03 8:06 UTC (permalink / raw)
To: Heyi Guo
Cc: Laurent Vivier, Thomas Huth, Michael S. Tsirkin, qemu-devel,
wanghaibin.wang, Paolo Bonzini
On Sun, 2 Feb 2020 19:00:09 +0800
Heyi Guo <guoheyi@huawei.com> wrote:
> Update comments in tests/qtest/bios-tables-test.c to reflect the
> current path of bios-tables-test-allowed-diff.h, which is now under
> tests/qtest/ as well.
>
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
> ---
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Laurent Vivier <lvivier@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 3ab4872bd7..b4752c644c 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -14,14 +14,14 @@
> * How to add or update the tests:
> * Contributor:
> * 1. add empty files for new tables, if any, under tests/data/acpi
> - * 2. list any changed files in tests/bios-tables-test-allowed-diff.h
> + * 2. list any changed files in tests/qtest/bios-tables-test-allowed-diff.h
> * 3. commit the above *before* making changes that affect the tables
> *
> * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve conflicts
> * in binary commit created in step 6):
> *
> * After 1-3 above tests will pass but ignore differences with the expected files.
> - * You will also notice that tests/bios-tables-test-allowed-diff.h lists
> + * You will also notice that tests/qtest/bios-tables-test-allowed-diff.h lists
> * a bunch of files. This is your hint that you need to do the below:
> * 4. Run
> * make check V=1
> @@ -40,14 +40,14 @@
> * in commit log.
> * 7. Before sending patches to the list (Contributor)
> * or before doing a pull request (Maintainer), make sure
> - * tests/bios-tables-test-allowed-diff.h is empty - this will ensure
> + * tests/qtest/bios-tables-test-allowed-diff.h is empty - this will ensure
> * following changes to ACPI tables will be noticed.
> *
> * The resulting patchset/pull request then looks like this:
> - * - patch 1: list changed files in tests/bios-tables-test-allowed-diff.h.
> + * - patch 1: list changed files in tests/qtest/bios-tables-test-allowed-diff.h.
> * - patches 2 - n: real changes, may contain multiple patches.
> * - patch n + 1: update golden master binaries and empty
> - * tests/bios-tables-test-allowed-diff.h
> + * tests/qtest/bios-tables-test-allowed-diff.h
> */
>
> #include "qemu/osdep.h"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-03 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-02 11:00 [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h Heyi Guo
2020-02-03 6:08 ` Thomas Huth
2020-02-03 8:06 ` Igor Mammedov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.