* [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
@ 2020-02-04 16:19 ` Andy Shevchenko
0 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2020-02-04 16:19 UTC (permalink / raw)
To: Laurent Pinchart, Kieran Bingham, dri-devel, linux-renesas-soc
Cc: Andy Shevchenko
Replace with appropriate types.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/platform_data/shmob_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
index fe815d7d9f58..08605fdb2226 100644
--- a/include/linux/platform_data/shmob_drm.h
+++ b/include/linux/platform_data/shmob_drm.h
@@ -10,7 +10,7 @@
#ifndef __SHMOB_DRM_H__
#define __SHMOB_DRM_H__
-#include <linux/kernel.h>
+#include <linux/types.h>
#include <drm/drm_mode.h>
--
2.24.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
@ 2020-02-04 16:19 ` Andy Shevchenko
0 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2020-02-04 16:19 UTC (permalink / raw)
To: Laurent Pinchart, Kieran Bingham, dri-devel, linux-renesas-soc
Cc: Andy Shevchenko
Replace with appropriate types.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/platform_data/shmob_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
index fe815d7d9f58..08605fdb2226 100644
--- a/include/linux/platform_data/shmob_drm.h
+++ b/include/linux/platform_data/shmob_drm.h
@@ -10,7 +10,7 @@
#ifndef __SHMOB_DRM_H__
#define __SHMOB_DRM_H__
-#include <linux/kernel.h>
+#include <linux/types.h>
#include <drm/drm_mode.h>
--
2.24.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
2020-02-04 16:19 ` Andy Shevchenko
@ 2020-02-04 17:39 ` Geert Uytterhoeven
-1 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2020-02-04 17:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Laurent Pinchart, Kieran Bingham, DRI Development, Linux-Renesas
Hi Andy,
On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Replace with appropriate types.h.
Thanks for your patch!
I have only one very short question: why?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
@ 2020-02-04 17:39 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2020-02-04 17:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linux-Renesas, Kieran Bingham, Laurent Pinchart, DRI Development
Hi Andy,
On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Replace with appropriate types.h.
Thanks for your patch!
I have only one very short question: why?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
2020-02-04 17:39 ` Geert Uytterhoeven
@ 2020-02-04 18:26 ` Laurent Pinchart
-1 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2020-02-04 18:26 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Andy Shevchenko, Kieran Bingham, DRI Development, Linux-Renesas
On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > Replace with appropriate types.h.
>
> Thanks for your patch!
>
> I have only one very short question: why?
Likewise :-) The patch itself looks fine, but the commit message is a
bit terse.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
@ 2020-02-04 18:26 ` Laurent Pinchart
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2020-02-04 18:26 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas, Andy Shevchenko, DRI Development, Kieran Bingham
On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > Replace with appropriate types.h.
>
> Thanks for your patch!
>
> I have only one very short question: why?
Likewise :-) The patch itself looks fine, but the commit message is a
bit terse.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
2020-02-04 18:26 ` Laurent Pinchart
@ 2020-02-04 19:30 ` Andy Shevchenko
-1 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2020-02-04 19:30 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Geert Uytterhoeven, Kieran Bingham, DRI Development, Linux-Renesas
On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > Replace with appropriate types.h.
> >
> > Thanks for your patch!
> >
> > I have only one very short question: why?
>
> Likewise :-) The patch itself looks fine, but the commit message is a
> bit terse.
The kernel.h for a long time being a dump of a lot of things. I started
cleaning it up a bit. During this I notice that developers too far too lazy to
use appropriate headers. For platform data kernel.h by definition is not
appropriate.
Any suggestion what should I put to commit message?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
@ 2020-02-04 19:30 ` Andy Shevchenko
0 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2020-02-04 19:30 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linux-Renesas, Kieran Bingham, Geert Uytterhoeven, DRI Development
On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > Replace with appropriate types.h.
> >
> > Thanks for your patch!
> >
> > I have only one very short question: why?
>
> Likewise :-) The patch itself looks fine, but the commit message is a
> bit terse.
The kernel.h for a long time being a dump of a lot of things. I started
cleaning it up a bit. During this I notice that developers too far too lazy to
use appropriate headers. For platform data kernel.h by definition is not
appropriate.
Any suggestion what should I put to commit message?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
2020-02-04 19:30 ` Andy Shevchenko
@ 2020-02-04 19:44 ` Geert Uytterhoeven
-1 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2020-02-04 19:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Laurent Pinchart, Kieran Bingham, DRI Development, Linux-Renesas
Hi Andy,
On Tue, Feb 4, 2020 at 8:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> > On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > > Replace with appropriate types.h.
> > >
> > > Thanks for your patch!
> > >
> > > I have only one very short question: why?
> >
> > Likewise :-) The patch itself looks fine, but the commit message is a
> > bit terse.
>
> The kernel.h for a long time being a dump of a lot of things. I started
> cleaning it up a bit. During this I notice that developers too far too lazy to
> use appropriate headers. For platform data kernel.h by definition is not
> appropriate.
Thanks, that makes perfect sense.
> Any suggestion what should I put to commit message?
I became intrigued by the one-line summary, which seemed to suggest
(according to my interpretation) that including kernel.h is a Real Bad
Thing.
But basically all you wanted to say was:
drm: shmobile: Reduce include dependencies
and:
This file doesn't need everything provided by <linux/kernel.h>.
All it needs are some types, which are provided by <linux/types.h>.
Right?
BTW, <drm/drm_mode.h> already includes <linux/types.h>, but not relying
on implicit includes is indeed a good thing.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] drm: shmobile: Platform data shan't include kernel.h
@ 2020-02-04 19:44 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2020-02-04 19:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linux-Renesas, Kieran Bingham, Laurent Pinchart, DRI Development
Hi Andy,
On Tue, Feb 4, 2020 at 8:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> > On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > > Replace with appropriate types.h.
> > >
> > > Thanks for your patch!
> > >
> > > I have only one very short question: why?
> >
> > Likewise :-) The patch itself looks fine, but the commit message is a
> > bit terse.
>
> The kernel.h for a long time being a dump of a lot of things. I started
> cleaning it up a bit. During this I notice that developers too far too lazy to
> use appropriate headers. For platform data kernel.h by definition is not
> appropriate.
Thanks, that makes perfect sense.
> Any suggestion what should I put to commit message?
I became intrigued by the one-line summary, which seemed to suggest
(according to my interpretation) that including kernel.h is a Real Bad
Thing.
But basically all you wanted to say was:
drm: shmobile: Reduce include dependencies
and:
This file doesn't need everything provided by <linux/kernel.h>.
All it needs are some types, which are provided by <linux/types.h>.
Right?
BTW, <drm/drm_mode.h> already includes <linux/types.h>, but not relying
on implicit includes is indeed a good thing.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-05 8:53 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 16:19 [PATCH v1] drm: shmobile: Platform data shan't include kernel.h Andy Shevchenko
2020-02-04 16:19 ` Andy Shevchenko
2020-02-04 17:39 ` Geert Uytterhoeven
2020-02-04 17:39 ` Geert Uytterhoeven
2020-02-04 18:26 ` Laurent Pinchart
2020-02-04 18:26 ` Laurent Pinchart
2020-02-04 19:30 ` Andy Shevchenko
2020-02-04 19:30 ` Andy Shevchenko
2020-02-04 19:44 ` Geert Uytterhoeven
2020-02-04 19:44 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.