From: Ong Boon Leong <boon.leong.ong@intel.com> To: netdev@vger.kernel.org Cc: Tan Tee Min <tee.min.tan@intel.com>, Voon Weifeng <weifeng.voon@intel.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre TORGUE <alexandre.torgue@st.com>, Jose Abreu <Jose.Abreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Joao Pinto <Joao.Pinto@synopsys.com>, Arnd Bergmann <arnd@arndb.de>, Alexandru Ardelean <alexandru.ardelean@analog.com>, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net v4 0/6] net: stmmac: general fixes for Ethernet functionality Date: Wed, 5 Feb 2020 16:55:04 +0800 [thread overview] Message-ID: <20200205085510.32353-1-boon.leong.ong@intel.com> (raw) Thanks to all feedbacks from community. We updated the patch-series to below:- 1/6: It ensures that the real_num_rx|tx_queues are set in both driver probe() and resume(). So, move the netif_set_real_num_rx|tx_queues() into stmmac_hw_setup(). Use rtnl_lock() and rtnl_unlock() for stmmac_hw_setup() called inside stmmac_resume(). 2/6: It ensures that the previous value of GMAC_VLAN_TAG register is read first before for updating the register. 3/6: Similar to 2/6 patch but it is a fix for XGMAC_VLAN_TAG register as requested by Jose Abreu. 4/6: It ensures the GMAC IP v4.xx and above behaves correctly to:- ip link set <devname> multicast off|on 5/6: Added similar IFF_MULTICAST flag for xgmac2, similar to 4/6. 6/6: It ensures PCI platform data is using plat->phy_interface. Rgds, Boon Leong Changes from v3:- patch 1/6 - add rtnl_lock() and rtnl_unlock() for stmmac_hw_setup() called inside stmmac_resume() patch 3/6 - Added new patch to fix XGMAC_VLAN_TAG register writting v2:- patch 1/5 - added control for rtnl_lock() & rtnl_unlock() to ensure they are used forstmmac_resume() patch 4/5 - added IFF_MULTICAST flag check for xgmac to ensure multicast works correctly. v1:- - Drop v1 patches (1/7, 3/7 & 4/7) that are not valid. Aashish Verma (1): net: stmmac: Fix incorrect location to set real_num_rx|tx_queues Ong Boon Leong (1): net: stmmac: xgmac: fix incorrect XGMAC_VLAN_TAG register writting Tan, Tee Min (2): net: stmmac: fix incorrect GMAC_VLAN_TAG register writting in GMAC4+ net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter Verma, Aashish (1): net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter Voon Weifeng (1): net: stmmac: update pci platform data to use phy_interface drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 9 +++++---- .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 10 +++++++--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++++++---- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 4 files changed, 26 insertions(+), 17 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Ong Boon Leong <boon.leong.ong@intel.com> To: netdev@vger.kernel.org Cc: Jose Abreu <Jose.Abreu@synopsys.com>, Joao Pinto <Joao.Pinto@synopsys.com>, Alexandre TORGUE <alexandre.torgue@st.com>, Voon Weifeng <weifeng.voon@intel.com>, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Arnd Bergmann <arnd@arndb.de>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Tan Tee Min <tee.min.tan@intel.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandru Ardelean <alexandru.ardelean@analog.com>, "David S . Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org Subject: [PATCH net v4 0/6] net: stmmac: general fixes for Ethernet functionality Date: Wed, 5 Feb 2020 16:55:04 +0800 [thread overview] Message-ID: <20200205085510.32353-1-boon.leong.ong@intel.com> (raw) Thanks to all feedbacks from community. We updated the patch-series to below:- 1/6: It ensures that the real_num_rx|tx_queues are set in both driver probe() and resume(). So, move the netif_set_real_num_rx|tx_queues() into stmmac_hw_setup(). Use rtnl_lock() and rtnl_unlock() for stmmac_hw_setup() called inside stmmac_resume(). 2/6: It ensures that the previous value of GMAC_VLAN_TAG register is read first before for updating the register. 3/6: Similar to 2/6 patch but it is a fix for XGMAC_VLAN_TAG register as requested by Jose Abreu. 4/6: It ensures the GMAC IP v4.xx and above behaves correctly to:- ip link set <devname> multicast off|on 5/6: Added similar IFF_MULTICAST flag for xgmac2, similar to 4/6. 6/6: It ensures PCI platform data is using plat->phy_interface. Rgds, Boon Leong Changes from v3:- patch 1/6 - add rtnl_lock() and rtnl_unlock() for stmmac_hw_setup() called inside stmmac_resume() patch 3/6 - Added new patch to fix XGMAC_VLAN_TAG register writting v2:- patch 1/5 - added control for rtnl_lock() & rtnl_unlock() to ensure they are used forstmmac_resume() patch 4/5 - added IFF_MULTICAST flag check for xgmac to ensure multicast works correctly. v1:- - Drop v1 patches (1/7, 3/7 & 4/7) that are not valid. Aashish Verma (1): net: stmmac: Fix incorrect location to set real_num_rx|tx_queues Ong Boon Leong (1): net: stmmac: xgmac: fix incorrect XGMAC_VLAN_TAG register writting Tan, Tee Min (2): net: stmmac: fix incorrect GMAC_VLAN_TAG register writting in GMAC4+ net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter Verma, Aashish (1): net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter Voon Weifeng (1): net: stmmac: update pci platform data to use phy_interface drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 9 +++++---- .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 10 +++++++--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++++++---- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 4 files changed, 26 insertions(+), 17 deletions(-) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-02-05 8:55 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-05 8:55 Ong Boon Leong [this message] 2020-02-05 8:55 ` [PATCH net v4 0/6] net: stmmac: general fixes for Ethernet functionality Ong Boon Leong 2020-02-05 8:55 ` [PATCH net v4 1/6] net: stmmac: Fix incorrect location to set real_num_rx|tx_queues Ong Boon Leong 2020-02-05 8:55 ` Ong Boon Leong 2020-02-05 13:39 ` David Miller 2020-02-05 13:39 ` David Miller 2020-02-07 7:21 ` Ong, Boon Leong 2020-02-07 7:21 ` Ong, Boon Leong 2020-02-05 8:55 ` [PATCH net v4 2/6] net: stmmac: fix incorrect GMAC_VLAN_TAG register writting in GMAC4+ Ong Boon Leong 2020-02-05 8:55 ` Ong Boon Leong 2020-02-05 8:55 ` [PATCH net v4 3/6] net: stmmac: xgmac: fix incorrect XGMAC_VLAN_TAG register writting Ong Boon Leong 2020-02-05 8:55 ` Ong Boon Leong 2020-02-05 8:55 ` [PATCH net v4 4/6] net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter Ong Boon Leong 2020-02-05 8:55 ` Ong Boon Leong 2020-02-05 8:55 ` [PATCH net v4 5/6] net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter Ong Boon Leong 2020-02-05 8:55 ` Ong Boon Leong 2020-02-05 8:55 ` [PATCH net v4 6/6] net: stmmac: update pci platform data to use phy_interface Ong Boon Leong 2020-02-05 8:55 ` Ong Boon Leong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200205085510.32353-1-boon.leong.ong@intel.com \ --to=boon.leong.ong@intel.com \ --cc=Joao.Pinto@synopsys.com \ --cc=Jose.Abreu@synopsys.com \ --cc=alexandre.torgue@st.com \ --cc=alexandru.ardelean@analog.com \ --cc=arnd@arndb.de \ --cc=davem@davemloft.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ --cc=tee.min.tan@intel.com \ --cc=weifeng.voon@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.