From: kbuild test robot <lkp@intel.com> To: Jeremy Linton <jeremy.linton@arm.com> Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, wahrenst@gmx.net, andrew@lunn.ch, hkallweit1@gmail.com, Jeremy Linton <jeremy.linton@arm.com> Subject: Re: [PATCH 2/6] net: bcmgenet: refactor phy mode configuration Date: Thu, 6 Feb 2020 05:05:10 +0800 [thread overview] Message-ID: <202002060443.937aTdBH%lkp@intel.com> (raw) In-Reply-To: <20200201074625.8698-3-jeremy.linton@arm.com> Hi Jeremy, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.5] [also build test WARNING on next-20200205] [cannot apply to net/master net-next/master linus/master ipvs/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jeremy-Linton/Add-ACPI-bindings-to-the-genet/20200203-101928 base: d5226fa6dbae0569ee43ecfc08bdcd6770fc4755 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> smatch warnings: drivers/net/ethernet/broadcom/genet/bcmmii.c:485 bcmgenet_phy_interface_init() warn: unsigned 'priv->phy_interface' is never less than zero. vim +485 drivers/net/ethernet/broadcom/genet/bcmmii.c 479 480 static int bcmgenet_phy_interface_init(struct bcmgenet_priv *priv) 481 { 482 struct device *kdev = &priv->pdev->dev; 483 484 priv->phy_interface = device_get_phy_mode(kdev); > 485 if (priv->phy_interface < 0) { 486 dev_dbg(kdev, "invalid PHY mode property\n"); 487 priv->phy_interface = PHY_INTERFACE_MODE_RGMII; 488 } 489 490 /* We need to specifically look up whether this PHY interface is internal 491 * or not *before* we even try to probe the PHY driver over MDIO as we 492 * may have shut down the internal PHY for power saving purposes. 493 */ 494 if (priv->phy_interface == PHY_INTERFACE_MODE_INTERNAL) 495 priv->internal_phy = true; 496 497 return 0; 498 } 499 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/6] net: bcmgenet: refactor phy mode configuration Date: Thu, 06 Feb 2020 05:05:10 +0800 [thread overview] Message-ID: <202002060443.937aTdBH%lkp@intel.com> (raw) In-Reply-To: <20200201074625.8698-3-jeremy.linton@arm.com> [-- Attachment #1: Type: text/plain, Size: 1897 bytes --] Hi Jeremy, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v5.5] [also build test WARNING on next-20200205] [cannot apply to net/master net-next/master linus/master ipvs/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jeremy-Linton/Add-ACPI-bindings-to-the-genet/20200203-101928 base: d5226fa6dbae0569ee43ecfc08bdcd6770fc4755 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> smatch warnings: drivers/net/ethernet/broadcom/genet/bcmmii.c:485 bcmgenet_phy_interface_init() warn: unsigned 'priv->phy_interface' is never less than zero. vim +485 drivers/net/ethernet/broadcom/genet/bcmmii.c 479 480 static int bcmgenet_phy_interface_init(struct bcmgenet_priv *priv) 481 { 482 struct device *kdev = &priv->pdev->dev; 483 484 priv->phy_interface = device_get_phy_mode(kdev); > 485 if (priv->phy_interface < 0) { 486 dev_dbg(kdev, "invalid PHY mode property\n"); 487 priv->phy_interface = PHY_INTERFACE_MODE_RGMII; 488 } 489 490 /* We need to specifically look up whether this PHY interface is internal 491 * or not *before* we even try to probe the PHY driver over MDIO as we 492 * may have shut down the internal PHY for power saving purposes. 493 */ 494 if (priv->phy_interface == PHY_INTERFACE_MODE_INTERNAL) 495 priv->internal_phy = true; 496 497 return 0; 498 } 499 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
next prev parent reply other threads:[~2020-02-05 21:06 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-01 7:46 [PATCH 0/6] Add ACPI bindings to the genet Jeremy Linton 2020-02-01 7:46 ` [PATCH 1/6] mdio_bus: Add generic mdio_find_bus() Jeremy Linton 2020-02-01 7:46 ` [PATCH 2/6] net: bcmgenet: refactor phy mode configuration Jeremy Linton 2020-02-01 16:24 ` Florian Fainelli 2020-02-01 19:10 ` Jeremy Linton 2020-02-03 1:17 ` Andrew Lunn 2020-02-03 3:24 ` Florian Fainelli 2020-02-03 18:46 ` Jeremy Linton 2020-02-03 18:55 ` Florian Fainelli 2020-02-05 21:05 ` kbuild test robot [this message] 2020-02-05 21:05 ` kbuild test robot 2020-02-01 7:46 ` [PATCH 3/6] net: bcmgenet: enable automatic phy discovery Jeremy Linton 2020-02-01 15:25 ` Andrew Lunn 2020-02-01 19:07 ` Jeremy Linton 2020-02-03 20:55 ` Florian Fainelli 2020-02-03 21:21 ` Andrew Lunn 2020-02-01 20:02 ` Jeremy Linton 2020-02-03 1:15 ` Andrew Lunn 2020-02-03 21:10 ` Jeremy Linton 2020-02-01 7:46 ` [PATCH 4/6] net: bcmgenet: Initial bcmgenet ACPI support Jeremy Linton 2020-02-01 15:33 ` Andrew Lunn 2020-02-01 19:09 ` Jeremy Linton 2020-02-01 7:46 ` [PATCH 5/6] net: bcmgenet: Fetch MAC address from the adapter Jeremy Linton 2020-02-01 15:37 ` Andrew Lunn 2020-02-01 19:20 ` Jeremy Linton 2020-02-01 7:46 ` [PATCH 6/6] net: bcmgenet: reduce severity of missing clock warnings Jeremy Linton 2020-02-01 16:18 ` Florian Fainelli 2020-02-01 16:44 ` Stefan Wahren 2020-02-01 19:27 ` Jeremy Linton 2020-02-03 18:36 ` Nicolas Saenz Julienne 2020-02-03 19:08 ` Stefan Wahren 2020-02-03 21:21 ` Florian Fainelli 2020-02-05 18:42 ` Stefan Wahren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202002060443.937aTdBH%lkp@intel.com \ --to=lkp@intel.com \ --cc=andrew@lunn.ch \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=davem@davemloft.net \ --cc=f.fainelli@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=jeremy.linton@arm.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=opendmb@gmail.com \ --cc=wahrenst@gmx.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.