All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, dev@dpdk.org, mtosatti@redhat.com,
	thomas@monjalon.net, bluca@debian.org, jerinjacobk@gmail.com,
	bruce.richardson@intel.com
Subject: Re: [RFC PATCH 6/7] vfio/pci: Remove dev_fmt definition
Date: Thu, 6 Feb 2020 14:45:06 +0100	[thread overview]
Message-ID: <20200206144506.178ba10a.cohuck@redhat.com> (raw)
In-Reply-To: <158085758432.9445.12129266614127683867.stgit@gimli.home>

On Tue, 04 Feb 2020 16:06:24 -0700
Alex Williamson <alex.williamson@redhat.com> wrote:

> It currently results in messages like:
> 
>  "vfio-pci 0000:03:00.0: vfio_pci: ..."
> 
> Which is quite a bit redundant.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>  drivers/vfio/pci/vfio_pci.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index 026308aa18b5..343fe38ed06b 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -9,7 +9,6 @@
>   */
>  
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -#define dev_fmt pr_fmt
>  
>  #include <linux/device.h>
>  #include <linux/eventfd.h>
> 

Yes, that looks a bit superfluous.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>


WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, dev@dpdk.org, mtosatti@redhat.com,
	thomas@monjalon.net, bluca@debian.org, jerinjacobk@gmail.com,
	bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [RFC PATCH 6/7] vfio/pci: Remove dev_fmt definition
Date: Thu, 6 Feb 2020 14:45:06 +0100	[thread overview]
Message-ID: <20200206144506.178ba10a.cohuck@redhat.com> (raw)
In-Reply-To: <158085758432.9445.12129266614127683867.stgit@gimli.home>

On Tue, 04 Feb 2020 16:06:24 -0700
Alex Williamson <alex.williamson@redhat.com> wrote:

> It currently results in messages like:
> 
>  "vfio-pci 0000:03:00.0: vfio_pci: ..."
> 
> Which is quite a bit redundant.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>  drivers/vfio/pci/vfio_pci.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index 026308aa18b5..343fe38ed06b 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -9,7 +9,6 @@
>   */
>  
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -#define dev_fmt pr_fmt
>  
>  #include <linux/device.h>
>  #include <linux/eventfd.h>
> 

Yes, that looks a bit superfluous.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>


  reply	other threads:[~2020-02-06 13:45 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 23:05 [RFC PATCH 0/7] vfio/pci: SR-IOV support Alex Williamson
2020-02-04 23:05 ` [dpdk-dev] " Alex Williamson
2020-02-04 23:05 ` [RFC PATCH 1/7] vfio: Include optional device match in vfio_device_ops callbacks Alex Williamson
2020-02-04 23:05   ` [dpdk-dev] " Alex Williamson
2020-02-06 11:14   ` Cornelia Huck
2020-02-06 11:14     ` [dpdk-dev] " Cornelia Huck
2020-02-06 18:18     ` Alex Williamson
2020-02-06 18:18       ` [dpdk-dev] " Alex Williamson
2020-02-07  9:33       ` Cornelia Huck
2020-02-07  9:33         ` [dpdk-dev] " Cornelia Huck
2020-02-04 23:05 ` [RFC PATCH 2/7] vfio/pci: Implement match ops Alex Williamson
2020-02-04 23:05   ` [dpdk-dev] " Alex Williamson
2020-02-04 23:06 ` [RFC PATCH 3/7] vfio/pci: Introduce VF token Alex Williamson
2020-02-04 23:06   ` [dpdk-dev] " Alex Williamson
2020-02-05  4:19   ` kbuild test robot
2020-02-05  7:57   ` Liu, Yi L
2020-02-05  7:57     ` [dpdk-dev] " Liu, Yi L
2020-02-05 14:13     ` Alex Williamson
2020-02-05 14:13       ` [dpdk-dev] " Alex Williamson
2020-02-04 23:06 ` [RFC PATCH 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user Alex Williamson
2020-02-04 23:06   ` [dpdk-dev] " Alex Williamson
2020-02-04 23:06 ` [RFC PATCH 5/7] vfio/pci: Add sriov_configure support Alex Williamson
2020-02-04 23:06   ` [dpdk-dev] " Alex Williamson
2020-02-04 23:06 ` [RFC PATCH 6/7] vfio/pci: Remove dev_fmt definition Alex Williamson
2020-02-04 23:06   ` [dpdk-dev] " Alex Williamson
2020-02-06 13:45   ` Cornelia Huck [this message]
2020-02-06 13:45     ` Cornelia Huck
2020-02-04 23:06 ` [RFC PATCH 7/7] vfio/pci: Cleanup .probe() exit paths Alex Williamson
2020-02-04 23:06   ` [dpdk-dev] " Alex Williamson
2020-02-04 23:17 ` [RFC PATCH 0/7] vfio/pci: SR-IOV support Alex Williamson
2020-02-04 23:17   ` [dpdk-dev] " Alex Williamson
2020-02-05  7:57   ` Liu, Yi L
2020-02-05  7:57     ` [dpdk-dev] " Liu, Yi L
2020-02-05 14:18     ` Alex Williamson
2020-02-05 14:18       ` [dpdk-dev] " Alex Williamson
2020-02-05  7:01 ` Christoph Hellwig
2020-02-05  7:01   ` [dpdk-dev] " Christoph Hellwig
2020-02-05 13:58   ` Alex Williamson
2020-02-05 13:58     ` [dpdk-dev] " Alex Williamson
2020-02-05  7:57 ` Liu, Yi L
2020-02-05  7:57   ` [dpdk-dev] " Liu, Yi L
2020-02-05 14:10   ` Alex Williamson
2020-02-05 14:10     ` [dpdk-dev] " Alex Williamson
2020-02-11 11:18 ` Jerin Jacob
2020-02-11 11:18   ` [dpdk-dev] " Jerin Jacob
2020-02-11 13:57   ` Thomas Monjalon
2020-02-11 17:06   ` Alex Williamson
2020-02-11 17:06     ` [dpdk-dev] " Alex Williamson
2020-02-11 18:03     ` Jerin Jacob
2020-02-11 18:03       ` [dpdk-dev] " Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206144506.178ba10a.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinjacobk@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.