* [PATCH] blk-mq: Update blk_mq_map_queue() documentation
@ 2020-02-06 17:50 Daniel Wagner
2020-02-07 3:56 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Wagner @ 2020-02-06 17:50 UTC (permalink / raw)
To: linux-block; +Cc: Jens Axboe, Daniel Wagner
Commit 8ccdf4a37752 ("blk-mq: save queue mapping result into ctx
directly") changed the last argument name from cpu to ctx but missed
to update the documentation.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
block/blk-mq.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq.h b/block/blk-mq.h
index eaaca8fc1c28..76921a970c32 100644
--- a/block/blk-mq.h
+++ b/block/blk-mq.h
@@ -97,7 +97,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
* blk_mq_map_queue() - map (cmd_flags,type) to hardware queue
* @q: request queue
* @flags: request command flags
- * @cpu: cpu ctx
+ * @ctx: software queue state
*/
static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
unsigned int flags,
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blk-mq: Update blk_mq_map_queue() documentation
2020-02-06 17:50 [PATCH] blk-mq: Update blk_mq_map_queue() documentation Daniel Wagner
@ 2020-02-07 3:56 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2020-02-07 3:56 UTC (permalink / raw)
To: Daniel Wagner, linux-block; +Cc: Jens Axboe
On 2020-02-06 09:50, Daniel Wagner wrote:
> Commit 8ccdf4a37752 ("blk-mq: save queue mapping result into ctx
> directly") changed the last argument name from cpu to ctx but missed
> to update the documentation.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> block/blk-mq.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.h b/block/blk-mq.h
> index eaaca8fc1c28..76921a970c32 100644
> --- a/block/blk-mq.h
> +++ b/block/blk-mq.h
> @@ -97,7 +97,7 @@ static inline struct blk_mq_hw_ctx *blk_mq_map_queue_type(struct request_queue *
> * blk_mq_map_queue() - map (cmd_flags,type) to hardware queue
> * @q: request queue
> * @flags: request command flags
> - * @cpu: cpu ctx
> + * @ctx: software queue state
> */
> static inline struct blk_mq_hw_ctx *blk_mq_map_queue(struct request_queue *q,
> unsigned int flags,
Just "software queue" instead of "software queue state" probably would
have been more clear. I think that's the name that is used elsewhere in
the block layer. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-07 3:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 17:50 [PATCH] blk-mq: Update blk_mq_map_queue() documentation Daniel Wagner
2020-02-07 3:56 ` Bart Van Assche
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.