[PATCH 0/3] MAINTAINERS: Cover orphean qapi/json files

[PATCH 0/3] MAINTAINERS: Cover orphean qapi/json files

[Philippe Mathieu-Daudé]

Few orphean files noticed while looking at Peter series:
"Convert QAPI doc comments to generate rST instead of texinfo"
https://www.mail-archive.com/qemu-devel@nongnu.org/msg677500.html

Philippe Mathieu-Daudé (3):
  MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section
  MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core'
    section
  MAINTAINERS: Cover qapi/trace.json in 'Tracing' section

 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.21.1

[PATCH 1/3] MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section

[Philippe Mathieu-Daudé]

List this file in the proper section, so maintainers get
notified when it is modified.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: Jason Wang <jasowang@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e72b5e5f69..903831e0a4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1680,6 +1680,7 @@ F: tests/qtest/vmxnet3-test.c
 Rocker
 M: Jiri Pirko <jiri@resnulli.us>
 S: Maintained
+F: qapi/rocker.json
 F: hw/net/rocker/
 F: tests/rocker/
 F: docs/specs/rocker.txt
-- 
2.21.1

[PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

[Philippe Mathieu-Daudé]

List this file in the proper section, so maintainers get
notified when it is modified.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 903831e0a4..e269e9092c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1842,6 +1842,8 @@ S: Supported
 F: block*
 F: block/
 F: hw/block/
+F: qapi/block.json
+F: qapi/block-core.json
 F: include/block/
 F: qemu-img*
 F: docs/interop/qemu-img.rst
-- 
2.21.1

[PATCH 3/3] MAINTAINERS: Cover qapi/trace.json in 'Tracing' section

[Philippe Mathieu-Daudé]

List this file in the proper section, so maintainers get
notified when it is modified.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Stefan Hajnoczi <stefanha@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e269e9092c..d3f8e2eb6c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2205,6 +2205,7 @@ F: qemu-option-trace.texi
 F: scripts/tracetool.py
 F: scripts/tracetool/
 F: scripts/qemu-trace-stap*
+F: qapi/trace.json
 F: docs/interop/qemu-trace-stap.rst
 F: docs/devel/tracing.txt
 T: git https://github.com/stefanha/qemu.git tracing
-- 
2.21.1

Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

[Max Reitz]

[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]

On 07.02.20 11:30, Philippe Mathieu-Daudé wrote:
> List this file in the proper section, so maintainers get
> notified when it is modified.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: qemu-block@nongnu.org
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> List this file in the proper section, so maintainers get
> notified when it is modified.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: qemu-block@nongnu.org
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 903831e0a4..e269e9092c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1842,6 +1842,8 @@ S: Supported
   Block layer core
   M: Kevin Wolf <kwolf@redhat.com>
   M: Max Reitz <mreitz@redhat.com>
   L: qemu-block@nongnu.org
   S: Supported
>  F: block*
>  F: block/
>  F: hw/block/
> +F: qapi/block.json
> +F: qapi/block-core.json
>  F: include/block/
>  F: qemu-img*
>  F: docs/interop/qemu-img.rst

This is in addition to

    Block QAPI, monitor, command line
    M: Markus Armbruster <armbru@redhat.com>
    S: Supported
    F: blockdev.c
    F: block/qapi.c
    F: qapi/block*.json
    F: qapi/transaction.json
    T: git https://repo.or.cz/qemu/armbru.git block-next

I'm not sure this section makes much sense anymore.

Should qapi/transaction.json also be added to "Block layer core"?  Or
should it go into John's section "Block Jobs"?

Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

[Kevin Wolf]

Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> 
> > List this file in the proper section, so maintainers get
> > notified when it is modified.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Cc: Max Reitz <mreitz@redhat.com>
> > Cc: qemu-block@nongnu.org
> > ---
> >  MAINTAINERS | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 903831e0a4..e269e9092c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1842,6 +1842,8 @@ S: Supported
>    Block layer core
>    M: Kevin Wolf <kwolf@redhat.com>
>    M: Max Reitz <mreitz@redhat.com>
>    L: qemu-block@nongnu.org
>    S: Supported
> >  F: block*
> >  F: block/
> >  F: hw/block/
> > +F: qapi/block.json
> > +F: qapi/block-core.json
> >  F: include/block/
> >  F: qemu-img*
> >  F: docs/interop/qemu-img.rst
> 
> This is in addition to
> 
>     Block QAPI, monitor, command line
>     M: Markus Armbruster <armbru@redhat.com>
>     S: Supported
>     F: blockdev.c
>     F: block/qapi.c
>     F: qapi/block*.json
>     F: qapi/transaction.json
>     T: git https://repo.or.cz/qemu/armbru.git block-next
> 
> I'm not sure this section makes much sense anymore.

This is probably for you to decide.

Though the block-next branch from the T: line doesn't even exist any
more...

> Should qapi/transaction.json also be added to "Block layer core"?  Or
> should it go into John's section "Block Jobs"?

I think at the moment it only supports actions that are more related to
block jobs, so moving it there would make sense to me.

Kevin

Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

[Markus Armbruster]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>> 
>> > List this file in the proper section, so maintainers get
>> > notified when it is modified.
>> >
>> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> > ---
>> > Cc: Kevin Wolf <kwolf@redhat.com>
>> > Cc: Max Reitz <mreitz@redhat.com>
>> > Cc: qemu-block@nongnu.org
>> > ---
>> >  MAINTAINERS | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 903831e0a4..e269e9092c 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -1842,6 +1842,8 @@ S: Supported
>>    Block layer core
>>    M: Kevin Wolf <kwolf@redhat.com>
>>    M: Max Reitz <mreitz@redhat.com>
>>    L: qemu-block@nongnu.org
>>    S: Supported
>> >  F: block*
>> >  F: block/
>> >  F: hw/block/
>> > +F: qapi/block.json
>> > +F: qapi/block-core.json
>> >  F: include/block/
>> >  F: qemu-img*
>> >  F: docs/interop/qemu-img.rst
>> 
>> This is in addition to
>> 
>>     Block QAPI, monitor, command line
>>     M: Markus Armbruster <armbru@redhat.com>
>>     S: Supported
>>     F: blockdev.c
>>     F: block/qapi.c
>>     F: qapi/block*.json
>>     F: qapi/transaction.json
>>     T: git https://repo.or.cz/qemu/armbru.git block-next
>> 
>> I'm not sure this section makes much sense anymore.
>
> This is probably for you to decide.
>
> Though the block-next branch from the T: line doesn't even exist any
> more...

I have the questionable habit to delete my -next branches when they're
empty.

>> Should qapi/transaction.json also be added to "Block layer core"?  Or
>> should it go into John's section "Block Jobs"?
>
> I think at the moment it only supports actions that are more related to
> block jobs, so moving it there would make sense to me.

Alright, what about this:

diff --git a/MAINTAINERS b/MAINTAINERS
index e72b5e5f69..43e821c901 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1842,6 +1842,8 @@ F: block*
 F: block/
 F: hw/block/
 F: include/block/
+F: qapi/block.json
+F: qapi/block-core.json
 F: qemu-img*
 F: docs/interop/qemu-img.rst
 F: qemu-io*
@@ -1887,16 +1889,8 @@ F: block/commit.c
 F: block/stream.c
 F: block/mirror.c
 F: qapi/job.json
-T: git https://github.com/jnsnow/qemu.git jobs
-
-Block QAPI, monitor, command line
-M: Markus Armbruster <armbru@redhat.com>
-S: Supported
-F: blockdev.c
-F: block/qapi.c
-F: qapi/block*.json
 F: qapi/transaction.json
-T: git https://repo.or.cz/qemu/armbru.git block-next
+T: git https://github.com/jnsnow/qemu.git jobs
 
 Dirty Bitmaps
 M: John Snow <jsnow@redhat.com>

Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section

[Philippe Mathieu-Daudé]

On 2/7/20 5:07 PM, Markus Armbruster wrote:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
>> Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
>>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>
>>>> List this file in the proper section, so maintainers get
>>>> notified when it is modified.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> ---
>>>> Cc: Kevin Wolf <kwolf@redhat.com>
>>>> Cc: Max Reitz <mreitz@redhat.com>
>>>> Cc: qemu-block@nongnu.org
>>>> ---
>>>>   MAINTAINERS | 2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 903831e0a4..e269e9092c 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -1842,6 +1842,8 @@ S: Supported
>>>     Block layer core
>>>     M: Kevin Wolf <kwolf@redhat.com>
>>>     M: Max Reitz <mreitz@redhat.com>
>>>     L: qemu-block@nongnu.org
>>>     S: Supported
>>>>   F: block*
>>>>   F: block/
>>>>   F: hw/block/
>>>> +F: qapi/block.json
>>>> +F: qapi/block-core.json
>>>>   F: include/block/
>>>>   F: qemu-img*
>>>>   F: docs/interop/qemu-img.rst
>>>
>>> This is in addition to
>>>
>>>      Block QAPI, monitor, command line
>>>      M: Markus Armbruster <armbru@redhat.com>
>>>      S: Supported
>>>      F: blockdev.c
>>>      F: block/qapi.c
>>>      F: qapi/block*.json
>>>      F: qapi/transaction.json
>>>      T: git https://repo.or.cz/qemu/armbru.git block-next
>>>
>>> I'm not sure this section makes much sense anymore.
>>
>> This is probably for you to decide.
>>
>> Though the block-next branch from the T: line doesn't even exist any
>> more...
> 
> I have the questionable habit to delete my -next branches when they're
> empty.

Having dangling -next branches pointing to something very previous is 
also questionable...