* [PATCH 0/3] MAINTAINERS: Cover orphean qapi/json files
@ 2020-02-07 10:30 Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 1/3] MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-07 10:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Philippe Mathieu-Daudé
Few orphean files noticed while looking at Peter series:
"Convert QAPI doc comments to generate rST instead of texinfo"
https://www.mail-archive.com/qemu-devel@nongnu.org/msg677500.html
Philippe Mathieu-Daudé (3):
MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section
MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core'
section
MAINTAINERS: Cover qapi/trace.json in 'Tracing' section
MAINTAINERS | 4 ++++
1 file changed, 4 insertions(+)
--
2.21.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section
2020-02-07 10:30 [PATCH 0/3] MAINTAINERS: Cover orphean qapi/json files Philippe Mathieu-Daudé
@ 2020-02-07 10:30 ` Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 3/3] MAINTAINERS: Cover qapi/trace.json in 'Tracing' section Philippe Mathieu-Daudé
2 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-07 10:30 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Jiri Pirko, Jason Wang, Philippe Mathieu-Daudé
List this file in the proper section, so maintainers get
notified when it is modified.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: Jason Wang <jasowang@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e72b5e5f69..903831e0a4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1680,6 +1680,7 @@ F: tests/qtest/vmxnet3-test.c
Rocker
M: Jiri Pirko <jiri@resnulli.us>
S: Maintained
+F: qapi/rocker.json
F: hw/net/rocker/
F: tests/rocker/
F: docs/specs/rocker.txt
--
2.21.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section
2020-02-07 10:30 [PATCH 0/3] MAINTAINERS: Cover orphean qapi/json files Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 1/3] MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section Philippe Mathieu-Daudé
@ 2020-02-07 10:30 ` Philippe Mathieu-Daudé
2020-02-07 10:56 ` Max Reitz
2020-02-07 14:01 ` Markus Armbruster
2020-02-07 10:30 ` [PATCH 3/3] MAINTAINERS: Cover qapi/trace.json in 'Tracing' section Philippe Mathieu-Daudé
2 siblings, 2 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-07 10:30 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Kevin Wolf, Philippe Mathieu-Daudé,
qemu-block, Max Reitz
List this file in the proper section, so maintainers get
notified when it is modified.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 903831e0a4..e269e9092c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1842,6 +1842,8 @@ S: Supported
F: block*
F: block/
F: hw/block/
+F: qapi/block.json
+F: qapi/block-core.json
F: include/block/
F: qemu-img*
F: docs/interop/qemu-img.rst
--
2.21.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] MAINTAINERS: Cover qapi/trace.json in 'Tracing' section
2020-02-07 10:30 [PATCH 0/3] MAINTAINERS: Cover orphean qapi/json files Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 1/3] MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section Philippe Mathieu-Daudé
@ 2020-02-07 10:30 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-07 10:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Philippe Mathieu-Daudé, Stefan Hajnoczi
List this file in the proper section, so maintainers get
notified when it is modified.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Stefan Hajnoczi <stefanha@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e269e9092c..d3f8e2eb6c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2205,6 +2205,7 @@ F: qemu-option-trace.texi
F: scripts/tracetool.py
F: scripts/tracetool/
F: scripts/qemu-trace-stap*
+F: qapi/trace.json
F: docs/interop/qemu-trace-stap.rst
F: docs/devel/tracing.txt
T: git https://github.com/stefanha/qemu.git tracing
--
2.21.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section
2020-02-07 10:30 ` [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section Philippe Mathieu-Daudé
@ 2020-02-07 10:56 ` Max Reitz
2020-02-07 14:01 ` Markus Armbruster
1 sibling, 0 replies; 9+ messages in thread
From: Max Reitz @ 2020-02-07 10:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Kevin Wolf, qemu-block
[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]
On 07.02.20 11:30, Philippe Mathieu-Daudé wrote:
> List this file in the proper section, so maintainers get
> notified when it is modified.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: qemu-block@nongnu.org
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section
2020-02-07 10:30 ` [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section Philippe Mathieu-Daudé
2020-02-07 10:56 ` Max Reitz
@ 2020-02-07 14:01 ` Markus Armbruster
2020-02-07 14:21 ` Kevin Wolf
1 sibling, 1 reply; 9+ messages in thread
From: Markus Armbruster @ 2020-02-07 14:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Kevin Wolf, qemu-block, qemu-trivial, qemu-devel, Max Reitz, John Snow
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> List this file in the proper section, so maintainers get
> notified when it is modified.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: qemu-block@nongnu.org
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 903831e0a4..e269e9092c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1842,6 +1842,8 @@ S: Supported
Block layer core
M: Kevin Wolf <kwolf@redhat.com>
M: Max Reitz <mreitz@redhat.com>
L: qemu-block@nongnu.org
S: Supported
> F: block*
> F: block/
> F: hw/block/
> +F: qapi/block.json
> +F: qapi/block-core.json
> F: include/block/
> F: qemu-img*
> F: docs/interop/qemu-img.rst
This is in addition to
Block QAPI, monitor, command line
M: Markus Armbruster <armbru@redhat.com>
S: Supported
F: blockdev.c
F: block/qapi.c
F: qapi/block*.json
F: qapi/transaction.json
T: git https://repo.or.cz/qemu/armbru.git block-next
I'm not sure this section makes much sense anymore.
Should qapi/transaction.json also be added to "Block layer core"? Or
should it go into John's section "Block Jobs"?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section
2020-02-07 14:01 ` Markus Armbruster
@ 2020-02-07 14:21 ` Kevin Wolf
2020-02-07 16:07 ` Markus Armbruster
0 siblings, 1 reply; 9+ messages in thread
From: Kevin Wolf @ 2020-02-07 14:21 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-block, qemu-trivial, Philippe Mathieu-Daudé,
qemu-devel, Max Reitz, John Snow
Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
> > List this file in the proper section, so maintainers get
> > notified when it is modified.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Cc: Max Reitz <mreitz@redhat.com>
> > Cc: qemu-block@nongnu.org
> > ---
> > MAINTAINERS | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 903831e0a4..e269e9092c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1842,6 +1842,8 @@ S: Supported
> Block layer core
> M: Kevin Wolf <kwolf@redhat.com>
> M: Max Reitz <mreitz@redhat.com>
> L: qemu-block@nongnu.org
> S: Supported
> > F: block*
> > F: block/
> > F: hw/block/
> > +F: qapi/block.json
> > +F: qapi/block-core.json
> > F: include/block/
> > F: qemu-img*
> > F: docs/interop/qemu-img.rst
>
> This is in addition to
>
> Block QAPI, monitor, command line
> M: Markus Armbruster <armbru@redhat.com>
> S: Supported
> F: blockdev.c
> F: block/qapi.c
> F: qapi/block*.json
> F: qapi/transaction.json
> T: git https://repo.or.cz/qemu/armbru.git block-next
>
> I'm not sure this section makes much sense anymore.
This is probably for you to decide.
Though the block-next branch from the T: line doesn't even exist any
more...
> Should qapi/transaction.json also be added to "Block layer core"? Or
> should it go into John's section "Block Jobs"?
I think at the moment it only supports actions that are more related to
block jobs, so moving it there would make sense to me.
Kevin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section
2020-02-07 14:21 ` Kevin Wolf
@ 2020-02-07 16:07 ` Markus Armbruster
2020-02-07 16:27 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 9+ messages in thread
From: Markus Armbruster @ 2020-02-07 16:07 UTC (permalink / raw)
To: Kevin Wolf
Cc: qemu-block, qemu-trivial, Philippe Mathieu-Daudé,
qemu-devel, Max Reitz, John Snow
Kevin Wolf <kwolf@redhat.com> writes:
> Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>> > List this file in the proper section, so maintainers get
>> > notified when it is modified.
>> >
>> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> > ---
>> > Cc: Kevin Wolf <kwolf@redhat.com>
>> > Cc: Max Reitz <mreitz@redhat.com>
>> > Cc: qemu-block@nongnu.org
>> > ---
>> > MAINTAINERS | 2 ++
>> > 1 file changed, 2 insertions(+)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 903831e0a4..e269e9092c 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -1842,6 +1842,8 @@ S: Supported
>> Block layer core
>> M: Kevin Wolf <kwolf@redhat.com>
>> M: Max Reitz <mreitz@redhat.com>
>> L: qemu-block@nongnu.org
>> S: Supported
>> > F: block*
>> > F: block/
>> > F: hw/block/
>> > +F: qapi/block.json
>> > +F: qapi/block-core.json
>> > F: include/block/
>> > F: qemu-img*
>> > F: docs/interop/qemu-img.rst
>>
>> This is in addition to
>>
>> Block QAPI, monitor, command line
>> M: Markus Armbruster <armbru@redhat.com>
>> S: Supported
>> F: blockdev.c
>> F: block/qapi.c
>> F: qapi/block*.json
>> F: qapi/transaction.json
>> T: git https://repo.or.cz/qemu/armbru.git block-next
>>
>> I'm not sure this section makes much sense anymore.
>
> This is probably for you to decide.
>
> Though the block-next branch from the T: line doesn't even exist any
> more...
I have the questionable habit to delete my -next branches when they're
empty.
>> Should qapi/transaction.json also be added to "Block layer core"? Or
>> should it go into John's section "Block Jobs"?
>
> I think at the moment it only supports actions that are more related to
> block jobs, so moving it there would make sense to me.
Alright, what about this:
diff --git a/MAINTAINERS b/MAINTAINERS
index e72b5e5f69..43e821c901 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1842,6 +1842,8 @@ F: block*
F: block/
F: hw/block/
F: include/block/
+F: qapi/block.json
+F: qapi/block-core.json
F: qemu-img*
F: docs/interop/qemu-img.rst
F: qemu-io*
@@ -1887,16 +1889,8 @@ F: block/commit.c
F: block/stream.c
F: block/mirror.c
F: qapi/job.json
-T: git https://github.com/jnsnow/qemu.git jobs
-
-Block QAPI, monitor, command line
-M: Markus Armbruster <armbru@redhat.com>
-S: Supported
-F: blockdev.c
-F: block/qapi.c
-F: qapi/block*.json
F: qapi/transaction.json
-T: git https://repo.or.cz/qemu/armbru.git block-next
+T: git https://github.com/jnsnow/qemu.git jobs
Dirty Bitmaps
M: John Snow <jsnow@redhat.com>
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section
2020-02-07 16:07 ` Markus Armbruster
@ 2020-02-07 16:27 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-07 16:27 UTC (permalink / raw)
To: Markus Armbruster, Kevin Wolf
Cc: qemu-trivial, John Snow, qemu-devel, qemu-block, Max Reitz
On 2/7/20 5:07 PM, Markus Armbruster wrote:
> Kevin Wolf <kwolf@redhat.com> writes:
>
>> Am 07.02.2020 um 15:01 hat Markus Armbruster geschrieben:
>>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>
>>>> List this file in the proper section, so maintainers get
>>>> notified when it is modified.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> ---
>>>> Cc: Kevin Wolf <kwolf@redhat.com>
>>>> Cc: Max Reitz <mreitz@redhat.com>
>>>> Cc: qemu-block@nongnu.org
>>>> ---
>>>> MAINTAINERS | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 903831e0a4..e269e9092c 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -1842,6 +1842,8 @@ S: Supported
>>> Block layer core
>>> M: Kevin Wolf <kwolf@redhat.com>
>>> M: Max Reitz <mreitz@redhat.com>
>>> L: qemu-block@nongnu.org
>>> S: Supported
>>>> F: block*
>>>> F: block/
>>>> F: hw/block/
>>>> +F: qapi/block.json
>>>> +F: qapi/block-core.json
>>>> F: include/block/
>>>> F: qemu-img*
>>>> F: docs/interop/qemu-img.rst
>>>
>>> This is in addition to
>>>
>>> Block QAPI, monitor, command line
>>> M: Markus Armbruster <armbru@redhat.com>
>>> S: Supported
>>> F: blockdev.c
>>> F: block/qapi.c
>>> F: qapi/block*.json
>>> F: qapi/transaction.json
>>> T: git https://repo.or.cz/qemu/armbru.git block-next
>>>
>>> I'm not sure this section makes much sense anymore.
>>
>> This is probably for you to decide.
>>
>> Though the block-next branch from the T: line doesn't even exist any
>> more...
>
> I have the questionable habit to delete my -next branches when they're
> empty.
Having dangling -next branches pointing to something very previous is
also questionable...
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-02-07 16:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 10:30 [PATCH 0/3] MAINTAINERS: Cover orphean qapi/json files Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 1/3] MAINTAINERS: Cover qapi/rocker.json in 'Rocker' section Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 2/3] MAINTAINERS: Cover qapi/block{-core}.json in 'Block layer core' section Philippe Mathieu-Daudé
2020-02-07 10:56 ` Max Reitz
2020-02-07 14:01 ` Markus Armbruster
2020-02-07 14:21 ` Kevin Wolf
2020-02-07 16:07 ` Markus Armbruster
2020-02-07 16:27 ` Philippe Mathieu-Daudé
2020-02-07 10:30 ` [PATCH 3/3] MAINTAINERS: Cover qapi/trace.json in 'Tracing' section Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.