All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/3] tests/kms_fbcon_fbt: Check for psr before keeling over
@ 2020-01-28 11:25 Daniel Vetter
  2020-01-28 11:25 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_fbcon_fbt: User interactive debug helper Daniel Vetter
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Daniel Vetter @ 2020-01-28 11:25 UTC (permalink / raw)
  To: IGT development; +Cc: Daniel Vetter, Dhinakaran Pandiyan, Rodrigo Vivi

Not exactly sure where this broke, or whether it ever worked, but the
psr_disable helper calls igt_skip if psr doesn't work. Which means we
neeed to check for that first.

In general lib/igt_psr.c seems to be a library in dire need of some TLC.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_fbcon_fbt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index acbb6d303f62..506848cfcf47 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -222,7 +222,8 @@ static bool psr_wait_until_update(int debugfs_fd)
 static void disable_features(int debugfs_fd)
 {
 	igt_set_module_param_int("enable_fbc", 0);
-	psr_disable(debugfs_fd);
+	if (psr_sink_support(debugfs_fd, PSR_MODE_1))
+		psr_disable(debugfs_fd);
 }
 
 static inline void fbc_modparam_enable(int debugfs_fd)
-- 
2.24.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2020-02-10  8:04 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-28 11:25 [igt-dev] [PATCH i-g-t 1/3] tests/kms_fbcon_fbt: Check for psr before keeling over Daniel Vetter
2020-01-28 11:25 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_fbcon_fbt: User interactive debug helper Daniel Vetter
2020-02-07 14:21   ` Ville Syrjälä
2020-01-28 11:25 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_fbcon_fbt: Drop master before restoring fbcon Daniel Vetter
2020-02-07 14:19   ` Ville Syrjälä
2020-02-07 15:29     ` Daniel Vetter
2020-02-07 15:36       ` Ville Syrjälä
2020-02-10  8:04         ` Daniel Vetter
2020-01-28 15:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tests/kms_fbcon_fbt: Check for psr before keeling over Patchwork
2020-01-29 20:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-02-07 14:24 ` [igt-dev] [PATCH i-g-t 1/3] " Ville Syrjälä

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.